From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF0F1A053B; Fri, 17 Jul 2020 15:38:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BF2E81C126; Fri, 17 Jul 2020 15:38:16 +0200 (CEST) Received: from mail-qv1-f68.google.com (mail-qv1-f68.google.com [209.85.219.68]) by dpdk.org (Postfix) with ESMTP id C68EB1C116 for ; Fri, 17 Jul 2020 15:38:15 +0200 (CEST) Received: by mail-qv1-f68.google.com with SMTP id ed14so4237982qvb.2 for ; Fri, 17 Jul 2020 06:38:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4hEs3ocsq3rvg5X4Nf4V59OWjpCxFTJeO8hKFESmtLQ=; b=dTX9DHChFKor83xUH638I+BhuMgBCEiKK3/qEdnZ72/lmSV33B4N6+zhHEQoWVhjzG /KlXW3JYl7iHzJDrJCgtcN1nDngxTy81UvVwlwMnxS7B1W0FFne1/wtJNmBjfaNkWYnJ GmSkP+GeRBowpzbGnUC9WznE5+ilTUIVklAMA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4hEs3ocsq3rvg5X4Nf4V59OWjpCxFTJeO8hKFESmtLQ=; b=go0SMtqsu6IZSS8ReU5jFS5VFZsgnibe1wjw34mjmstXanL+Zw8hY6+DZ0HiFIHkyf UYaelsgDBnv7kIjUFkZNqG5rqeccn4FLgBGXpbj+G2c+Du86KCX4nI4S852v4JYWEpnX NfV77QCKq0YQGSBTPV6ONKJoEDnf6RJ4g601u7pbt5yTBPuVPXgOzcmp4weoxw3JKbWa YEJJeBxjoyo0MXlMgI85n2VKT989btQndGQ04HHu8BFBnb5awhXc0yzkb4cESkYSmwAe swtQJ8QCXe7w9hcjhIlzhLm5k1e92YHfEXsegAQ+/gLVOeDSneiA8/pW4PglfbeAhpDR TJUg== X-Gm-Message-State: AOAM531ksF6AIrK2C+0M/GmmRs8UbFmCjz0LtoeUYDijjXyG1o9HsNSm 5PjLnGhJJZBN8zLt5x+o2nDcVkXz6KjxECy7G1NqUA== X-Google-Smtp-Source: ABdhPJxCWSb3uqF1sXGfcYig228TGzPjt5hTdtT1oBgCXwpHuaZ+zS/mxkPUbYLmkV/Kmwfz9624RZzokZ45b9Fp3cE= X-Received: by 2002:a0c:dc07:: with SMTP id s7mr9271196qvk.122.1594993094978; Fri, 17 Jul 2020 06:38:14 -0700 (PDT) MIME-Version: 1.0 References: <20200716194237.137641-1-ohilyard@iol.unh.edu> <20200716124853.2ccfc954@hermes.lan> In-Reply-To: <20200716124853.2ccfc954@hermes.lan> From: Owen Hilyard Date: Fri, 17 Jul 2020 09:37:39 -0400 Message-ID: To: Stephen Hemminger Cc: dts@dpdk.org, qi.z.zhang@intel.com, matan@mellanox.com, jerinj@marvell.com, suanmingm@mellanox.com, Thomas Monjalon , Lincoln Lavoie Content-Type: multipart/alternative; boundary="000000000000d892be05aaa3446b" Subject: Re: [dts] [PATCH] mac_filter: Add multicast filtering test case X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" --000000000000d892be05aaa3446b Content-Type: text/plain; charset="UTF-8" I'll add that into a patch with any other suggestions I see. I also added that to my linter so it shouldn't happen again. On Thu, Jul 16, 2020 at 3:49 PM Stephen Hemminger < stephen@networkplumber.org> wrote: > On Thu, 16 Jul 2020 15:42:36 -0400 > Owen Hilyard wrote: > > > Sorry about sending this twice, I noticed after todays meeting that this > was caught in the moderator queue and I want to get it out to the mailing > list at large asap. > > > > add multicast filtering test case > > add multicast test case test plan > > > > Signed-off-by: Owen Hilyard > > --- > > test_plans/mac_filter_test_plan.rst | 27 ++++++++++++++++++++ > > tests/TestSuite_mac_filter.py | 39 ++++++++++++++++++++++++++--- > > 2 files changed, 62 insertions(+), 4 deletions(-) > > > > diff --git a/test_plans/mac_filter_test_plan.rst > b/test_plans/mac_filter_test_plan.rst > > index 1335e9f..e8a4f66 100644 > > --- a/test_plans/mac_filter_test_plan.rst > > +++ b/test_plans/mac_filter_test_plan.rst > > @@ -172,3 +172,30 @@ Add one more different address:: > > testpmd> mac_addr add 0 > > > > Verify that the response is "No space left on device" (-ENOSPC) > > + > > +Test Case: Multicast Filter > > +=========================== > > + > > +Initialize first port without ``promiscuous mode``:: > > + > > + testpmd> set promisc 0 off > > + > > + > > +Add the multicast MAC address to the multicast filter:: > > + > > + testpmd> mcast_addr add 0 01:00:5E:00:00:00 > > + > > +Send a packet with multicast destination MAC address to port 0:: > > + > > + port 0/queue 0: received 1 packets > > + src=52:00:00:00:00:00 - dst=01:00:5E:00:00:00 - type=0x0800 - > length=60 - nb_segs=1 - hw ptype: L2_ETHER L3_IPV4_EXT_UNKNOWN L4_UDP - > sw ptype: L2_ETHER L3_IPV4 L4_UDP - l2_len=14 - l3_len=20 - l4_len=8 - > Receive queue=0x0 > > + ol_flags: PKT_RX_L4_CKSUM_GOOD PKT_RX_IP_CKSUM_GOOD > PKT_RX_OUTER_L4_CKSUM_UNKNOWN > > + > > + > > +Remove the multicast MAC address from the multicast filter:: > > + > > + testpmd> mcast_addr remove 0 01:00:5E:00:00:00 > > + > > +Send a packet with multicast destination MAC address to port 0 > > + > > +Verify that the packet was not received (Check for "received" in the > output). There will be no output if the nic responds properly. > > \ No newline at end of file > > Ok, but you must fix this. > > Please set your editor so it generates text files that always have a > newline at the end. > Although git supports files without ending newline, it is not something we > want in this project. > --000000000000d892be05aaa3446b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I'll add that into a patch with any other suggestions = I see. I also added that to my linter so it shouldn't happen again.
On T= hu, Jul 16, 2020 at 3:49 PM Stephen Hemminger <stephen@networkplumber.org> wrote:
On Thu, 16 Jul 2020 15:42:36= -0400
Owen Hilyard <= ohilyard@iol.unh.edu> wrote:

> Sorry about sending this twice, I noticed after todays meeting that th= is was caught in the moderator queue and I want to get it out to the mailin= g list at large asap.
>
> add multicast filtering test case
> add multicast test case test plan
>
> Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
> ---
>=C2=A0 test_plans/mac_filter_test_plan.rst | 27 ++++++++++++++++++++ >=C2=A0 tests/TestSuite_mac_filter.py=C2=A0 =C2=A0 =C2=A0 =C2=A0| 39 +++= +++++++++++++++++++++++---
>=C2=A0 2 files changed, 62 insertions(+), 4 deletions(-)
>
> diff --git a/test_plans/mac_filter_test_plan.rst b/test_plans/mac_filt= er_test_plan.rst
> index 1335e9f..e8a4f66 100644
> --- a/test_plans/mac_filter_test_plan.rst
> +++ b/test_plans/mac_filter_test_plan.rst
> @@ -172,3 +172,30 @@ Add one more different address::
>=C2=A0 =C2=A0 =C2=A0testpmd> mac_addr add 0 <A+n+1>=C2=A0
>=C2=A0
>=C2=A0 Verify that the response is "No space left on device" = (-ENOSPC)
> +
> +Test Case: Multicast Filter
> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D
> +
> +Initialize first port without ``promiscuous mode``::
> +
> +=C2=A0 testpmd> set promisc 0 off
> +
> +
> +Add the multicast MAC address to the multicast filter::
> +
> +=C2=A0 =C2=A0testpmd> mcast_addr add 0 01:00:5E:00:00:00
> +
> +Send a packet with multicast destination MAC address to port 0::
> +
> +=C2=A0 =C2=A0port 0/queue 0: received 1 packets
> +=C2=A0 =C2=A0 =C2=A0src=3D52:00:00:00:00:00 - dst=3D01:00:5E:00:00:00= - type=3D0x0800 - length=3D60 - nb_segs=3D1 - hw=C2=A0 =C2=A0 ptype: L2_ET= HER L3_IPV4_EXT_UNKNOWN L4_UDP=C2=A0 - sw ptype: L2_ETHER L3_IPV4 L4_UDP=C2= =A0 - l2_len=3D14 - l3_len=3D20 - l4_len=3D8 - Receive queue=3D0x0
> +=C2=A0 =C2=A0 =C2=A0ol_flags: PKT_RX_L4_CKSUM_GOOD PKT_RX_IP_CKSUM_GO= OD PKT_RX_OUTER_L4_CKSUM_UNKNOWN
> +
> +
> +Remove the multicast MAC address from the multicast filter::
> +
> +=C2=A0 =C2=A0testpmd> mcast_addr remove 0 01:00:5E:00:00:00
> +
> +Send a packet with multicast destination MAC address to port 0
> +
> +Verify that the packet was not received (Check for "received&quo= t; in the output). There will be no output if the nic responds properly. > \ No newline at end of file

Ok, but you must fix this.

Please set your editor so it generates text files that always have a newlin= e at the end.
Although git supports files without ending newline, it is not something we = want in this project.
--000000000000d892be05aaa3446b--