From: Owen Hilyard <ohilyard@iol.unh.edu>
To: David Marchand <david.marchand@redhat.com>
Cc: Lijuan Tu <lijuan.tu@intel.com>, David Liu <dliu@iol.unh.edu>,
dts@dpdk.org, Aaron Conole <aconole@redhat.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dts] [PATCH] Revert "Strip prompt by default in send_expect"
Date: Wed, 26 May 2021 10:24:11 -0400 [thread overview]
Message-ID: <CAHx6DYC=aNCRt+ZRoESi7Cq_ZC9ZwmittTsU1E01763c0--Ziw@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8wxkSeS5EWPFM_dwA8n7WbxGG7Xx3JDrqf88Zk8v5KY8A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 923 bytes --]
Passing trim_whitespace=True was my solution to issues like this when I
created the patch.
On Wed, May 26, 2021 at 8:23 AM David Marchand <david.marchand@redhat.com>
wrote:
> On Wed, May 12, 2021 at 10:14 AM Lijuan Tu <lijuan.tu@intel.com> wrote:
> >
> > This reverts commit f498f50a62e30f6f8fb9c4e1a759e3d35861b978.
> > As it casued some cases failed:
> > * flow_classify_softnic
> > * test_ipv4_acl_jump
> > * test_ipv4_acl_table
> > * test_ipv6_hash_jump
> > * unit_tests_loopback
> > * test_link_mode
> > * test_loopback_mode
> > * distributor
> > * maximum_workers
>
> Any update on having both worlds (UNH lab and those tests) coexist?
>
> I see an exhaustive list of tests that are broken with the new behavior.
> Another approach to reverting the whole change is to pass
> trim_whitespace= in the affected tests.
> Was this idea considered?
>
>
> --
> David Marchand
>
>
[-- Attachment #2: Type: text/html, Size: 1416 bytes --]
next prev parent reply other threads:[~2021-05-26 14:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 16:12 Lijuan Tu
2021-05-12 8:19 ` Tu, Lijuan
2021-05-26 12:23 ` David Marchand
2021-05-26 14:24 ` Owen Hilyard [this message]
2021-06-02 7:36 ` David Marchand
2021-06-02 7:41 ` Tu, Lijuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHx6DYC=aNCRt+ZRoESi7Cq_ZC9ZwmittTsU1E01763c0--Ziw@mail.gmail.com' \
--to=ohilyard@iol.unh.edu \
--cc=aconole@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dliu@iol.unh.edu \
--cc=dts@dpdk.org \
--cc=lijuan.tu@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).