From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D08CAA0546; Wed, 26 May 2021 16:24:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 992804067C; Wed, 26 May 2021 16:24:48 +0200 (CEST) Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) by mails.dpdk.org (Postfix) with ESMTP id 9248440150 for ; Wed, 26 May 2021 16:24:47 +0200 (CEST) Received: by mail-ot1-f43.google.com with SMTP id t10-20020a05683022eab0290304ed8bc759so1133695otc.12 for ; Wed, 26 May 2021 07:24:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vaTKJNWhiriWmnmUSmACN3XAB9D2bczWp55ZIucZ7G8=; b=fd1iVapu34Ya8faSSD3+J8AG/72xyL4srrwEEthj4G5l+WLkbGtaq46lAZBmjXV5fO NUTHyl0FNV3MrmmmPlmay2PaJe2wrivSNsyzpK9EGH66w092vedyMIR90F8m2oe2iq1W yA8kiI3sR92iWcPodkHpEuxFa6N918y3KhqG4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vaTKJNWhiriWmnmUSmACN3XAB9D2bczWp55ZIucZ7G8=; b=LbpB/Jjpjh922cTIb9lUmyOl3pDfhNUJ+KIOo7w+R/ANZ1jTC/+u9f0i8WwUDoPcpc BCKWzUWrP6JkonHFwaGuZasXDa2K0H9Vix21x6uUl2V5OB3uvZE9jRoBX+DZcCOiwXfp QSRFxvTByI0JpPESjfUEzGVhGC73ld9HiHdx68gqKOFJ2G4DuBedrwPJLhfNLfZeKCX5 UN8jsTSUb9dxKV0WQEZgVcT7qmdWlDhGkj8QbE+MJ1Uj8kW2i71qr+puPKOWC84M4HwV Y/spbmnPj7WdsisVi73KBnHFzSiJOToiSz0deBQ/Qh7JwzQ6E/J8ETyKEW/5ToGumjYx 6n/Q== X-Gm-Message-State: AOAM531lK0s7KpN3L3g7aV4Zi+exme8poTeHUsEtJc41NSCfdoKW8I0P aoKwZp8d3BEPZwh1GhPZBSvF4Vg7aOJ7dWPsedxy0g== X-Google-Smtp-Source: ABdhPJw+t2yPyqUyYKRCWaPiLhRqahNmILuTs/yuJWN6FvDAHBmjHX7K4yxYVgW4LZKF1NozGOzAHjPp8GLIDFizSPE= X-Received: by 2002:a9d:269:: with SMTP id 96mr2643842otb.222.1622039086922; Wed, 26 May 2021 07:24:46 -0700 (PDT) MIME-Version: 1.0 References: <1620835921-182513-1-git-send-email-lijuan.tu@intel.com> In-Reply-To: From: Owen Hilyard Date: Wed, 26 May 2021 10:24:11 -0400 Message-ID: To: David Marchand Cc: Lijuan Tu , David Liu , dts@dpdk.org, Aaron Conole , Thomas Monjalon Content-Type: multipart/alternative; boundary="0000000000009689f905c33c67cb" Subject: Re: [dts] [PATCH] Revert "Strip prompt by default in send_expect" X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" --0000000000009689f905c33c67cb Content-Type: text/plain; charset="UTF-8" Passing trim_whitespace=True was my solution to issues like this when I created the patch. On Wed, May 26, 2021 at 8:23 AM David Marchand wrote: > On Wed, May 12, 2021 at 10:14 AM Lijuan Tu wrote: > > > > This reverts commit f498f50a62e30f6f8fb9c4e1a759e3d35861b978. > > As it casued some cases failed: > > * flow_classify_softnic > > * test_ipv4_acl_jump > > * test_ipv4_acl_table > > * test_ipv6_hash_jump > > * unit_tests_loopback > > * test_link_mode > > * test_loopback_mode > > * distributor > > * maximum_workers > > Any update on having both worlds (UNH lab and those tests) coexist? > > I see an exhaustive list of tests that are broken with the new behavior. > Another approach to reverting the whole change is to pass > trim_whitespace= in the affected tests. > Was this idea considered? > > > -- > David Marchand > > --0000000000009689f905c33c67cb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Passing trim_whitespace=3DTrue was my solution to issues l= ike this when I created the patch.

On Wed, May 26, 2021 at 8:23 AM David Mar= chand <david.marchand@redha= t.com> wrote:
On Wed, May 12, 2021 at 10:14 AM Lijuan Tu <lijuan.tu@intel.com> wrote:
>
> This reverts commit f498f50a62e30f6f8fb9c4e1a759e3d35861b978.
> As it casued some cases failed:
>=C2=A0 =C2=A0* flow_classify_softnic
>=C2=A0 =C2=A0 =C2=A0 =C2=A0* test_ipv4_acl_jump
>=C2=A0 =C2=A0 =C2=A0 =C2=A0* test_ipv4_acl_table
>=C2=A0 =C2=A0 =C2=A0 =C2=A0* test_ipv6_hash_jump
>=C2=A0 =C2=A0* unit_tests_loopback
>=C2=A0 =C2=A0 =C2=A0 =C2=A0* test_link_mode
>=C2=A0 =C2=A0 =C2=A0 =C2=A0* test_loopback_mode
>=C2=A0 =C2=A0* distributor
>=C2=A0 =C2=A0 =C2=A0 =C2=A0* maximum_workers

Any update on having both worlds (UNH lab and those tests) coexist?

I see an exhaustive list of tests that are broken with the new behavior. Another approach to reverting the whole change is to pass
trim_whitespace=3D in the affected tests.
Was this idea considered?


--
David Marchand

--0000000000009689f905c33c67cb--