test suite reviews and discussions
 help / color / mirror / Atom feed
From: Owen Hilyard <ohilyard@iol.unh.edu>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
Cc: "dts@dpdk.org" <dts@dpdk.org>,
	"lijuan.tu@intel.com" <lijuan.tu@intel.com>
Subject: Re: [PATCH v3 2/3] update files depending on tests/util
Date: Thu, 14 Apr 2022 15:53:44 -0400	[thread overview]
Message-ID: <CAHx6DYC=b58zA+YG9wZ-We28ESf6nZtxdxxr96HAzF7gAZZ6Pw@mail.gmail.com> (raw)
In-Reply-To: <d52aa2fc97df40af96782315d5899266@pantheon.tech>

[-- Attachment #1: Type: text/plain, Size: 1471 bytes --]

I moved the files over and ran the formatter, which produced a diff large
enough that the mailing list rejected it when I bundled it with the first
commit. I could split things up more, but that would lead to an extra 2 or
3 patches in this series that contain formatting unrelated to the problem,
simply because unformatted patches are getting merged. I hadn't anticipated
needing granularity in the formatter because nothing except what you just
worked on was supposed to be changing when you ran it, and the tools we're
using don't support parts of a file.

I don't want to have to keep submitting "ran the formatter" patches every
week or two, since that will lead to a very messy git history.  I could
submit one more and rebase this series on top of it, which would let me
send it in as two organized commits. Thoughts?

On Thu, Apr 14, 2022 at 1:40 AM Juraj Linkeš <juraj.linkes@pantheon.tech>
wrote:

>
> > diff --git a/framework/dut.py b/framework/dut.py index 6a8fc957..83f0d7a2
> > 100644
> > --- a/framework/dut.py
> > +++ b/framework/dut.py
> > @@ -46,7 +46,7 @@ from .settings import LOG_NAME_SEP, NICS  from
> > .ssh_connection import SSHConnection  from .test_result import
> ResultTable
> > from .utils import RED, remove_old_rsa_key -from .virt_resource import
> > VirtResource
> > +from framework.virt_resource import VirtResource
>
> And this also didn't get addressed, I guess you just added the commit in
> v3.
>
>

[-- Attachment #2: Type: text/html, Size: 1799 bytes --]

  reply	other threads:[~2022-04-14 19:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-13 14:54 [PATCH v3 1/3] framework: Move test-specific files to test directory ohilyard
2022-04-13 14:54 ` [PATCH v3 2/3] update files depending on tests/util ohilyard
2022-04-14  5:40   ` Juraj Linkeš
2022-04-14 19:53     ` Owen Hilyard [this message]
2022-04-20  8:45       ` Juraj Linkeš
2022-04-13 14:54 ` [PATCH v3 3/3] all: ran formatter ohilyard
2022-04-14  5:39 ` [PATCH v3 1/3] framework: Move test-specific files to test directory Juraj Linkeš

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHx6DYC=b58zA+YG9wZ-We28ESf6nZtxdxxr96HAzF7gAZZ6Pw@mail.gmail.com' \
    --to=ohilyard@iol.unh.edu \
    --cc=dts@dpdk.org \
    --cc=juraj.linkes@pantheon.tech \
    --cc=lijuan.tu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).