From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D1EAA0509; Thu, 14 Apr 2022 21:54:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33D4D4067E; Thu, 14 Apr 2022 21:54:22 +0200 (CEST) Received: from mail-oa1-f42.google.com (mail-oa1-f42.google.com [209.85.160.42]) by mails.dpdk.org (Postfix) with ESMTP id 12A2E4067C for ; Thu, 14 Apr 2022 21:54:21 +0200 (CEST) Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-d6ca46da48so6290173fac.12 for ; Thu, 14 Apr 2022 12:54:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xNytUj2QGFWU4VDpGMamYtXLd7n+9W54FEK4lD/iaRQ=; b=IZXjPzoXPN+GhwgivYh8sSNl2mKT73jMf20brtam1t+wPA/vKmUb9LzaijquwcXq6e BNtEJXmXr+0j4OEa2eHx1kAtkPqWzjA6JMafW8eaTrgEOO4Rb8PgVAlDYqDEo0berdmT DPqzstdgK/uvRrJAC8DFIlf7SNDgDKV4Q1SaQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xNytUj2QGFWU4VDpGMamYtXLd7n+9W54FEK4lD/iaRQ=; b=Ir29xdtGl4xASrcMIhdy7p33NWyNRSr+rj8/bqwHCby3d6HQYVeIBcKgZnm+5VMvJP IfG71xM0B+b9/daPJ7YBDCvilQW/KZ+8WxNSCangtX3dpJJWvv6Ta6XJQiZjHC5t3fFY yT+ShMzg7Hhb5CPc42AupZ1CowkThRtIQaD3HlPCB7/QDhE7lBz1SpMCRV3HLhV+Sd6b 446XJAaX5jzcB6LZO4kXOwIYv3Q+A5Ke0h4rGe0JRmweWEvv07b+yhJ2SElqpGwes2Bo wq27Mq2KZmjE1sKiEEp8oA4NdwaVUgbDjrTslKRNV7LUik72hSeckOcrUuGb4UuQepR7 qRjA== X-Gm-Message-State: AOAM532LODHQFUgYrC8Thy7rmS2+YYk7nIlpBSOv3JX28vj7O5kmobxo P+xy/1vG1RIgaVXzlNkF563cTwJv36MZ1aFTKJMmLQ== X-Google-Smtp-Source: ABdhPJy3gQ4dgnnNLc3/9rQvwOam4S7MYMMaUBes742QTONgmf6FMRH0DNiIUbQjoe/rpDb09eKYGZM14UW6BwirnOk= X-Received: by 2002:a05:6870:e244:b0:e2:d03a:41e1 with SMTP id d4-20020a056870e24400b000e2d03a41e1mr83165oac.19.1649966060304; Thu, 14 Apr 2022 12:54:20 -0700 (PDT) MIME-Version: 1.0 References: <20220413145437.31526-1-ohilyard@iol.unh.edu> <20220413145437.31526-2-ohilyard@iol.unh.edu> In-Reply-To: From: Owen Hilyard Date: Thu, 14 Apr 2022 15:53:44 -0400 Message-ID: Subject: Re: [PATCH v3 2/3] update files depending on tests/util To: =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: "dts@dpdk.org" , "lijuan.tu@intel.com" Content-Type: multipart/alternative; boundary="000000000000ea8ed105dca2a834" X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org --000000000000ea8ed105dca2a834 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I moved the files over and ran the formatter, which produced a diff large enough that the mailing list rejected it when I bundled it with the first commit. I could split things up more, but that would lead to an extra 2 or 3 patches in this series that contain formatting unrelated to the problem, simply because unformatted patches are getting merged. I hadn't anticipated needing granularity in the formatter because nothing except what you just worked on was supposed to be changing when you ran it, and the tools we're using don't support parts of a file. I don't want to have to keep submitting "ran the formatter" patches every week or two, since that will lead to a very messy git history. I could submit one more and rebase this series on top of it, which would let me send it in as two organized commits. Thoughts? On Thu, Apr 14, 2022 at 1:40 AM Juraj Linke=C5=A1 wrote: > > > diff --git a/framework/dut.py b/framework/dut.py index 6a8fc957..83f0d7= a2 > > 100644 > > --- a/framework/dut.py > > +++ b/framework/dut.py > > @@ -46,7 +46,7 @@ from .settings import LOG_NAME_SEP, NICS from > > .ssh_connection import SSHConnection from .test_result import > ResultTable > > from .utils import RED, remove_old_rsa_key -from .virt_resource import > > VirtResource > > +from framework.virt_resource import VirtResource > > And this also didn't get addressed, I guess you just added the commit in > v3. > > --000000000000ea8ed105dca2a834 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I moved the files over and ran the formatter, which produc= ed a diff large enough that the mailing list rejected it when I bundled it = with the first commit. I could split things up more, but that would lead to= an extra 2 or 3 patches in this series that contain formatting unrelated t= o the problem, simply because unformatted patches are getting merged. I had= n't anticipated needing granularity in the formatter because nothing ex= cept what you just worked on was supposed=C2=A0to be changing when you ran = it, and the tools we're using don't support parts of a file.=C2=A0<= div>
I don't want to have to keep submitting "ran th= e formatter" patches every week or two, since that will lead to a very= messy git history.=C2=A0 I could submit one more and rebase this series on= top of it, which would let me send it in as two organized commits. Thought= s?

On Thu, Apr 14, 2022 at 1:40 AM Juraj Linke=C5=A1 <juraj.linkes@= pantheon.tech> wrote:

> diff --git a/framework/dut.py b/framework/dut.py index 6a8fc957..83f0d= 7a2
> 100644
> --- a/framework/dut.py
> +++ b/framework/dut.py
> @@ -46,7 +46,7 @@ from .settings import LOG_NAME_SEP, NICS=C2=A0 from<= br> > .ssh_connection import SSHConnection=C2=A0 from .test_result import Re= sultTable
> from .utils import RED, remove_old_rsa_key -from .virt_resource import=
> VirtResource
> +from framework.virt_resource import VirtResource

And this also didn't get addressed, I guess you just added the commit i= n v3.

--000000000000ea8ed105dca2a834--