test suite reviews and discussions
 help / color / mirror / Atom feed
From: Owen Hilyard <ohilyard@iol.unh.edu>
To: Dong JunX <junx.dong@intel.com>
Cc: dts@dpdk.org, "Tu, Lijuan" <lijuan.tu@intel.com>, weix.ling@intel.com
Subject: Re: [RFC] [PATCH V1] framework/*: Add function to support ASan test
Date: Tue, 14 Dec 2021 10:40:55 -0500	[thread overview]
Message-ID: <CAHx6DYCTq-n533V=SEM5KyXovvRA-s7vES9W-nmjZkLrAHaEVg@mail.gmail.com> (raw)
In-Reply-To: <1639130270-232144-1-git-send-email-junx.dong@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]

Am I missing where this is disabled for performance tests? Both ASAN and
LSAN have a large performance impact, especially in any code that allocates
a lot of memory. I have no objections to using this in functional testing,
since performance doesn't matter that much there.

I also can't tell if this changes the json output for a test suite. If an
asan failure does not cause a test case/suite to fail, (which I think it
should), then we need to have that information available in
test_results.json, probably as a new key under the per-crb output. If an
asan failure does cause the test case/suite to fail, then I don't think we
need extra output.

Finally, I think the config file needs to describe all of the options and
what their valid values are, nic_single_core_perf.cfg is a good example of
this. Also, I would prefer to avoid embedding json in the config files if
possible, and I think that we might be able to have the start and end
values for each of the sanitizers be stored as a pair, so we would have
something like this:

lsan_bounds=LeakSanitizer, SUMMARY
asan_bounds=AddressSanitizer, SUMMARY

That would avoid needing to use json parsing and you could just access by
index.

Owen Hilyard

[-- Attachment #2: Type: text/html, Size: 1396 bytes --]

  reply	other threads:[~2021-12-14 15:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-10  9:57 Dong JunX
2021-12-14 15:40 ` Owen Hilyard [this message]
2022-01-14 10:03   ` Tu, Lijuan
2022-01-14 13:44     ` Owen Hilyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHx6DYCTq-n533V=SEM5KyXovvRA-s7vES9W-nmjZkLrAHaEVg@mail.gmail.com' \
    --to=ohilyard@iol.unh.edu \
    --cc=dts@dpdk.org \
    --cc=junx.dong@intel.com \
    --cc=lijuan.tu@intel.com \
    --cc=weix.ling@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).