test suite reviews and discussions
 help / color / mirror / Atom feed
* [PATCH v1] tests/nic_single_core_perf: Initalize packet generator
@ 2022-01-18 16:30 ohilyard
  2022-01-18 18:11 ` Owen Hilyard
  0 siblings, 1 reply; 4+ messages in thread
From: ohilyard @ 2022-01-18 16:30 UTC (permalink / raw)
  To: dts; +Cc: ohilyard, lijuan.tu

From: Owen Hilyard <ohilyard@iol.unh.edu>

Call the initialization function for the packet generator to make sure
it is set up properly before trying to use it.

Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
---
 tests/TestSuite_nic_single_core_perf.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/TestSuite_nic_single_core_perf.py b/tests/TestSuite_nic_single_core_perf.py
index 1012dbf3..8515861b 100644
--- a/tests/TestSuite_nic_single_core_perf.py
+++ b/tests/TestSuite_nic_single_core_perf.py
@@ -89,6 +89,7 @@ class TestNicSingleCorePerf(TestCase):
             self.output_path = os.sep.join([cur_path, self.logger.log_path])
         # create an instance to set stream field setting
         self.pktgen_helper = PacketGeneratorHelper()
+        self.tester.init_ext_gen()
 
     def set_up(self):
         """
-- 
2.30.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] tests/nic_single_core_perf: Initalize packet generator
  2022-01-18 16:30 [PATCH v1] tests/nic_single_core_perf: Initalize packet generator ohilyard
@ 2022-01-18 18:11 ` Owen Hilyard
  2022-01-24 20:35   ` [PATCH v2] " ohilyard
  0 siblings, 1 reply; 4+ messages in thread
From: Owen Hilyard @ 2022-01-18 18:11 UTC (permalink / raw)
  To: dts; +Cc: Tu, Lijuan

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

After more testing, it seems like this causes issues for some Nics due to
various compatibility workarounds elsewhere in DTS. I'll submit a v2 once
I've found the root cause and a fix for it.

[-- Attachment #2: Type: text/html, Size: 242 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2] tests/nic_single_core_perf: Initalize packet generator
  2022-01-18 18:11 ` Owen Hilyard
@ 2022-01-24 20:35   ` ohilyard
  2022-01-26  6:23     ` Tu, Lijuan
  0 siblings, 1 reply; 4+ messages in thread
From: ohilyard @ 2022-01-24 20:35 UTC (permalink / raw)
  To: dts; +Cc: ohilyard, lijuan.tu

From: Owen Hilyard <ohilyard@iol.unh.edu>

Call the initialization function for the packet generator to make sure
it is set up properly before trying to use it.

Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
---
 framework/pktgen_trex.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/framework/pktgen_trex.py b/framework/pktgen_trex.py
index 2f537a0b..9f245dfd 100644
--- a/framework/pktgen_trex.py
+++ b/framework/pktgen_trex.py
@@ -791,6 +791,7 @@ class TrexPacketGenerator(PacketGenerator):
             msg = 'no stream options for trex packet generator'
             raise Exception(msg)
 
+        self._conn.connect()
         self._conn.reset(ports=self._ports)
         config_inst = TrexConfigStream()
         for port_id, config in port_config.items():
-- 
2.30.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH v2] tests/nic_single_core_perf: Initalize packet generator
  2022-01-24 20:35   ` [PATCH v2] " ohilyard
@ 2022-01-26  6:23     ` Tu, Lijuan
  0 siblings, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2022-01-26  6:23 UTC (permalink / raw)
  To: ohilyard, dts

> -----Original Message-----
> From: ohilyard@iol.unh.edu <ohilyard@iol.unh.edu>
> Sent: 2022年1月25日 4:36
> To: dts@dpdk.org
> Cc: ohilyard@iol.unh.edu; Tu, Lijuan <lijuan.tu@intel.com>
> Subject: [PATCH v2] tests/nic_single_core_perf: Initalize packet generator
> 
> From: Owen Hilyard <ohilyard@iol.unh.edu>
> 
> Call the initialization function for the packet generator to make sure it is set up
> properly before trying to use it.
> 
> Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>

Applied, thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-01-26  6:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-18 16:30 [PATCH v1] tests/nic_single_core_perf: Initalize packet generator ohilyard
2022-01-18 18:11 ` Owen Hilyard
2022-01-24 20:35   ` [PATCH v2] " ohilyard
2022-01-26  6:23     ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).