test suite reviews and discussions
 help / color / mirror / Atom feed
From: Owen Hilyard <ohilyard@iol.unh.edu>
To: "Tu, Lijuan" <lijuan.tu@intel.com>
Cc: "Ma, LihongX" <lihongx.ma@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>,
	 "Zhang, Yuwei1" <yuwei1.zhang@intel.com>,
	 "changqingx.wu@intel.com" <changqingx.wu@intel.com>,
	"Xiao, QimaiX" <qimaix.xiao@intel.com>,
	"Hunt, David" <david.hunt@intel.com>,
	"lylavoie@iol.unh.edu" <lylavoie@iol.unh.edu>
Subject: Re: [dts] [PATCH] rx interrupt: Fixed test case
Date: Fri, 11 Sep 2020 16:17:07 -0400	[thread overview]
Message-ID: <CAHx6DYChSYyJWQZdXGhqdJCn2ROWcEvASGwW69YYmY2HGMpzMg@mail.gmail.com> (raw)
In-Reply-To: <0a2e634c71be4012ad463dadb47a3ac9@intel.com>

[-- Attachment #1: Type: text/plain, Size: 3909 bytes --]

After looking into it, the l3fwd-power tool does not have the capability to
change queue numbers or mappings without restarting. Testpmd currently
lacks the ability (as far as I know) to bind a queue to an lcore. Is this a
feature that would be reasonable to add to testpmd or should I drop work on
this test case? This is turning into quite a time sink and I'm beginning to
think that it would be more beneficial to DTS if I focused on creating the
Flow API test suite rather than trying to make marginal improvements to
this test case.

Owen Hilyard

On Wed, Sep 9, 2020 at 1:58 AM Tu, Lijuan <lijuan.tu@intel.com> wrote:

> Hi Owen,
>
>
>
> Reduce the number of invocations is a good idea, and your design is more
> perfect for a common case. But we still need to consider the boundary, the
> minimum and the maximum queue number. I really suggest we might get a
> random number from the minimum, maximum, and normal queue number, if then
> invocation is reduced, besides boundary checking is covered. Definitely we
> will run test for a long time not only once.
>
>
>
> thanks
>
>
>
> *From:* dts <dts-bounces@dpdk.org> *On Behalf Of * Owen Hilyard
> *Sent:* 2020年9月3日 2:42
> *To:* Ma, LihongX <lihongx.ma@intel.com>
> *Cc:* dts@dpdk.org; Zhang, Yuwei1 <yuwei1.zhang@intel.com>;
> changqingx.wu@intel.com; Xiao, QimaiX <qimaix.xiao@intel.com>; Hunt,
> David <david.hunt@intel.com>; lylavoie@iol.unh.edu
> *Subject:* Re: [dts] [PATCH] rx interrupt: Fixed test case
>
>
>
> Hello
>
> I'm able to see a material difference between what I've suggested and what
> the prior test case did. I was attempting to reduce the number of
> invocations of a pmd during the test, since those invocations are time
> consuming and, from what I measured, made up the majority of the runtime of
> the test. Is there a reason why all queues and port's can't be opened at
> the same time and then ignored until they are needed? The way I re-did the
> configs was designed to create all possible combinations of settings in the
> format that was originally there. Are all 3 invocations of the pmd needed
> or is it possible to merge those and throw out my other changes? Most of my
> changes were done because I was already planning on submitting a patch to
> remove the extra invocations and aren't as important.
>
> Thanks for your help
>
> Owen
>
>
>
> On Tue, Sep 1, 2020 at 10:02 PM Ma, LihongX <lihongx.ma@intel.com> wrote:
>
> Hi, Owen
> I think the change of the plan is not make sense, the case ' PF interrupt
> pmd with different queue' is want to test the interrupt on different queue,
> The original case will test the queue on min number, max number and normal
> number(between minimum and maximum), but your patch will only test one
> situation.
>
>
> Regards,
> Ma,lihong
>
> > -----Original Message-----
> > From: dts <dts-bounces@dpdk.org> On Behalf Of Owen Hilyard
> > Sent: Wednesday, August 26, 2020 11:04 PM
> > To: dts@dpdk.org
> > Cc: Zhang, Yuwei1 <yuwei1.zhang@intel.com>; changqingx.wu@intel.com;
> Xiao,
> > QimaiX <qimaix.xiao@intel.com>; Hunt, David <david.hunt@intel.com>;
> > lylavoie@iol.unh.edu; Owen Hilyard <ohilyard@iol.unh.edu>
> > Subject: [dts] [PATCH] rx interrupt: Fixed test case
> >
> > fixed test case issues with eal params
> > removed extra instances of l3fwd-power
> >
> > Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
> > ---
> >  test_plans/interrupt_pmd_test_plan.rst | 58 +++++++++-----------
> >  tests/TestSuite_interrupt_pmd.py       | 73 ++++++++++++++------------
> >  2 files changed, 64 insertions(+), 67 deletions(-)
> >
> > diff --git a/test_plans/interrupt_pmd_test_plan.rst
> > b/test_plans/interrupt_pmd_test_plan.rst
> > index cb8b2f1..1f8816d 100644
> > --- a/test_plans/interrupt_pmd_test_plan.rst
> > +++ b/test_plans/interrupt_pmd_test_plan.rst
>
>

[-- Attachment #2: Type: text/html, Size: 6909 bytes --]

      reply	other threads:[~2020-09-11 20:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-26 15:04 Owen Hilyard
2020-09-02  2:01 ` Ma, LihongX
2020-09-02 18:42   ` Owen Hilyard
2020-09-09  5:58     ` Tu, Lijuan
2020-09-11 20:17       ` Owen Hilyard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHx6DYChSYyJWQZdXGhqdJCn2ROWcEvASGwW69YYmY2HGMpzMg@mail.gmail.com \
    --to=ohilyard@iol.unh.edu \
    --cc=changqingx.wu@intel.com \
    --cc=david.hunt@intel.com \
    --cc=dts@dpdk.org \
    --cc=lihongx.ma@intel.com \
    --cc=lijuan.tu@intel.com \
    --cc=lylavoie@iol.unh.edu \
    --cc=qimaix.xiao@intel.com \
    --cc=yuwei1.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).