From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46EF0A050B; Wed, 13 Apr 2022 14:51:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E56540E09; Wed, 13 Apr 2022 14:51:22 +0200 (CEST) Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) by mails.dpdk.org (Postfix) with ESMTP id A29644068B for ; Wed, 13 Apr 2022 14:51:20 +0200 (CEST) Received: by mail-oi1-f181.google.com with SMTP id q189so1917615oia.9 for ; Wed, 13 Apr 2022 05:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=L2q23jii9mYplVKsjIpRytDOw3Du+qMMoC3xWzQxLlo=; b=N7fLISsoQzI/PKalMxW41HXNmkykRk6GHECxroi1otL3Mc1PTkToeV1BrS7HOBzS+V 6omBgtTSq4KxRCy1Ouk9R9wiU4B7J7R3rWqa6kYTuNNdKQvL+OKnNNmucDuTrgtMxBL2 LV7M7ARZYhsbOy33QTlH5ZjX7MhcUBPdoZksY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=L2q23jii9mYplVKsjIpRytDOw3Du+qMMoC3xWzQxLlo=; b=Bnndmh64nih5gigi5UHzn1TRJMWng43VwRbJx6NCtHN4PpOHdECChHZmU6AdgXyOd1 YN6jEp/NKJiTfsxVpoHbqFa3v5MqUeeQZ847NOhzT1jHnu9ZjiuhBc4u0XMQgyBjfXSE +bQYMkq8RqIKAeaU/qZi7lR4nKJabh3deuAymbWba1OIvLLvUgndPI0nFguwyePIAU8O ZjqVEsk2tDe3jv+TV8PJMslhpIfh7UPTJA8E9Zy2bsXaCpmzBZSnQtS2K+eathn0fMMl FdIdnXfNy6lZiBWP86Rc9g2y422Q+rQ/ooaUwDBp5Cjdp95lB+sUK4VNUWWdv4gDnmeA n+ug== X-Gm-Message-State: AOAM533fXRRZ9tjjF8XXJKCxoszSZF2qQczbFGYcx4pn/fM75lJKjiOW FCXxSnlzJSrcxp14AUzDDLR7/0UPBmcnHnKEQEr2vtQ5pVA= X-Google-Smtp-Source: ABdhPJxjYms8X7kKRoFEtpggQ9I9BJrJo+7PgANeFy+0V9Khew16LK99HePSh64HUiCXxuMeRzgyLjpBNgiGx0Eose8= X-Received: by 2002:a05:6808:f90:b0:2f9:7b1d:1f50 with SMTP id o16-20020a0568080f9000b002f97b1d1f50mr3674171oiw.19.1649854280084; Wed, 13 Apr 2022 05:51:20 -0700 (PDT) MIME-Version: 1.0 References: <20220411175549.14680-1-ohilyard@iol.unh.edu> In-Reply-To: From: Owen Hilyard Date: Wed, 13 Apr 2022 08:50:44 -0400 Message-ID: Subject: Re: [PATCH v2 1/2] framework: Move test-specific files to test directory To: =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: "dts@dpdk.org" , "lijuan.tu@intel.com" Content-Type: multipart/alternative; boundary="0000000000004bc4c205dc88a295" X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org --0000000000004bc4c205dc88a295 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable My bad, I'll move those in V3. On Wed, Apr 13, 2022 at 3:25 AM Juraj Linke=C5=A1 wrote: > > --- > > framework/flow/__init__.py | 0 > > framework/virt_resource.py | 2 +- > > tests/data/__init__.py | 2 ++ > > tests/util/__init__.py | 2 ++ > > tests/util/flow/__init__.py | 2 ++ > > {framework =3D> tests/util}/flow/enums.py | 0 > > {framework =3D> tests/util}/flow/exceptions.py | 0 > > {framework =3D> tests/util}/flow/flow.py | 0 > > {framework =3D> tests/util}/flow/flow_action_items.py | 0 > > {framework =3D> tests/util}/flow/flow_items.py | 8 +++----- > > {framework =3D> tests/util}/flow/flow_pattern_items.py | 0 > > {framework =3D> tests/util}/flow/flow_rule.py | 2 +- > > {framework =3D> tests/util}/flow/generator.py | 0 > > tests/util/virt/__init__.py | 2 ++ > > {framework =3D> tests/util/virt}/virt_base.py | 8 ++++---- > > {framework =3D> tests/util/virt}/virt_common.py | 8 ++++---- > > {framework =3D> tests/util/virt}/virt_dut.py | 10 +++++----- > > {framework =3D> tests/util/virt}/virt_scene.py | 12 ++++++----= -- > > As Lijian Mentioned, we should also move qemu_kvm and qemu_libvirt. As fa= r > as I can tell, the only virt file that needs to stay is virt_resource and > all of the rest (including qemu) can be moved. > > --0000000000004bc4c205dc88a295 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
My bad, I'll move those in V3.=C2=A0

On Wed, Apr 13, 20= 22 at 3:25 AM Juraj Linke=C5=A1 <juraj.linkes@pantheon.tech> wrote:
> ---
>=C2=A0 framework/flow/__init__.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 0
>=C2=A0 framework/virt_resource.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 2 +-
>=C2=A0 tests/data/__init__.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2= =A0 2 ++
>=C2=A0 tests/util/__init__.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2= =A0 2 ++
>=C2=A0 tests/util/flow/__init__.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 2 ++
>=C2=A0 {framework =3D> tests/util}/flow/enums.py=C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 0
>=C2=A0 {framework =3D> tests/util}/flow/exceptions.py=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0|=C2=A0 0
>=C2=A0 {framework =3D> tests/util}/flow/flow.py=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 0
>=C2=A0 {framework =3D> tests/util}/flow/flow_action_items.py=C2=A0 |= =C2=A0 0
>=C2=A0 {framework =3D> tests/util}/flow/flow_items.py=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0|=C2=A0 8 +++-----
>=C2=A0 {framework =3D> tests/util}/flow/flow_pattern_items.py |=C2= =A0 0
>=C2=A0 {framework =3D> tests/util}/flow/flow_rule.py=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 |=C2=A0 2 +-
>=C2=A0 {framework =3D> tests/util}/flow/generator.py=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 |=C2=A0 0
>=C2=A0 tests/util/virt/__init__.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 2 ++
>=C2=A0 {framework =3D> tests/util/virt}/virt_base.py=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 |=C2=A0 8 ++++----
>=C2=A0 {framework =3D> tests/util/virt}/virt_common.py=C2=A0 =C2=A0 = =C2=A0 =C2=A0 |=C2=A0 8 ++++----
>=C2=A0 {framework =3D> tests/util/virt}/virt_dut.py=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0| 10 +++++-----
>=C2=A0 {framework =3D> tests/util/virt}/virt_scene.py=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0| 12 ++++++------

As Lijian Mentioned, we should also move qemu_kvm and qemu_libvirt. As far = as I can tell, the only virt file that needs to stay is virt_resource and a= ll of the rest (including qemu) can be moved.

--0000000000004bc4c205dc88a295--