test suite reviews and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Xiang An <xiangx.an@intel.com>
Cc: dts@dpdk.org, "Peng, Yuan" <yuan.peng@intel.com>,
	techboard@dpdk.org,
	"Honnappa Nagarahalli" <Honnappa.Nagarahalli@arm.com>,
	"Juraj Linkeš" <juraj.linkes@pantheon.tech>,
	"Thomas Monjalon" <thomas@monjalon.net>
Subject: Re: [dts] [PATCH V4 1/2] tests/cvl_advanced_rss_gtpogre: add case parse_pfcp_over_gre_packet
Date: Mon, 7 Jun 2021 11:00:19 +0200	[thread overview]
Message-ID: <CAJFAV8w-DCOtQemy92DR7drGS5ioyz3emGNQMzzQAj9B-vUZLg@mail.gmail.com> (raw)
In-Reply-To: <1623036221-215538-2-git-send-email-xiangx.an@intel.com>

On Mon, Jun 7, 2021 at 5:13 AM Xiang An <xiangx.an@intel.com> wrote:
>

Empty commitlog...


> Signed-off-by: Xiang An <xiangx.an@intel.com>
> ---
>  tests/TestSuite_cvl_advanced_rss_gtpogre.py | 55 +++++++++++++++++++++++++++++
>  1 file changed, 55 insertions(+)
>
> diff --git a/tests/TestSuite_cvl_advanced_rss_gtpogre.py b/tests/TestSuite_cvl_advanced_rss_gtpogre.py
> index 4a889ea..17029a8 100755
> --- a/tests/TestSuite_cvl_advanced_rss_gtpogre.py
> +++ b/tests/TestSuite_cvl_advanced_rss_gtpogre.py
> @@ -3503,7 +3503,62 @@ class TestCVLAdvancedRSSGTPoGRE(TestCase):
>          self.switch_testpmd(enable_rss=True)
>          self.rssprocess.handle_rss_distribute_cases(cases_info=inner_l4_protocal_hash)
>
> +    def change_dpdk_code(self):
> +        """
> +            change dpdk's code to show the PFCP ptype
> +        """
> +        file1 = "drivers/net/ice/ice_rxtx.c"
> +        file2 = "drivers/net/ice/ice_rxtx_vec_avx2.c"
> +        match1 = "rte_le_to_cpu_16(rxdp\[j\].wb.ptype_flex_flags0)\];"
> +        match2 = "const uint16_t ptype0 = _mm256_extract_epi16(ptypes0_1, 1);"
> +        insert1 = "printf(\"ptype: %d\\\\n\", ICE_RX_FLEX_DESC_PTYPE_M & rte_le_to_cpu_16(rxdp\[j\].wb.ptype_flex_flags0));"
> +        insert2 = "printf(\"ptype: %d\\\\n\", ptype0);"
> +
> +        self.dut.send_expect("rm -rf drivers/net/ice/ice_rxtx.c_bak", "# ")
> +        self.dut.send_expect("cp -rf drivers/net/ice/ice_rxtx.c drivers/net/ice/ice_rxtx.c_bak", "# ")
> +        self.dut.send_expect("rm -rf drivers/net/ice/ice_rxtx_vec_avx2.c_bak", "# ")
> +        self.dut.send_expect("cp -rf drivers/net/ice/ice_rxtx_vec_avx2.c drivers/net/ice/ice_rxtx_vec_avx2.c_bak", "# ")
> +        self.dut.send_expect("sed -i '/%s/a\%s' %s"%(match1,insert1,file1), "# ")
> +        self.dut.send_expect("sed -i '/%s/a\%s' %s"%(match2,insert2,file2), "# ")

And changing driver code.

NAK.


-- 
David Marchand


  reply	other threads:[~2021-06-07  9:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-07  3:23 [dts] [PATCH V4 0/2] tests/rss_gtpogre: add a new case to PF and VF gtpogre Xiang An
2021-06-07  3:23 ` [dts] [PATCH V4 1/2] tests/cvl_advanced_rss_gtpogre: add case parse_pfcp_over_gre_packet Xiang An
2021-06-07  9:00   ` David Marchand [this message]
2021-06-07 19:44     ` Honnappa Nagarahalli
2021-06-07  3:23 ` [dts] [PATCH V4 2/2] tests/cvl_advanced_iavf_rss_gtpogre: " Xiang An

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8w-DCOtQemy92DR7drGS5ioyz3emGNQMzzQAj9B-vUZLg@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=dts@dpdk.org \
    --cc=juraj.linkes@pantheon.tech \
    --cc=techboard@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=xiangx.an@intel.com \
    --cc=yuan.peng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).