test suite reviews and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Lingli Chen <linglix.chen@intel.com>,
	"Tu, Lijuan" <lijuan.tu@intel.com>,
	 Bruce Richardson <bruce.richardson@intel.com>,
	Ciara Power <ciara.power@intel.com>
Cc: dts@dpdk.org, zhiminx.huang@intel.com
Subject: Re: [dts][PATCH V1] tests/telemetry: update file_prefix according to dpdk changes
Date: Tue, 7 Mar 2023 09:37:15 +0100	[thread overview]
Message-ID: <CAJFAV8wrwX-ciL+z10T7V0Q35N8rGn8B7rOMkGk87fqJK_RreQ@mail.gmail.com> (raw)
In-Reply-To: <20230210065125.9955-1-linglix.chen@intel.com>

On Fri, Feb 10, 2023 at 8:55 AM Lingli Chen <linglix.chen@intel.com> wrote:
>
> according to dpdk commit a15fc792cf (usertools/telemetry: add file prefix argument)
> update file_prefix in telemetry client
>
> Signed-off-by: Lingli Chen <linglix.chen@intel.com>
> ---
>  tests/TestSuite_telemetry.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_telemetry.py b/tests/TestSuite_telemetry.py
> index 736ae7ed..ca2d74f5 100644
> --- a/tests/TestSuite_telemetry.py
> +++ b/tests/TestSuite_telemetry.py
> @@ -420,11 +420,11 @@ class TestTelemetry(TestCase):
>      def change_run_fileprefix(self, out):
>          self.get_file_prefix(out)
>          if self.file_prefix:
> -            cmd1 = 'sed -i \'s/self.socket.send_fd.connect("\/var\/run\/dpdk\/.*\/telemetry")/self.socket.send_fd.connect("\/var\/run\/dpdk\/{0}\/telemetry")/g\' {1}'.format(
> +            cmd1 = "sed -i 's/self.socket.send_fd.connect(self.run_path)/self.socket.send_fd.connect(\"\/var\/run\/dpdk\/{0}\/telemetry\")/g' {1}".format(
>                  self.file_prefix,
>                  os.path.join(self.target_dir, "usertools/dpdk-telemetry-client.py"),
>              )
> -            cmd2 = 'sed -i \'s/self.socket.send_fd.connect("\/var\/run\/dpdk\/.*\/telemetry")/self.socket.send_fd.connect("\/var\/run\/dpdk\/{0}\/telemetry")/g\' {1}'.format(
> +            cmd2 = "sed -i 's/self.socket.send_fd.connect(self.run_path)/self.socket.send_fd.connect(\"\/var\/run\/dpdk\/{0}\/telemetry\")/g' {1}".format(
>                  self.file_prefix,
>                  os.path.join(self.target_dir, "dpdk_telemetry_client.py"),
>              )

Please don't change DPDK sources.
If something is missing in DPDK, please talk to the maintainers.


-- 
David Marchand


      parent reply	other threads:[~2023-03-07  8:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-10  6:51 Lingli Chen
2023-03-07  3:36 ` lijuan.tu
2023-03-07  8:37 ` David Marchand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8wrwX-ciL+z10T7V0Q35N8rGn8B7rOMkGk87fqJK_RreQ@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=ciara.power@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \
    --cc=linglix.chen@intel.com \
    --cc=zhiminx.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).