test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts][PATCH V1] tests/telemetry: update file_prefix according to dpdk changes
@ 2023-02-10  6:51 Lingli Chen
  2023-03-07  3:36 ` lijuan.tu
  2023-03-07  8:37 ` David Marchand
  0 siblings, 2 replies; 3+ messages in thread
From: Lingli Chen @ 2023-02-10  6:51 UTC (permalink / raw)
  To: dts; +Cc: zhiminx.huang, Lingli Chen

according to dpdk commit a15fc792cf (usertools/telemetry: add file prefix argument)
update file_prefix in telemetry client

Signed-off-by: Lingli Chen <linglix.chen@intel.com>
---
 tests/TestSuite_telemetry.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_telemetry.py b/tests/TestSuite_telemetry.py
index 736ae7ed..ca2d74f5 100644
--- a/tests/TestSuite_telemetry.py
+++ b/tests/TestSuite_telemetry.py
@@ -420,11 +420,11 @@ class TestTelemetry(TestCase):
     def change_run_fileprefix(self, out):
         self.get_file_prefix(out)
         if self.file_prefix:
-            cmd1 = 'sed -i \'s/self.socket.send_fd.connect("\/var\/run\/dpdk\/.*\/telemetry")/self.socket.send_fd.connect("\/var\/run\/dpdk\/{0}\/telemetry")/g\' {1}'.format(
+            cmd1 = "sed -i 's/self.socket.send_fd.connect(self.run_path)/self.socket.send_fd.connect(\"\/var\/run\/dpdk\/{0}\/telemetry\")/g' {1}".format(
                 self.file_prefix,
                 os.path.join(self.target_dir, "usertools/dpdk-telemetry-client.py"),
             )
-            cmd2 = 'sed -i \'s/self.socket.send_fd.connect("\/var\/run\/dpdk\/.*\/telemetry")/self.socket.send_fd.connect("\/var\/run\/dpdk\/{0}\/telemetry")/g\' {1}'.format(
+            cmd2 = "sed -i 's/self.socket.send_fd.connect(self.run_path)/self.socket.send_fd.connect(\"\/var\/run\/dpdk\/{0}\/telemetry\")/g' {1}".format(
                 self.file_prefix,
                 os.path.join(self.target_dir, "dpdk_telemetry_client.py"),
             )
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts][PATCH V1] tests/telemetry: update file_prefix according to dpdk changes
  2023-02-10  6:51 [dts][PATCH V1] tests/telemetry: update file_prefix according to dpdk changes Lingli Chen
@ 2023-03-07  3:36 ` lijuan.tu
  2023-03-07  8:37 ` David Marchand
  1 sibling, 0 replies; 3+ messages in thread
From: lijuan.tu @ 2023-03-07  3:36 UTC (permalink / raw)
  To: dts, Lingli Chen; +Cc: zhiminx.huang, Lingli Chen

On Fri, 10 Feb 2023 01:51:25 -0500, Lingli Chen <linglix.chen@intel.com> wrote:
> according to dpdk commit a15fc792cf (usertools/telemetry: add file prefix argument)
> update file_prefix in telemetry client
> 
> Signed-off-by: Lingli Chen <linglix.chen@intel.com>


Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts][PATCH V1] tests/telemetry: update file_prefix according to dpdk changes
  2023-02-10  6:51 [dts][PATCH V1] tests/telemetry: update file_prefix according to dpdk changes Lingli Chen
  2023-03-07  3:36 ` lijuan.tu
@ 2023-03-07  8:37 ` David Marchand
  1 sibling, 0 replies; 3+ messages in thread
From: David Marchand @ 2023-03-07  8:37 UTC (permalink / raw)
  To: Lingli Chen, Tu, Lijuan, Bruce Richardson, Ciara Power; +Cc: dts, zhiminx.huang

On Fri, Feb 10, 2023 at 8:55 AM Lingli Chen <linglix.chen@intel.com> wrote:
>
> according to dpdk commit a15fc792cf (usertools/telemetry: add file prefix argument)
> update file_prefix in telemetry client
>
> Signed-off-by: Lingli Chen <linglix.chen@intel.com>
> ---
>  tests/TestSuite_telemetry.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_telemetry.py b/tests/TestSuite_telemetry.py
> index 736ae7ed..ca2d74f5 100644
> --- a/tests/TestSuite_telemetry.py
> +++ b/tests/TestSuite_telemetry.py
> @@ -420,11 +420,11 @@ class TestTelemetry(TestCase):
>      def change_run_fileprefix(self, out):
>          self.get_file_prefix(out)
>          if self.file_prefix:
> -            cmd1 = 'sed -i \'s/self.socket.send_fd.connect("\/var\/run\/dpdk\/.*\/telemetry")/self.socket.send_fd.connect("\/var\/run\/dpdk\/{0}\/telemetry")/g\' {1}'.format(
> +            cmd1 = "sed -i 's/self.socket.send_fd.connect(self.run_path)/self.socket.send_fd.connect(\"\/var\/run\/dpdk\/{0}\/telemetry\")/g' {1}".format(
>                  self.file_prefix,
>                  os.path.join(self.target_dir, "usertools/dpdk-telemetry-client.py"),
>              )
> -            cmd2 = 'sed -i \'s/self.socket.send_fd.connect("\/var\/run\/dpdk\/.*\/telemetry")/self.socket.send_fd.connect("\/var\/run\/dpdk\/{0}\/telemetry")/g\' {1}'.format(
> +            cmd2 = "sed -i 's/self.socket.send_fd.connect(self.run_path)/self.socket.send_fd.connect(\"\/var\/run\/dpdk\/{0}\/telemetry\")/g' {1}".format(
>                  self.file_prefix,
>                  os.path.join(self.target_dir, "dpdk_telemetry_client.py"),
>              )

Please don't change DPDK sources.
If something is missing in DPDK, please talk to the maintainers.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-03-07  8:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-10  6:51 [dts][PATCH V1] tests/telemetry: update file_prefix according to dpdk changes Lingli Chen
2023-03-07  3:36 ` lijuan.tu
2023-03-07  8:37 ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).