Re: [PATCH v2] compress: resolve test failure from incomplete output capture

[David Marchand <david.marchand@redhat.com>]

Hello,

On Wed, Jul 16, 2025 at 10:36 PM Patrick Robb <probb@iol.unh.edu> wrote:
>
> On Wed, Jul 16, 2025 at 3:24 PM Manit Mahajan <mmahajan@iol.unh.edu> wrote:
>>
>> The compress unit test uses send_expect() with '>' to determine
>> when the command completed. A recent patch introduced a
>> deprecation warning for coremask, which includes a '>' in the
>> output. This causes send_expect() to exit early,
>> resulting in missed test output, leading to false failures.
>>
>> This is fixed by changing the expected termination prompt from
>> '>' to 'RTE>'. This change address issues from the v1 patch,
>> which incorrectly modified the EAL option from coremask to
>> corelist.
>>
>> Signed-off-by: Manit Mahajan <mmahajan@iol.unh.edu>
>
> Thanks. So, if we change the expect string to "RTE>", the warning will not trigger the expect and unit tests will complete before the execution proceeds? Sounds good.

On the principle, that sounds good to me too.

Just a note that other parts of "old" dts may be affected:
$ git grep 'send_expect.*">"'
tests/TestSuite_ieee1588.py:        self.dut.send_expect("start", ">", 10)
tests/TestSuite_multiprocess.py:
self.session_secondary.send_expect("send hello_primary", ">")
tests/TestSuite_multiprocess.py:
self.session_secondary.send_expect("send hello_secondary", ">")
tests/TestSuite_multiprocess.py:            self.dut.send_expect("send
%s" % line, ">")
tests/TestSuite_multiprocess.py:
self.session_secondary.send_expect("send hello_primary", ">")
tests/TestSuite_multiprocess.py:
self.session_secondary.send_expect("send hello_secondary", ">", 100)
tests/TestSuite_multiprocess_iavf.py:
self.session_secondary.send_expect("send hello_primary", ">")
tests/TestSuite_multiprocess_iavf.py:
self.session_secondary.send_expect("send hello_secondary", ">")
tests/TestSuite_multiprocess_iavf.py:
self.dut.send_expect("send %s" % line, ">")
tests/TestSuite_multiprocess_iavf.py:
self.session_secondary.send_expect("send hello_primary", ">")
tests/TestSuite_multiprocess_iavf.py:
self.session_secondary.send_expect("send hello_secondary", ">", 100)
tests/TestSuite_shutdown_api.py:            self.dut.send_expect("set
link-up port %d" % i, ">")
tests/TestSuite_speed_capabilities.py:
self.dut.send_expect("set link-up port %d" % i, ">")
tests/compress_common.py:    test_case.dut.send_expect(cmdline, ">", 30)
tests/compress_common.py:    out =
test_case.dut.send_expect("compressdev_autotest", ">", 30)


How do we proceed now?
Do you want me to push this fix in the dts legacy repo?


-- 
David Marchand