From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1EAD146B9B; Thu, 17 Jul 2025 10:40:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E6554402C2; Thu, 17 Jul 2025 10:40:33 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 72B06400EF for ; Thu, 17 Jul 2025 10:40:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752741631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IvT2jEzZD/8sEfJ64s1OstbqPD3JwyuB9LfNw6nV/bA=; b=FiWmlFndsZqrAfLXJVPSkihgw70PDZ4kCcgG9EIIB+citIRwX7mAkm1K+Q0Av9n5dsPZlp FoPKB24EZgHpp0nVRwdkI0FpOOgPnmySLAnPuFv5EyQ0FOWiRUw8eEv2uTrtgbcVS2Qd3/ BXdnUYZ4HL9O01zctLLBIkfLoLMhEXM= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-3-m3vpdYcaOiuiz8SBX67Uuw-1; Thu, 17 Jul 2025 04:40:30 -0400 X-MC-Unique: m3vpdYcaOiuiz8SBX67Uuw-1 X-Mimecast-MFC-AGG-ID: m3vpdYcaOiuiz8SBX67Uuw_1752741629 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-32cf580cacdso2653031fa.2 for ; Thu, 17 Jul 2025 01:40:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752741628; x=1753346428; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IvT2jEzZD/8sEfJ64s1OstbqPD3JwyuB9LfNw6nV/bA=; b=GKrVzXzbSW2tEKnBmAfFOubiZ72AI3iHZXj6OWZFKq7tw9oPLRsgA0gfNa9Qqto32W vqgx51KK67kLRCps6XMbkGAyGQ9HvfSxgvazNS5bOJV1CT8Q20s7/uODMQrXlycw25Al QyKCSgM93IyMLPwyOkLc8Dp72GdY9QU6OCFh+ZaDl+AnSmlP6hrF8uojc1GaneDc/7I2 +OlSRs0c9SfFHtPkbpUHzQV5Eg1tx9zso2ohnI0un30MVtBg14vjE0VeL8fT/UGJNQxN Kjgl7T63n2X9GcKkifovB8LV5gqQQfrYRMLRBVkOkWPGJJMUwpSdBowNxnKbR2w8qTh9 QPAQ== X-Gm-Message-State: AOJu0YxlrSKxv6PX3VOCH3NGhL6WNmkwOVDhrfphxk2Dz3Mo2wwUNlma j0hDhB4aDpayV+tQiqd5Dhyti46m+z8ERbBSEUFRdSxREYbQCtTOe0l2TLX8cKj+ujqPOI+qCLW pwU9gSwlOP8DD/Z9/pAVDkWCVi2e32ffWVlD9/nIfyL6e7xlOioBAR8CKZjzsnDXdQxREqHhBBD PcyQX6vLj7R3E/8smeJfS/gxXYaqHPsg== X-Gm-Gg: ASbGncveMinsODN81rp18ayIzjaFUDO936kuRlHVumDpPeEqQJHaV5BYoOAKBZXJQn8 NfUEa8E3x0/OB4cwXV2oMLLq80gbwdI4HEGwWJk/W1rS96J/RwydTx4X6uPVSjvAVMeUG23EQav hIOALWTqqYbSsqMlMXj+dZL+k= X-Received: by 2002:a05:651c:e0f:b0:32a:ec98:e14d with SMTP id 38308e7fff4ca-3308f525fcbmr9537701fa.16.1752741628523; Thu, 17 Jul 2025 01:40:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEbfGoTkRgJRtKIL/qwQviFPopfQ0K9pYP9RSFJ0w6BFAmCn8duRaU4EgTvzKZsTg8qAZ2/z7jxb0WIISUDzMA= X-Received: by 2002:a05:651c:e0f:b0:32a:ec98:e14d with SMTP id 38308e7fff4ca-3308f525fcbmr9537661fa.16.1752741628009; Thu, 17 Jul 2025 01:40:28 -0700 (PDT) MIME-Version: 1.0 References: <20250711203030.10147-1-mmahajan@iol.unh.edu> <20250716192456.30120-1-mmahajan@iol.unh.edu> In-Reply-To: From: David Marchand Date: Thu, 17 Jul 2025 10:40:16 +0200 X-Gm-Features: Ac12FXwJdbh57RIR6hEdrcJP36gntlqZAQhbfNLael9GmIbpoawUbbKyJBCycsc Message-ID: Subject: Re: [PATCH v2] compress: resolve test failure from incomplete output capture To: Patrick Robb , Manit Mahajan Cc: dts@dpdk.org, Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 4_BjXTQ2unV90AE2vclZ7-QMKkg6JRRIK8v6BPupb4U_1752741629 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Hello, On Wed, Jul 16, 2025 at 10:36=E2=80=AFPM Patrick Robb w= rote: > > On Wed, Jul 16, 2025 at 3:24=E2=80=AFPM Manit Mahajan wrote: >> >> The compress unit test uses send_expect() with '>' to determine >> when the command completed. A recent patch introduced a >> deprecation warning for coremask, which includes a '>' in the >> output. This causes send_expect() to exit early, >> resulting in missed test output, leading to false failures. >> >> This is fixed by changing the expected termination prompt from >> '>' to 'RTE>'. This change address issues from the v1 patch, >> which incorrectly modified the EAL option from coremask to >> corelist. >> >> Signed-off-by: Manit Mahajan > > Thanks. So, if we change the expect string to "RTE>", the warning will no= t trigger the expect and unit tests will complete before the execution proc= eeds? Sounds good. On the principle, that sounds good to me too. Just a note that other parts of "old" dts may be affected: $ git grep 'send_expect.*">"' tests/TestSuite_ieee1588.py: self.dut.send_expect("start", ">", 10) tests/TestSuite_multiprocess.py: self.session_secondary.send_expect("send hello_primary", ">") tests/TestSuite_multiprocess.py: self.session_secondary.send_expect("send hello_secondary", ">") tests/TestSuite_multiprocess.py: self.dut.send_expect("send %s" % line, ">") tests/TestSuite_multiprocess.py: self.session_secondary.send_expect("send hello_primary", ">") tests/TestSuite_multiprocess.py: self.session_secondary.send_expect("send hello_secondary", ">", 100) tests/TestSuite_multiprocess_iavf.py: self.session_secondary.send_expect("send hello_primary", ">") tests/TestSuite_multiprocess_iavf.py: self.session_secondary.send_expect("send hello_secondary", ">") tests/TestSuite_multiprocess_iavf.py: self.dut.send_expect("send %s" % line, ">") tests/TestSuite_multiprocess_iavf.py: self.session_secondary.send_expect("send hello_primary", ">") tests/TestSuite_multiprocess_iavf.py: self.session_secondary.send_expect("send hello_secondary", ">", 100) tests/TestSuite_shutdown_api.py: self.dut.send_expect("set link-up port %d" % i, ">") tests/TestSuite_speed_capabilities.py: self.dut.send_expect("set link-up port %d" % i, ">") tests/compress_common.py: test_case.dut.send_expect(cmdline, ">", 30) tests/compress_common.py: out =3D test_case.dut.send_expect("compressdev_autotest", ">", 30) How do we proceed now? Do you want me to push this fix in the dts legacy repo? --=20 David Marchand