From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A685BA04FF; Tue, 22 Mar 2022 10:04:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A119D427F1; Tue, 22 Mar 2022 10:04:15 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 50D7E410E5 for ; Tue, 22 Mar 2022 10:04:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647939853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3G9CeDltNdj5BcL3+RUMbRL9O/SRCfVT/vPe+yN+DwU=; b=CEe9n7pzXx+hD11O6uotgZWx/bllSGVhVDmtLRj6S8vISDPu0kGAgy2uA68E8QnhP3neVg o/oQhaPC52rZTMp/O5SRbqDAeZq1+ph08qc5kGzfIQsDcbVCEwfVQsT/nWXhOYm+EyCs4W 8jV9VCl/CxgOVb3qf575KG9WkBbdY1Q= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-7-C7A59JYIPnurx3PEtqbnrw-1; Tue, 22 Mar 2022 05:04:12 -0400 X-MC-Unique: C7A59JYIPnurx3PEtqbnrw-1 Received: by mail-lj1-f198.google.com with SMTP id v2-20020a2e9f42000000b00247e9c3f0e1so7197419ljk.1 for ; Tue, 22 Mar 2022 02:04:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3G9CeDltNdj5BcL3+RUMbRL9O/SRCfVT/vPe+yN+DwU=; b=wgUEuh+vjXu6NAwcMLqGw8Tl3Qfys1e1As/IGdAreuow0GZtRmer+CoWc2ZsJs+6Vx ZXCya+9hSD6lflBBkTwGFWxabFwvtBO6GBZbsyWqQ/dURdLu+YRbc1LJcjPzYgpa1F+v SRcgDbTibJUk0QvXZmY1oBviVtDqqh9yStTKzad2HjBNFk/aJm+vplmqNWTNDbD2+8Gg vjT15jvzIYNoNhDheVOzZY4Jh3hFy0aFfOZXFgWo+usqpPmcURYw0uFm94/Q4WceyodH lUdZZY9qhJepeRzUgYP3Mm8QQQC6KiOXTza3CJ2gr7bjLMVCxlQKP8SVyVmMzwqIWxpl Ao8w== X-Gm-Message-State: AOAM532oPqlS7zh/8nio6eGzzCH93qMSAebiZP/E4gP+mTU4fyYFF0s1 hly3QRdasxFcGA8twHID8Ax5CEVdIxjIphAAs3zKt9gGCQQmaWJwU4v6s7Ie/WwJotNNMHq25QL rQysm42zVD33F5WtHEw8= X-Received: by 2002:a05:6512:1506:b0:448:2f28:91ec with SMTP id bq6-20020a056512150600b004482f2891ecmr17321741lfb.217.1647939850821; Tue, 22 Mar 2022 02:04:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVGmaw0fOKSzuHg8cX51Q40aYJ5xYPkxcDOZ4+Nc0tTEOwvC1DZzBcWpqJBBrP3p4zGCIKu3NfAUsc3zcsI8E= X-Received: by 2002:a05:6512:1506:b0:448:2f28:91ec with SMTP id bq6-20020a056512150600b004482f2891ecmr17321730lfb.217.1647939850587; Tue, 22 Mar 2022 02:04:10 -0700 (PDT) MIME-Version: 1.0 References: <20220321124553.1027252-1-tadhg.kearney@intel.com> In-Reply-To: <20220321124553.1027252-1-tadhg.kearney@intel.com> From: David Marchand Date: Tue, 22 Mar 2022 10:03:59 +0100 Message-ID: Subject: Re: [dts][V1] tests/*: Remove old DPDK RTE flags from power tests To: Tadhg Kearney Cc: dts@dpdk.org, "Pattan, Reshma" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org On Mon, Mar 21, 2022 at 1:46 PM Tadhg Kearney wrote: > > * CONFIG_RTE_LIBRTE_I40E_PMD option does not exist anymore > * Telemtry is build by default + _LIBRTE_ option also does not exist anymore What about: """ def compile_switch(self): sw_table = [ "CONFIG_RTE_LIBRTE_POWER", "CONFIG_RTE_LIBRTE_POWER_DEBUG", ] return sw_table """ ? This too can be removed. > > Signed-off-by: Tadhg Kearney > --- > tests/TestSuite_power_branch_ratio.py | 2 +- > tests/TestSuite_power_telemetry.py | 17 +---------------- > 2 files changed, 2 insertions(+), 17 deletions(-) > > diff --git a/tests/TestSuite_power_branch_ratio.py b/tests/TestSuite_power_branch_ratio.py > index dee2cc11..a7f2a047 100644 > --- a/tests/TestSuite_power_branch_ratio.py > +++ b/tests/TestSuite_power_branch_ratio.py > @@ -225,7 +225,7 @@ class TestPowerBranchRatio(TestCase): > > def preset_compilation(self): > if 'meson' == load_global_setting(HOST_BUILD_TYPE_SETTING): > - compile_SWs = self.compile_switch + ["CONFIG_RTE_LIBRTE_I40E_PMD"] > + compile_SWs = self.compile_switch > self.dut.set_build_options(dict([(sw[7:], 'y') for sw in compile_SWs])) > else: > for sw in self.compile_switch: > diff --git a/tests/TestSuite_power_telemetry.py b/tests/TestSuite_power_telemetry.py > index d8182ce2..6a9740b2 100644 > --- a/tests/TestSuite_power_telemetry.py > +++ b/tests/TestSuite_power_telemetry.py > @@ -45,7 +45,7 @@ from pprint import pformat > from framework.exception import VerifyFailure > from framework.packet import Packet > from framework.pktgen import TRANSMIT_CONT > -from framework.settings import HEADER_SIZE, HOST_BUILD_TYPE_SETTING, load_global_setting > +from framework.settings import HEADER_SIZE, load_global_setting > from framework.test_case import TestCase > from framework.utils import create_mask as dts_create_mask > > @@ -121,19 +121,6 @@ class TestPowerTelemetry(TestCase): > > return result > > - def preset_compilation(self): > - if self.dut.skip_setup: > - return > - SW = "CONFIG_RTE_LIBRTE_TELEMETRY" > - if 'meson' == load_global_setting(HOST_BUILD_TYPE_SETTING): > - self.dut.set_build_options({SW[7:]: 'y'}) > - else: > - cmd = "sed -i -e 's/{0}=n$/{0}=y/' {1}/config/common_base".format( > - SW, self.target_dir) > - self.d_a_con(cmd) > - # re-compile dpdk source code > - self.dut.build_install_dpdk(self.target) > - > def prepare_binary(self, name): > example_dir = "examples/" + name > out = self.dut.build_dpdk_apps('./' + example_dir) > @@ -425,8 +412,6 @@ class TestPowerTelemetry(TestCase): > > def preset_test_environment(self): > self.is_l3fwd_on = None > - # open compile switch and re-compile target source code > - self.preset_compilation() > # init binary > self.init_l3fwd_power() > self.init_telemetry() > -- > 2.25.1 > > -------------------------------------------------------------- > Intel Research and Development Ireland Limited > Registered in Ireland > Registered Office: Collinstown Industrial Park, Leixlip, County Kildare > Registered Number: 308263 > > > This e-mail and any attachments may contain confidential material for the sole > use of the intended recipient(s). Any review or distribution by others is > strictly prohibited. If you are not the intended recipient, please contact the > sender and delete all copies. This footer does not make sense on a public mailing list. -- David Marchand