From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B745AA0503; Wed, 18 May 2022 15:39:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AFF7F40156; Wed, 18 May 2022 15:39:59 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 29F8C40221 for ; Wed, 18 May 2022 15:39:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652881197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K0ahMxjWR0HpTMuXJsEOZEE9DO2Q6ixczqoi3U+7uEQ=; b=Zw+mNndWtZ3G7/H1S5vIZnpwuWj8M9rCG+LeC9O45ZBIzZO2HivjXgMBIkvQOS1CESGsXN JOYI8rFbYMVBkTu/CqekfCy3+AAIS2u96dUIC2+xL30vKOkVhJXyVpqFwbWgee7XFObzw7 tgsa7h80JQiBgQ/eDTeB0LfjQjcnQ+Q= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-462-EgnzkUdgMQW3nDS0XW9I2Q-1; Wed, 18 May 2022 09:39:56 -0400 X-MC-Unique: EgnzkUdgMQW3nDS0XW9I2Q-1 Received: by mail-lj1-f200.google.com with SMTP id f6-20020a2e9186000000b0024f3dfdf894so467555ljg.2 for ; Wed, 18 May 2022 06:39:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K0ahMxjWR0HpTMuXJsEOZEE9DO2Q6ixczqoi3U+7uEQ=; b=TsJvazUuTdmQA0S4vgsISUtEKChS8VbIzt32+9Id2ZDP3fb+g/OReUNw12KUpMAb+J m8kp5KcqL7Pmjpq6HccV+OC/FAaiFo3wd6yAZxZt0eKfDaEnkZBAl7ICY8qdWAdeVbfG fST2PBRrkEt7RjkaWpcw7W12v7cSSt/jQklJ/n3BWEpE1OVnqeDb5mIz2EvY5bfJufaS m02385joZi+FPw6qHgPB8PAIMkb7gfpxNQ1N6WeCpvjS+NWmejcxDZVRX9qlA1VUmVuw mcnf4lOKMh4QO+anl+uW8IUj8/CSm+VnGQvywS0Mi/z0zFGti0WMuTPQpTISYxeyDr6s DMiA== X-Gm-Message-State: AOAM533Iv7cNp7PcKbbHh4Bbho812WhBF/8yrAff1VyuTIt3wNlUfHLz mpmNFA35Hqqqvkh0+Yy0b+OOQeT9qvhVJ3wwgVed2hsmcfQytp5gwqkyYsXHWeA5NbPvoflbVL8 UJJJfB4YRH7fSq25awoA= X-Received: by 2002:a05:6512:baa:b0:472:5ec9:f625 with SMTP id b42-20020a0565120baa00b004725ec9f625mr20111529lfv.560.1652881194981; Wed, 18 May 2022 06:39:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwy205jCfsur40yNbbTA3sA+lSQH9Ls8EJjDySWjR88acgOx5tX/RHa/cH1iuumMWjIurlde13hISUQCYCHmaY= X-Received: by 2002:a05:6512:baa:b0:472:5ec9:f625 with SMTP id b42-20020a0565120baa00b004725ec9f625mr20111515lfv.560.1652881194764; Wed, 18 May 2022 06:39:54 -0700 (PDT) MIME-Version: 1.0 References: <20220510030125.334616-1-weix.ling@intel.com> In-Reply-To: From: David Marchand Date: Wed, 18 May 2022 15:39:43 +0200 Message-ID: Subject: Re: [dts][PATCH V4 3/3] tests/dpdk_gro_lib_cbdma: add dpdk_gro_lib_cbdma testsuite To: "Ling, WeiX" Cc: "dts@dpdk.org" , "Tu, Lijuan" , Honnappa Nagarahalli , Thomas Monjalon , "Mcnamara, John" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org On Wed, May 18, 2022 at 11:36 AM Ling, WeiX wrote: > > > > > > Add new testsuite tests/TestSuite_dpdk_gro_lib_cbdma.py. > > > > > > Signed-off-by: Wei Ling > > > > I commented on v1. > > v4 is the same. > > > > NAK. > > Because we also need to modify DPDK code to test this suite before the > DPDK patch merged into the DPDK. The existing code must be cleaned and Intel should stop adding more technical debt stuff to dts. I can see the patch already got merged, so it seems my point was not understood by the dts maintainer. This patch should be reverted. -- David Marchand