test suite reviews and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Yan Xia <yanx.xia@intel.com>
Cc: dts@dpdk.org, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Subject: Re: [dts] [PATCH V1] tests/vf_daemon: modify dts to adapt dpdk changes
Date: Wed, 20 Oct 2021 17:30:51 +0200	[thread overview]
Message-ID: <CAJFAV8z-BLjo-z-RPbP5e-PK9nWe98LvQwk4AzXAANqkoxroww@mail.gmail.com> (raw)
In-Reply-To: <20211019102845.213815-1-yanx.xia@intel.com>

On Tue, Oct 19, 2021 at 4:29 AM Yan Xia <yanx.xia@intel.com> wrote:
>
> dpdk commit-id: 04d43857
> dpdk rename `s_addr` to `src_addr`
>
> Signed-off-by: Yan Xia <yanx.xia@intel.com>
> ---
>  tests/TestSuite_vf_daemon.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_vf_daemon.py b/tests/TestSuite_vf_daemon.py
> index a08ae7b5..2c23e760 100644
> --- a/tests/TestSuite_vf_daemon.py
> +++ b/tests/TestSuite_vf_daemon.py
> @@ -528,7 +528,7 @@ class TestVfDaemon(TestCase):
>              "\        struct rte_ether_addr fake_mac = {.addr_bytes = {0x00, 0x11, 0x22, 0x33, 0x44, 0x55},};'" +\
>              " app/test-pmd/macswap_sse.h", "# ", 30)
>          line_num = self.vm0_dut.send_expect("sed -n '/_mm_storeu_si128/=' app/test-pmd/macswap_sse.h |sed -n 5p", "# ",30)
> -        self.vm0_dut.send_expect("sed -i -e '%sa\\rte_ether_addr_copy(&fake_mac, &eth_hdr[0]->s_addr);'" % str(line_num)+\
> +        self.vm0_dut.send_expect("sed -i -e '%sa\\rte_ether_addr_copy(&fake_mac, &eth_hdr[0]->src_addr);'" % str(line_num)+\

Please drop those hacks where DTS changes DPDK source code.


>                      " app/test-pmd/macswap_sse.h", "# ", 30)
>          time.sleep(3)
>
> --
> 2.32.0
>


-- 
David Marchand


  parent reply	other threads:[~2021-10-20 15:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-19 10:28 Yan Xia
2021-10-19  2:35 ` Chen, LingliX
2021-10-20 15:30 ` David Marchand [this message]
2021-10-20 16:41   ` Honnappa Nagarahalli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8z-BLjo-z-RPbP5e-PK9nWe98LvQwk4AzXAANqkoxroww@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=dts@dpdk.org \
    --cc=yanx.xia@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).