Re: [dts] [PATCH V1 1/3] tests/generic_flow_api: add and modify test cases

[David Marchand <david.marchand@redhat.com>]

On Mon, Sep 6, 2021 at 11:04 AM Yan Xia <yanx.xia@intel.com> wrote:
>
> modify test cases about legcay command and move these to TestSuite_generic_flow_api
>
> Signed-off-by: Yan Xia <yanx.xia@intel.com>
> ---

[...]

> +    def test_128_queues(self):
> +
> +        set_filter_flag = 1
> +        packet_flag = 1
> +        if self.kdriver == "ixgbe":
> +            self.dut.send_expect("sed -i -e 's/#define IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES 128/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)

- Don't add code in DTS that modifies DPDK.


- This code change is present in another test (see 'git grep' below).
But I see no justification for this change in
https://docs.google.com/spreadsheets/d/1i7x4ecPiRXNKOrOy0the5WyGSWbdMxPLK7aWbuWI4ew/edit#gid=0&range=C19
I am for purging this change from DTS.


$ git grep IXGBE_NONE_MODE_TX_NB_QUEUES origin/main
origin/main:test_plans/generic_filter_test_plan.rst:    sed -i -e
's/#define IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define
IXGBE_NONE_MODE_TX_NB_QUEUES 128/' drivers/net/ixgbe/ixgbe_ethdev.h
origin/main:tests/TestSuite_generic_filter.py:
self.dut.send_expect("sed -i -e 's/#define
IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES
128/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)
origin/main:tests/TestSuite_generic_filter.py:
self.dut.send_expect("sed -i -e 's/#define
IXGBE_NONE_MODE_TX_NB_QUEUES 128$/#define IXGBE_NONE_MODE_TX_NB_QUEUES
64/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)


Thanks.


> +            self.dut.build_install_dpdk(self.target)
> +            global valports


-- 
David Marchand