From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34305A0C4D; Mon, 6 Sep 2021 12:02:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B60C40E32; Mon, 6 Sep 2021 12:02:30 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 2D56140C35 for ; Mon, 6 Sep 2021 12:02:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630922548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OOwoAsmt353LnDIjUPHeoFi9KKPDoRWoiETkeCyv8HQ=; b=TkcIARSzVq3q7NjBglqHRbcrcg8DtHQRqcdPff4wERtXnwyy+axF0lYKtRASX3dKU5AjUr QS1DQiSEhgCB2bLJMdxcYDIW6g7wSprMBu8jIkKF+3VuodJAeHsw1sef92QpylV3FhTlKr Tmr69BDIkhnEdY9iS3SFlM7m96oUHL4= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-148-oCIz8kwUMauUhE2pYos97Q-1; Mon, 06 Sep 2021 06:02:26 -0400 X-MC-Unique: oCIz8kwUMauUhE2pYos97Q-1 Received: by mail-lj1-f197.google.com with SMTP id 192-20020a2e05c90000b02901b91e6a0ebaso3100993ljf.13 for ; Mon, 06 Sep 2021 03:02:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OOwoAsmt353LnDIjUPHeoFi9KKPDoRWoiETkeCyv8HQ=; b=k+09ZoI04veaZvB7hfWi3NOQgHQUl+ivt17L2T8sIuHz9X64viHM9E6+w4oBP+3IG1 B3ATUBjUnXzLzNs3SLbCspoqpcVec1TbB27ec0j4gj3Tw3XqrumwREksB2S7xpCbrr1x T+q7gwHX6UU1qfA/kDC6fRCPkk8x7pXNriyQc2RHLanWk1FPxMNxoQOumU62Sru7BWEN vsevlrfrxww1thawWHmcelpMMfsP6RNfRRkLznsSk/jo8uMnz4S+LdOh0dpUmWFj7XQQ PPV/NQJY2pKtYmFZi64rVAa6SYiOzSTIUPGjsaBOjB81PSpmKNEiLKOfIQWUSEz4qXew 2KGw== X-Gm-Message-State: AOAM531Lbe2KxoUdZwMgpe+I8B9tA3XJlJO9tFJmOfX6nHurdvTroAVJ DQxQ8JGPFt341s7eod3ntsWmNbduDbP/pPP8HLToUJFtWORjTgCixtCkByG7DU826ns/g1dA1LM fq4hm2r2ZfUnfTZ6DuHk= X-Received: by 2002:ac2:4c4c:: with SMTP id o12mr8942741lfk.499.1630922544408; Mon, 06 Sep 2021 03:02:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwsUtoHoOAri4oPu19ECvWB2K9j1CGiI8QoPDtC4WiS6azrz4tjqlVOmnwUNzMkUuFBVKQ0euV/vI4Nb/5+U7c= X-Received: by 2002:ac2:4c4c:: with SMTP id o12mr8942713lfk.499.1630922543921; Mon, 06 Sep 2021 03:02:23 -0700 (PDT) MIME-Version: 1.0 References: <20210906173550.23959-1-yanx.xia@intel.com> In-Reply-To: <20210906173550.23959-1-yanx.xia@intel.com> From: David Marchand Date: Mon, 6 Sep 2021 12:02:12 +0200 Message-ID: To: Yan Xia Cc: dts@dpdk.org, "Tu, Lijuan" , Honnappa Nagarahalli , =?UTF-8?Q?Juraj_Linke=C5=A1?= , Aaron Conole , Thomas Monjalon , "Yigit, Ferruh" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dts] [PATCH V1 1/3] tests/generic_flow_api: add and modify test cases X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" On Mon, Sep 6, 2021 at 11:04 AM Yan Xia wrote: > > modify test cases about legcay command and move these to TestSuite_generic_flow_api > > Signed-off-by: Yan Xia > --- [...] > + def test_128_queues(self): > + > + set_filter_flag = 1 > + packet_flag = 1 > + if self.kdriver == "ixgbe": > + self.dut.send_expect("sed -i -e 's/#define IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES 128/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30) - Don't add code in DTS that modifies DPDK. - This code change is present in another test (see 'git grep' below). But I see no justification for this change in https://docs.google.com/spreadsheets/d/1i7x4ecPiRXNKOrOy0the5WyGSWbdMxPLK7aWbuWI4ew/edit#gid=0&range=C19 I am for purging this change from DTS. $ git grep IXGBE_NONE_MODE_TX_NB_QUEUES origin/main origin/main:test_plans/generic_filter_test_plan.rst: sed -i -e 's/#define IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES 128/' drivers/net/ixgbe/ixgbe_ethdev.h origin/main:tests/TestSuite_generic_filter.py: self.dut.send_expect("sed -i -e 's/#define IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES 128/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30) origin/main:tests/TestSuite_generic_filter.py: self.dut.send_expect("sed -i -e 's/#define IXGBE_NONE_MODE_TX_NB_QUEUES 128$/#define IXGBE_NONE_MODE_TX_NB_QUEUES 64/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30) Thanks. > + self.dut.build_install_dpdk(self.target) > + global valports -- David Marchand