From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77D91A0508; Mon, 9 May 2022 08:52:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 48E4640691; Mon, 9 May 2022 08:52:38 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4AD134068F for ; Mon, 9 May 2022 08:52:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652079156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+iS2Sqqtq91dhpqUXLLkrXSRZZlAaMB+LYvy3djj/CQ=; b=iIkZcEwKyyAjmDYg98nKQ7+3I3T9r8sZRBjlMVCK2F5ED88mmO16CA5dEVYVCTjX0IlaG1 108/7dVfK/EAjI1bz33VX9wRCWChr8Hs8wdigtWxXDPy0xyqx16QCutdpis8qna3WzBdGQ sK4Uru+MuTXq9wlBlvTGhIuFGoSUNEg= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-657-oSTdkBixOomqaPBancmZhw-1; Mon, 09 May 2022 02:52:35 -0400 X-MC-Unique: oSTdkBixOomqaPBancmZhw-1 Received: by mail-lf1-f69.google.com with SMTP id br16-20020a056512401000b004739cf51722so5451513lfb.6 for ; Sun, 08 May 2022 23:52:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+iS2Sqqtq91dhpqUXLLkrXSRZZlAaMB+LYvy3djj/CQ=; b=hl4CdNWb9hH//ixMk/KnecnCH3YMwkqY6E/nvl/LHfaelEnIBb9rVSWn1qJuj1JOWn /N690lNwT4ZENvL6IO+pV9Zp//I/3H76ZoLXfzRStYPhplb5u9Er82yM1NTRyIZMkB6F SwbO4vW3YiRUGtyMEAmfsTT8UjBYafAwMb1/MBrO/SmkLbf+p16cmoS4HGeau0UvSJlI AcOlyMk4k/J6Hlh4iLvvAKOZ9/ViMZ9yAQmrXenSXLycq/nUstiup1pOm6jFLGYogo1Y tANXS0BV+FjKFRrLeXYg9jIUkrHx+o7FJ3GD89lJKd0YTBaQr55TLjtzQpQL0wSvKPzp CndA== X-Gm-Message-State: AOAM531MnbpHJQGci+hdNu792CtfZlnRxHYaCRmFoWIbevBK1TOVAG2u rmgD9l2G8LaoYQHNc8ZFZlbKdP+nZSho+Xz0PvbiD7fkCnVP2SvjbIygzwRP5I/FFbFSOXuxYS0 6DB56nIIIeeiFupfzj10= X-Received: by 2002:a05:651c:2046:b0:250:cf36:eb77 with SMTP id t6-20020a05651c204600b00250cf36eb77mr804599ljo.159.1652079153926; Sun, 08 May 2022 23:52:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzkAApV6beAA+zv6CqXU7UU8+gELIIu+Zfnh3LpHhaLWEo+yiHOfnE3h2GBGnSeG9r06PnE0NVbIwK/jlwOdTA= X-Received: by 2002:a05:651c:2046:b0:250:cf36:eb77 with SMTP id t6-20020a05651c204600b00250cf36eb77mr804588ljo.159.1652079153714; Sun, 08 May 2022 23:52:33 -0700 (PDT) MIME-Version: 1.0 References: <20220507084337.307079-1-weix.ling@intel.com> In-Reply-To: <20220507084337.307079-1-weix.ling@intel.com> From: David Marchand Date: Mon, 9 May 2022 08:52:22 +0200 Message-ID: Subject: Re: [dts][PATCH V1 3/3] tests/dpdk_gro_lib_cbdma: add dpdk_gro_lib_cbdma testsuite To: Wei Ling Cc: dts@dpdk.org, "Tu, Lijuan" , Honnappa Nagarahalli Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org On Sat, May 7, 2022 at 10:44 AM Wei Ling wrote: > + def prepare_dpdk(self): > + # Changhe the testpmd checksum fwd code for mac change > + self.dut.send_expect("cp ./app/test-pmd/csumonly.c ./app/test-pmd/csumonly_backup.c", "#") > + self.dut.send_expect("cp ./drivers/net/vhost/rte_eth_vhost.c ./drivers/net/vhost/rte_eth_vhost-backup.c", "#") > + self.dut.send_expect("sed -i '/ether_addr_copy(&peer_eth/i\#if 0' ./app/test-pmd/csumonly.c", "#") > + self.dut.send_expect("sed -i '/parse_ethernet(eth_hdr, &info/i\#endif' ./app/test-pmd/csumonly.c", "#") > + # change offload of vhost > + tx_offload = 'RTE_ETH_TX_OFFLOAD_VLAN_INSERT | ' + \ > + 'RTE_ETH_TX_OFFLOAD_UDP_CKSUM | ' + \ > + 'RTE_ETH_TX_OFFLOAD_TCP_CKSUM | ' + \ > + 'RTE_ETH_TX_OFFLOAD_IPV4_CKSUM | ' + \ > + 'RTE_ETH_TX_OFFLOAD_TCP_TSO;' > + rx_offload = 'RTE_ETH_RX_OFFLOAD_VLAN_STRIP | ' + \ > + 'RTE_ETH_RX_OFFLOAD_TCP_CKSUM | ' + \ > + 'RTE_ETH_RX_OFFLOAD_UDP_CKSUM | ' + \ > + 'RTE_ETH_RX_OFFLOAD_IPV4_CKSUM | ' + \ > + 'RTE_ETH_RX_OFFLOAD_TCP_LRO;' > + self.dut.send_expect("sed -i 's/RTE_ETH_TX_OFFLOAD_VLAN_INSERT;/%s/' drivers/net/vhost/rte_eth_vhost.c" % tx_offload, "#") > + self.dut.send_expect("sed -i 's/RTE_ETH_RX_OFFLOAD_VLAN_STRIP;/%s/' drivers/net/vhost/rte_eth_vhost.c" % rx_offload, "#") > + self.dut.build_install_dpdk(self.dut.target) This hack is getting copy/pasted again and again. _Don't modify DPDK sources in DTS_. > + > + def unprepare_dpdk(self): > + # Recovery the DPDK code to original > + self.dut.send_expect("cp ./app/test-pmd/csumonly_backup.c ./app/test-pmd/csumonly.c ", "#") > + self.dut.send_expect("cp ./drivers/net/vhost/rte_eth_vhost-backup.c ./drivers/net/vhost/rte_eth_vhost.c ", "#") > + self.dut.send_expect("rm -rf ./app/test-pmd/csumonly_backup.c", "#") > + self.dut.send_expect("rm -rf ./drivers/net/vhost/rte_eth_vhost-backup.c", "#") > + self.dut.build_install_dpdk(self.dut.target) -- David Marchand