From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C824D46B4B; Fri, 11 Jul 2025 23:36:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 918D340156; Fri, 11 Jul 2025 23:36:21 +0200 (CEST) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 304CA4013F for ; Fri, 11 Jul 2025 23:36:20 +0200 (CEST) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-23649faf69fso20507475ad.0 for ; Fri, 11 Jul 2025 14:36:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1752269779; x=1752874579; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=x8vFIhJRlcwjRzx6WHDV1hczk0foRb+o+6v6+7f/7B0=; b=Qh7p5/G9GutyNbBkuHSG8u7wuKQqQSr0zKBDHJRMB0z2RdiDrLeclZF/jb7Cf0unUQ 3No4RAQYsYkcs1nVRFp3NKv0G41rA8dIB7CKewvgaVI2dg6ju8z5N5sHcrm+xeg47dOZ fHn9PLKul4ktBwSq08HRdL0t5hKeEDT/ak5BI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752269779; x=1752874579; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=x8vFIhJRlcwjRzx6WHDV1hczk0foRb+o+6v6+7f/7B0=; b=ri27B0LzTwniphStgPmzD5b3jrqWEcUwIi1ACs1f1ueENcr1kkog9uSuAAhU9zaIiZ VJ0FaPi9kIIIESzQXNNCNUdwdFKIb9CTggugbBAhnugybYreoWgMMlPssCjQg0ynPdHI qo930zJ+Nb0sdjPzz6b6RGQk+pVPfLV/+LnGmQWRf+ss3BZFssStW7pVsuzTejVO4yl1 /VJNtKQeGmZLQwTAS/gpOg5W3wHsNI7c3hcC15fTJRVs0zKVCEIFUk6dfcyrfjYylNoX rvZNI3yKqdNr3rJo5dThXlXcA7KbuqiVSPRjFcUJcP4LxJFzcqtAJp0cmf2sMFh6MD2d 8Ynw== X-Gm-Message-State: AOJu0YzWje4GsPO7+lxlWsqXzvhjjFePmVjjqlccIU+IqBvR9ysd00Ux SgBeuq8Wh2cnKGfcdnIWypi33U6qktk+QqYtbFlr4w1y87LXuthJ7sRku7R+KiUhqBM6/6C598G djcNdjXJ5spadp3pfPypamZ+NqjxfklEUS8R4utolKg== X-Gm-Gg: ASbGncsoV0obGQ3h1F5H6HOrC3GzhAY3ObMY5uOBhpPhiOoqQcr/K4ExrpXaxFeo2rR FKm76DRe8V+a0lxzEESEyevOjVGoJcP7/p1UDFtFTehcTaLTvzYONUBP2gq4jmPYeuRaN4kV+4J 6e5Srs20sNxqZ/BAt0fADAlPIY8rMO9qUp2BTgVb2PsYuvPeKJPOX7VtV5I3RJaqpvBXuptHEjT /KNcrge6JfeTci4iCcuPa+4cCqVgfDDYExdxzC4R/rTkO8wNM4= X-Google-Smtp-Source: AGHT+IGs1M/IRoeWhWfHTG4WFmwdf5bOdqMrwMPp2OWH6L79JE8GYtjMw2lFQjuvS1CwgywZfCo3WEdrfH3N6JULdMc= X-Received: by 2002:a17:903:11c9:b0:234:9cdd:ffd5 with SMTP id d9443c01a7336-23dee27ce5cmr62399295ad.25.1752269779171; Fri, 11 Jul 2025 14:36:19 -0700 (PDT) MIME-Version: 1.0 References: <20250711203030.10147-1-mmahajan@iol.unh.edu> In-Reply-To: <20250711203030.10147-1-mmahajan@iol.unh.edu> From: Patrick Robb Date: Fri, 11 Jul 2025 17:30:33 -0400 X-Gm-Features: Ac12FXwXlhIBtRJuFjPS_3mmV3NSKvHbJYqcQYzry9Kt3BP2LwO0lmPhWjPsBgg Message-ID: Subject: Re: [PATCH] tests/compress_common: replace coremask with corelist in compress_common To: Manit Mahajan Cc: dts@dpdk.org, dmarchan@redhat.com Content-Type: multipart/alternative; boundary="000000000000bd17e80639ae19e8" X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org --000000000000bd17e80639ae19e8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable This seems fine in principle. Did you ever figure out why the compressdev_autotest was failing with coremask used in the first place? I haven't looked at the coremask deprecation patch that you had found, but David said on slack that it didn't remove the option to use the coremask EAL arg, it just discourages it with a warning. On Fri, Jul 11, 2025 at 4:32=E2=80=AFPM Manit Mahajan wrote: > The compress_common.py script previously used the --coremask parameter, > which has been removed from DPDK. As a result, zlib_pmd test cases > fail when invoking this script. This patch updates the script to > use the --corelist parameter instead, which is the more common > way to specify core assignment in DPDK. > > Signed-off-by: Manit Mahajan > --- > tests/compress_common.py | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/tests/compress_common.py b/tests/compress_common.py > index aa591270..22ce4b74 100644 > --- a/tests/compress_common.py > +++ b/tests/compress_common.py > @@ -94,12 +94,14 @@ def get_input_file(test_case): > > def run_unit(test_case, eal=3D{}): > cores =3D test_case.dut.get_core_list("1S/3C/1T") > - core_mask =3D utils.create_mask(cores) > + core_list =3D [] > + for core in cores: > + core_list.append(str(core)) > + core_str =3D ",".join(core_list) > mem_channels =3D test_case.dut.get_memory_channels() > > default =3D default_eals.copy() > - default["l"] =3D None > - default["c"] =3D core_mask > + default["l"] =3D core_str > default["n"] =3D mem_channels > > eal_str =3D get_opt_str(test_case, default, eal) > -- > 2.41.0 > > --000000000000bd17e80639ae19e8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
This seems fine in principle.

Did y= ou ever figure out why the compressdev_autotest was failing with coremask u= sed in the first place? I haven't looked at the coremask deprecation pa= tch that you had found, but David said on slack that it didn't remove t= he option to use the coremask EAL arg, it just discourages it with a warnin= g.

On Fri, Jul 11, 2025 at 4:32=E2=80=AFPM Manit= Mahajan <mmahajan@iol.unh.edu> wrote:
Th= e compress_common.py script previously used the --coremask parameter,
which has been removed from DPDK. As a result, zlib_pmd test cases
fail when invoking this script. This patch updates the script to
use the --corelist parameter instead, which is the more common
way to specify core assignment in DPDK.

Signed-off-by: Manit Mahajan <mmahajan@iol.unh.edu>
---
=C2=A0tests/compress_common.py | 8 +++++---
=C2=A01 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tests/compress_common.py b/tests/compress_common.py
index aa591270..22ce4b74 100644
--- a/tests/compress_common.py
+++ b/tests/compress_common.py
@@ -94,12 +94,14 @@ def get_input_file(test_case):

=C2=A0def run_unit(test_case, eal=3D{}):
=C2=A0 =C2=A0 =C2=A0cores =3D test_case.dut.get_core_list("1S/3C/1T&qu= ot;)
-=C2=A0 =C2=A0 core_mask =3D utils.create_mask(cores)
+=C2=A0 =C2=A0 core_list =3D []
+=C2=A0 =C2=A0 for core in cores:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 core_list.append(str(core))
+=C2=A0 =C2=A0 core_str =3D ",".join(core_list)
=C2=A0 =C2=A0 =C2=A0mem_channels =3D test_case.dut.get_memory_channels()
=C2=A0 =C2=A0 =C2=A0default =3D default_eals.copy()
-=C2=A0 =C2=A0 default["l"] =3D None
-=C2=A0 =C2=A0 default["c"] =3D core_mask
+=C2=A0 =C2=A0 default["l"] =3D core_str
=C2=A0 =C2=A0 =C2=A0default["n"] =3D mem_channels

=C2=A0 =C2=A0 =C2=A0eal_str =3D get_opt_str(test_case, default, eal)
--
2.41.0

--000000000000bd17e80639ae19e8--