From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1535746BA0; Thu, 17 Jul 2025 20:39:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0FCD04013F; Thu, 17 Jul 2025 20:39:14 +0200 (CEST) Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mails.dpdk.org (Postfix) with ESMTP id 84367400EF for ; Thu, 17 Jul 2025 20:39:12 +0200 (CEST) Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-b3220c39cffso1243167a12.0 for ; Thu, 17 Jul 2025 11:39:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1752777551; x=1753382351; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=R6kIyKjsyAYC14swmwm0e9ytI8rjcAoEWBvsjkEUBwo=; b=an3Kpy7rh1VulT9Pph7Wd8MM3+Po2yE58Lx9V6jy3rkiN4bPzr8rn70AVTo8XqzWjr IjCFpNVD04jY88fk/CEOWECqGmacYFra/2Wp9wZ1tzXSJDBaDDqshH+a7HMUAL030Z8W FnBqxfLYesl8EarrZDEYH1wEYVnCJKHKaynDY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752777551; x=1753382351; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R6kIyKjsyAYC14swmwm0e9ytI8rjcAoEWBvsjkEUBwo=; b=vyZZdB9aC8Psy+hueK1nUXeDO6/kAoVZhJnFKrGLVTMZNIo/YJIuiSXDz7M4zh59NC QGyE5iZzoCGy9r3PSTikomCAiXcZEcV1g5SKzjI8iS8pC4q6xH5QHKJOlCjgEK6KJD9t WcwVEUsf1ziTw0eFUMhxg4DNMpOcx7Z7b5wNuVNY52qu9eMHEjFgZpmjM5hX0jWTBsyR qi3t7nU+UfLgH+srfhmJVe8PXD0hSiHhJn7NE1HZiFWI0IvZbtqcNXx+06MWExVtvaCx uY23MU9QPeedRy0Hs/Z8Jb7NqbVKZQgThSwdK1LPaXuLokIOphjkBo4R43QFJJPmMOWG Vk+w== X-Forwarded-Encrypted: i=1; AJvYcCUaI9oSk1gmJoNC27s7QaKE1dgJJWY+XXYlCQ8WLjbQfmoyMKpSEdcYBnguNA+dq/NxHjs=@dpdk.org X-Gm-Message-State: AOJu0YwqFY9oAM79i9TH2F3Ji0QeA265m0N0KAiXHRcNURiDp4tJSUVo aT4i5/6h5Rp9fRf3drfl5feSl2gtJb9FwnUKwukA4N64fc0rWYj6mlgkZcCJMLDBKe3kQHyuShf incFOi9Yjzea+I+5hGoWSqjSDKFHCFchfSQulQmGh7YHb4lRjDjf4 X-Gm-Gg: ASbGnctF7QbvAm9JqAoR+qsONmlu1JC4kaSKDyi4VgqfsqFJGjN2rpOfy6JcaBPltdl qZumqvTKlt8sOKLs0jfkPi20Ug/CGTjHPBVrSAbOqGaLRcuJmQgJ06HD9+PrfA1W5NdFFB0KQt7 paesxQJlotSRo7jtGwDHMoAYP2MX0m10+Uf3Wc/zqwgjn6VxmPbvYzyRaJRnfT7o0GAI9hZrf2C XDhWUW1kQ== X-Google-Smtp-Source: AGHT+IE4puBN5rgY4RgWca8/ggM1adLZonHGMqCZRcJKllA4vQebDnTN+zAfm8H+8FoKXu8jZ0i8sHaMM8xg+m/RWYU= X-Received: by 2002:a17:90b:3bcd:b0:313:28f1:fc33 with SMTP id 98e67ed59e1d1-31c9f3c5acamr11273002a91.10.1752777551612; Thu, 17 Jul 2025 11:39:11 -0700 (PDT) MIME-Version: 1.0 References: <20250711203030.10147-1-mmahajan@iol.unh.edu> <20250716192456.30120-1-mmahajan@iol.unh.edu> In-Reply-To: From: Patrick Robb Date: Thu, 17 Jul 2025 14:33:18 -0400 X-Gm-Features: Ac12FXzRCGWKnBHo_Dg6MK1w4mrfAcdQgekqsss3No0agO9z5iOLzZCZxBFTFlI Message-ID: Subject: Re: [PATCH v2] compress: resolve test failure from incomplete output capture To: David Marchand Cc: Manit Mahajan , dts@dpdk.org, Thomas Monjalon Content-Type: multipart/alternative; boundary="00000000000055a450063a2453f4" X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org --00000000000055a450063a2453f4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi David, Because Legacy DTS is deprecated, I think you should just push Manit's patch as is. In the case of the Zlib test, this is a legacy DTS test which we are still running at UNH, and we had to patch it locally to keep using the test, so of course we felt we should push the patch to patchwork for visibility at a minimum, and to be merged if maintainers want. Again I don't think it is the best use of Manit's time to have him doing further fixes in legacy DTS when he could be making other contributions to DPDK testing efforts elsewhere. But, if you don't agree, we will adjust. On Thu, Jul 17, 2025 at 4:40=E2=80=AFAM David Marchand wrote: > Hello, > > On Wed, Jul 16, 2025 at 10:36=E2=80=AFPM Patrick Robb = wrote: > > > > On Wed, Jul 16, 2025 at 3:24=E2=80=AFPM Manit Mahajan > wrote: > >> > >> The compress unit test uses send_expect() with '>' to determine > >> when the command completed. A recent patch introduced a > >> deprecation warning for coremask, which includes a '>' in the > >> output. This causes send_expect() to exit early, > >> resulting in missed test output, leading to false failures. > >> > >> This is fixed by changing the expected termination prompt from > >> '>' to 'RTE>'. This change address issues from the v1 patch, > >> which incorrectly modified the EAL option from coremask to > >> corelist. > >> > >> Signed-off-by: Manit Mahajan > > > > Thanks. So, if we change the expect string to "RTE>", the warning will > not trigger the expect and unit tests will complete before the execution > proceeds? Sounds good. > > On the principle, that sounds good to me too. > > Just a note that other parts of "old" dts may be affected: > $ git grep 'send_expect.*">"' > tests/TestSuite_ieee1588.py: self.dut.send_expect("start", ">", 10= ) > tests/TestSuite_multiprocess.py: > self.session_secondary.send_expect("send hello_primary", ">") > tests/TestSuite_multiprocess.py: > self.session_secondary.send_expect("send hello_secondary", ">") > tests/TestSuite_multiprocess.py: self.dut.send_expect("send > %s" % line, ">") > tests/TestSuite_multiprocess.py: > self.session_secondary.send_expect("send hello_primary", ">") > tests/TestSuite_multiprocess.py: > self.session_secondary.send_expect("send hello_secondary", ">", 100) > tests/TestSuite_multiprocess_iavf.py: > self.session_secondary.send_expect("send hello_primary", ">") > tests/TestSuite_multiprocess_iavf.py: > self.session_secondary.send_expect("send hello_secondary", ">") > tests/TestSuite_multiprocess_iavf.py: > self.dut.send_expect("send %s" % line, ">") > tests/TestSuite_multiprocess_iavf.py: > self.session_secondary.send_expect("send hello_primary", ">") > tests/TestSuite_multiprocess_iavf.py: > self.session_secondary.send_expect("send hello_secondary", ">", 100) > tests/TestSuite_shutdown_api.py: self.dut.send_expect("set > link-up port %d" % i, ">") > tests/TestSuite_speed_capabilities.py: > self.dut.send_expect("set link-up port %d" % i, ">") > tests/compress_common.py: test_case.dut.send_expect(cmdline, ">", 30) > tests/compress_common.py: out =3D > test_case.dut.send_expect("compressdev_autotest", ">", 30) > > > How do we proceed now? > Do you want me to push this fix in the dts legacy repo? > > > -- > David Marchand > > --00000000000055a450063a2453f4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi David,

Because Legacy DTS is depreca= ted, I think you should just push Manit's patch as is.=C2=A0
=
In the case of the Zlib test, this is a legacy DTS test whic= h we are still running at UNH, and we had to patch it locally to keep using= the test, so of course we felt we should push the patch to patchwork for v= isibility at a minimum, and to be merged if maintainers want.
Again I don't think it is the best use of Manit's time = to have him doing further fixes in legacy DTS when he could be making other= contributions to DPDK testing efforts elsewhere. But, if you don't agr= ee, we will adjust.

On Thu, Jul 17, 2025 at 4:40=E2=80=AFAM David Marc= hand <dav= id.marchand@redhat.com> wrote:
Hello,

On Wed, Jul 16, 2025 at 10:36=E2=80=AFPM Patrick Robb <probb@iol.unh.edu> wrote:
>
> On Wed, Jul 16, 2025 at 3:24=E2=80=AFPM Manit Mahajan <mmahajan@iol.unh.edu> = wrote:
>>
>> The compress unit test uses send_expect() with '>' to d= etermine
>> when the command completed. A recent patch introduced a
>> deprecation warning for coremask, which includes a '>' = in the
>> output. This causes send_expect() to exit early,
>> resulting in missed test output, leading to false failures.
>>
>> This is fixed by changing the expected termination prompt from
>> '>' to 'RTE>'. This change address issues fr= om the v1 patch,
>> which incorrectly modified the EAL option from coremask to
>> corelist.
>>
>> Signed-off-by: Manit Mahajan <mmahajan@iol.unh.edu>
>
> Thanks. So, if we change the expect string to "RTE>", the= warning will not trigger the expect and unit tests will complete before th= e execution proceeds? Sounds good.

On the principle, that sounds good to me too.

Just a note that other parts of "old" dts may be affected:
$ git grep 'send_expect.*">"'
tests/TestSuite_ieee1588.py:=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.dut.send_expec= t("start", ">", 10)
tests/TestSuite_multiprocess.py:
self.session_secondary.send_expect("send hello_primary", "&g= t;")
tests/TestSuite_multiprocess.py:
self.session_secondary.send_expect("send hello_secondary", "= >")
tests/TestSuite_multiprocess.py:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 s= elf.dut.send_expect("send
%s" % line, ">")
tests/TestSuite_multiprocess.py:
self.session_secondary.send_expect("send hello_primary", "&g= t;")
tests/TestSuite_multiprocess.py:
self.session_secondary.send_expect("send hello_secondary", "= >", 100)
tests/TestSuite_multiprocess_iavf.py:
self.session_secondary.send_expect("send hello_primary", "&g= t;")
tests/TestSuite_multiprocess_iavf.py:
self.session_secondary.send_expect("send hello_secondary", "= >")
tests/TestSuite_multiprocess_iavf.py:
self.dut.send_expect("send %s" % line, ">")
tests/TestSuite_multiprocess_iavf.py:
self.session_secondary.send_expect("send hello_primary", "&g= t;")
tests/TestSuite_multiprocess_iavf.py:
self.session_secondary.send_expect("send hello_secondary", "= >", 100)
tests/TestSuite_shutdown_api.py:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 s= elf.dut.send_expect("set
link-up port %d" % i, ">")
tests/TestSuite_speed_capabilities.py:
self.dut.send_expect("set link-up port %d" % i, ">")=
tests/compress_common.py:=C2=A0 =C2=A0 test_case.dut.send_expect(cmdline, &= quot;>", 30)
tests/compress_common.py:=C2=A0 =C2=A0 out =3D
test_case.dut.send_expect("compressdev_autotest", ">"= ;, 30)


How do we proceed now?
Do you want me to push this fix in the dts legacy repo?


--
David Marchand

--00000000000055a450063a2453f4--