Re: [PATCH v2] compress: resolve test failure from incomplete output capture

[Patrick Robb <probb@iol.unh.edu>]

[-- Attachment #1: Type: text/plain, Size: 1627 bytes --]

Thanks. So, if we change the expect string to "RTE>", the warning will not
trigger the expect and unit tests will complete before the execution
proceeds? Sounds good.

On Wed, Jul 16, 2025 at 3:24 PM Manit Mahajan <mmahajan@iol.unh.edu> wrote:

> The compress unit test uses send_expect() with '>' to determine
> when the command completed. A recent patch introduced a
> deprecation warning for coremask, which includes a '>' in the
> output. This causes send_expect() to exit early,
> resulting in missed test output, leading to false failures.
>
> This is fixed by changing the expected termination prompt from
> '>' to 'RTE>'. This change address issues from the v1 patch,
> which incorrectly modified the EAL option from coremask to
> corelist.
>
> Signed-off-by: Manit Mahajan <mmahajan@iol.unh.edu>
> ---
>  tests/compress_common.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/compress_common.py b/tests/compress_common.py
> index aa591270..b4fd1921 100644
> --- a/tests/compress_common.py
> +++ b/tests/compress_common.py
> @@ -106,8 +106,8 @@ def run_unit(test_case, eal={}):
>      cmdline = "./{app_path} {eal}".format(
>          app_path=test_case.dut.apps_name["test"], eal=eal_str
>      )
> -    test_case.dut.send_expect(cmdline, ">", 30)
> -    out = test_case.dut.send_expect("compressdev_autotest", ">", 30)
> +    test_case.dut.send_expect(cmdline, "RTE>", 30)
> +    out = test_case.dut.send_expect("compressdev_autotest", "RTE>", 30)
>      test_case.dut.send_expect("quit", "# ", 30)
>      print(out)
>
> --
> 2.41.0
>
>

[-- Attachment #2: Type: text/html, Size: 2256 bytes --]