From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AAD4346B91; Wed, 16 Jul 2025 22:36:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A4CCC4065C; Wed, 16 Jul 2025 22:36:53 +0200 (CEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 6BE894065C for ; Wed, 16 Jul 2025 22:36:52 +0200 (CEST) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-23694cec0feso2190385ad.2 for ; Wed, 16 Jul 2025 13:36:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1752698211; x=1753303011; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=V/q4w6EE+2LEtDVSW6T7N+IVBBHu+DAKUCFXV4El9pQ=; b=jZTjRCyRg/819ETOhI1u+nG4d4TD0G4l+LZx6KT4oZhgu1QdCwwtbsjsvzDCkfew4J +hA1kCpkyMkCfm4skVJSahHiwTK7vZ0r4LNwqj/Rx0YGDSQRKy0SUpAz+nVPJ6b9AEpa Pw8V9vVdMmMWV9+YhujPT4T8L830CnES6tYNA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752698211; x=1753303011; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=V/q4w6EE+2LEtDVSW6T7N+IVBBHu+DAKUCFXV4El9pQ=; b=F+BrGyp/XqiEEvASEQXAgR3z5+crtii7+kfgnlcUyGiHIotAKPghB3g6tQBJ+ruucO ZshcJOm8jd9qDKcYOHNkMEg9J02DKRep0RsGGhXfAJ1YQ6QzbztCNoRylxUrlhvafc3B nCEXQbtP+A5ZpQzEph+Q1GEFr2Y+DeazsnyhigRRLVRalEBePuRkjviCODGCwqfMapR+ ucTfJ1CLISWYPw3zy6JN/gN0cba+DVknxXXHobBqVvTCBGJBs4ukeCuy4tHSVvtftt0U PBPPfwC6+H5PIn9KHteqBsa3tqnRRR/h0N3UKQm+Td+ekrMsk786k0bqOa2cf6MDOPaW zNDg== X-Gm-Message-State: AOJu0Yyu/H+f8ruxpu9ODaQMVBDpxEE2r6USpq7yQ4JWEXhQsZ9Y2o5W 5wat4na7XkM5nSLrGQ8bf2Gv3N92TbtJ2VY7rErJofw4+8F8+UqYI1S+/9sV68rqOkXpiHOb6SK Fo7mZ3xR1c4l5YKiOa2T5pIY+X7rT4ZU+QdUYZwsUSQ== X-Gm-Gg: ASbGncs0JIjeuDGbEt9CDaD3neMHn5zkoO7sTInnsGAG9vGHbHNf1C0IdsNt4HwxUu6 tvenFgLo14TBkRXdwp+FFB15nEGvee6VjHE7WRAEYWtgusQ4NW3AbeZmNSQ5AQPqdiAEIQSg0H+ dcC/6dZREsFNBbDV0L48ysp9h/fsAy5uOdf4rI2B03oPe6mIlCP/6GSEWjmy5n7TgqYCURRo9na 2lzA7XL5A== X-Google-Smtp-Source: AGHT+IG1PBd45DAtP6QF3AYt1smQqhO8+1eOt5WZWxRQfGfHNj5nWCo/t6CQtLvHPt4NUY39ztwj683z5TlzEQiU2Ns= X-Received: by 2002:a17:90b:5447:b0:311:ba2e:bdca with SMTP id 98e67ed59e1d1-31c9e76f0cbmr6311898a91.28.1752698211557; Wed, 16 Jul 2025 13:36:51 -0700 (PDT) MIME-Version: 1.0 References: <20250711203030.10147-1-mmahajan@iol.unh.edu> <20250716192456.30120-1-mmahajan@iol.unh.edu> In-Reply-To: <20250716192456.30120-1-mmahajan@iol.unh.edu> From: Patrick Robb Date: Wed, 16 Jul 2025 16:30:59 -0400 X-Gm-Features: Ac12FXyZxuGVnkU1mYOXZNHwhmyH_VOKdASwBrNEj9jvYd_lsaYtemH7tqUwDx0 Message-ID: Subject: Re: [PATCH v2] compress: resolve test failure from incomplete output capture To: Manit Mahajan Cc: dts@dpdk.org, david.marchand@redhat.com Content-Type: multipart/alternative; boundary="0000000000004c77d7063a11daad" X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org --0000000000004c77d7063a11daad Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks. So, if we change the expect string to "RTE>", the warning will not trigger the expect and unit tests will complete before the execution proceeds? Sounds good. On Wed, Jul 16, 2025 at 3:24=E2=80=AFPM Manit Mahajan wrote: > The compress unit test uses send_expect() with '>' to determine > when the command completed. A recent patch introduced a > deprecation warning for coremask, which includes a '>' in the > output. This causes send_expect() to exit early, > resulting in missed test output, leading to false failures. > > This is fixed by changing the expected termination prompt from > '>' to 'RTE>'. This change address issues from the v1 patch, > which incorrectly modified the EAL option from coremask to > corelist. > > Signed-off-by: Manit Mahajan > --- > tests/compress_common.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/compress_common.py b/tests/compress_common.py > index aa591270..b4fd1921 100644 > --- a/tests/compress_common.py > +++ b/tests/compress_common.py > @@ -106,8 +106,8 @@ def run_unit(test_case, eal=3D{}): > cmdline =3D "./{app_path} {eal}".format( > app_path=3Dtest_case.dut.apps_name["test"], eal=3Deal_str > ) > - test_case.dut.send_expect(cmdline, ">", 30) > - out =3D test_case.dut.send_expect("compressdev_autotest", ">", 30) > + test_case.dut.send_expect(cmdline, "RTE>", 30) > + out =3D test_case.dut.send_expect("compressdev_autotest", "RTE>", 30= ) > test_case.dut.send_expect("quit", "# ", 30) > print(out) > > -- > 2.41.0 > > --0000000000004c77d7063a11daad Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks. So, if we change the expect string to "RTE>= ;", the warning will not trigger the expect and unit tests will comple= te before the execution proceeds? Sounds good.=C2=A0

O= n Wed, Jul 16, 2025 at 3:24=E2=80=AFPM Manit Mahajan <mmahajan@iol.unh.edu> wrote:
The compress unit test uses send_= expect() with '>' to determine
when the command completed. A recent patch introduced a
deprecation warning for coremask, which includes a '>' in the output. This causes send_expect() to exit early,
resulting in missed test output, leading to false failures.

This is fixed by changing the expected termination prompt from
'>' to 'RTE>'. This change address issues from the v1= patch,
which incorrectly modified the EAL option from coremask to
corelist.

Signed-off-by: Manit Mahajan <mmahajan@iol.unh.edu>
---
=C2=A0tests/compress_common.py | 4 ++--
=C2=A01 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/compress_common.py b/tests/compress_common.py
index aa591270..b4fd1921 100644
--- a/tests/compress_common.py
+++ b/tests/compress_common.py
@@ -106,8 +106,8 @@ def run_unit(test_case, eal=3D{}):
=C2=A0 =C2=A0 =C2=A0cmdline =3D "./{app_path} {eal}".format(
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0app_path=3Dtest_case.dut.apps_name["= test"], eal=3Deal_str
=C2=A0 =C2=A0 =C2=A0)
-=C2=A0 =C2=A0 test_case.dut.send_expect(cmdline, ">", 30)
-=C2=A0 =C2=A0 out =3D test_case.dut.send_expect("compressdev_autotest= ", ">", 30)
+=C2=A0 =C2=A0 test_case.dut.send_expect(cmdline, "RTE>", 30)<= br> +=C2=A0 =C2=A0 out =3D test_case.dut.send_expect("compressdev_autotest= ", "RTE>", 30)
=C2=A0 =C2=A0 =C2=A0test_case.dut.send_expect("quit", "# &qu= ot;, 30)
=C2=A0 =C2=A0 =C2=A0print(out)

--
2.41.0

--0000000000004c77d7063a11daad--