test suite reviews and discussions
 help / color / mirror / Atom feed
* [PATCH] tests/compress_common: replace coremask with corelist in compress_common
@ 2025-07-11 20:30 Manit Mahajan
  2025-07-11 21:30 ` Patrick Robb
  2025-07-16 19:24 ` [PATCH v2] compress: resolve test failure from incomplete output capture Manit Mahajan
  0 siblings, 2 replies; 10+ messages in thread
From: Manit Mahajan @ 2025-07-11 20:30 UTC (permalink / raw)
  To: dts; +Cc: dmarchan, probb, Manit Mahajan

The compress_common.py script previously used the --coremask parameter,
which has been removed from DPDK. As a result, zlib_pmd test cases
fail when invoking this script. This patch updates the script to
use the --corelist parameter instead, which is the more common
way to specify core assignment in DPDK.

Signed-off-by: Manit Mahajan <mmahajan@iol.unh.edu>
---
 tests/compress_common.py | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tests/compress_common.py b/tests/compress_common.py
index aa591270..22ce4b74 100644
--- a/tests/compress_common.py
+++ b/tests/compress_common.py
@@ -94,12 +94,14 @@ def get_input_file(test_case):
 
 def run_unit(test_case, eal={}):
     cores = test_case.dut.get_core_list("1S/3C/1T")
-    core_mask = utils.create_mask(cores)
+    core_list = []
+    for core in cores:
+        core_list.append(str(core))
+    core_str = ",".join(core_list)
     mem_channels = test_case.dut.get_memory_channels()
 
     default = default_eals.copy()
-    default["l"] = None
-    default["c"] = core_mask
+    default["l"] = core_str
     default["n"] = mem_channels
 
     eal_str = get_opt_str(test_case, default, eal)
-- 
2.41.0


^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH v2] compress: resolve test failure from incomplete output capture
@ 2025-07-16 15:28 Manit Mahajan
  2025-07-16 15:43 ` Manit Mahajan
  0 siblings, 1 reply; 10+ messages in thread
From: Manit Mahajan @ 2025-07-16 15:28 UTC (permalink / raw)
  To: dts; +Cc: probb, david.marchand, Manit Mahajan

The compress unit test uses send_expect() with '>' to determine
when the command completed. A recent patch introduced a
deprecation warning for coremask, which includes a '>' in the
output. This causes send_expect() to exit early,
resulting in missed test output, leading to false failures.

This is fixed by changing the expected termination prompt from
'>' to 'RTE'. This change address issues from the v1 patch,
which incorrectly modified the EAL option from coremask to
corelist.

Signed-off-by: Manit Mahajan <mmahajan@iol.unh.edu>
---
 tests/compress_common.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tests/compress_common.py b/tests/compress_common.py
index aa591270..94c6f9dd 100644
--- a/tests/compress_common.py
+++ b/tests/compress_common.py
@@ -63,6 +63,7 @@ def bind_qat_device(test_case, driver="igb_uio"):
 
 def get_opt_str(test_case, default_opts={}, override_opts={}):
     case_cfg = conf.load_case_config(test_case._suite_result.test_case)
+    print("case_cfg ", case_cfg)
     opts = default_opts.copy()
     for key in list(default_opts.keys()):
         if key in case_cfg:
@@ -70,6 +71,8 @@ def get_opt_str(test_case, default_opts={}, override_opts={}):
 
     opts.update(override_opts)
 
+    print("opts ", opts)
+
     opt_str = ""
     for key, value in list(opts.items()):
         if value is None:
@@ -77,6 +80,7 @@ def get_opt_str(test_case, default_opts={}, override_opts={}):
         dash = "-" if len(key) == 1 else "--"
         opt_str = opt_str + "{0}{1} {2} ".format(dash, key, value)
 
+    print('opt_str ', opt_str)
     return opt_str
 
 
@@ -106,8 +110,8 @@ def run_unit(test_case, eal={}):
     cmdline = "./{app_path} {eal}".format(
         app_path=test_case.dut.apps_name["test"], eal=eal_str
     )
-    test_case.dut.send_expect(cmdline, ">", 30)
-    out = test_case.dut.send_expect("compressdev_autotest", ">", 30)
+    test_case.dut.send_expect(cmdline, "RTE>", 30)
+    out = test_case.dut.send_expect("compressdev_autotest", "RTE>", 30)
     test_case.dut.send_expect("quit", "# ", 30)
     print(out)
 
-- 
2.41.0


^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2025-07-17 18:39 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-11 20:30 [PATCH] tests/compress_common: replace coremask with corelist in compress_common Manit Mahajan
2025-07-11 21:30 ` Patrick Robb
2025-07-15  7:42   ` David Marchand
2025-07-16 15:53     ` Manit Mahajan
2025-07-16 19:24 ` [PATCH v2] compress: resolve test failure from incomplete output capture Manit Mahajan
2025-07-16 20:30   ` Patrick Robb
2025-07-17  8:40     ` David Marchand
2025-07-17 18:33       ` Patrick Robb
2025-07-16 15:28 Manit Mahajan
2025-07-16 15:43 ` Manit Mahajan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).