Re: [PATCH] tests/compress_common: replace coremask with corelist in compress_common

[Manit Mahajan <mmahajan@iol.unh.edu>]

[-- Attachment #1: Type: text/plain, Size: 1701 bytes --]

Hi,

Thanks for the clarification. I had misunderstood the patch that added the
coremask warning and incorrectly assumed that -c was deprecated. Upon
closer review, I see that the patch only adds warning logs when using
coremask but does not deprecate the -c option. The actual problem is that
the warning message includes a '>', which causes send_expect('>') to return
prematurely and miss important test output. I will address this in v2 by
changing the expected prompt to 'RTE>'.


On Tue, Jul 15, 2025 at 3:42 AM David Marchand <david.marchand@redhat.com>
wrote:

> Hello,
>
> On Fri, Jul 11, 2025 at 11:36 PM Patrick Robb <probb@iol.unh.edu> wrote:
> >
> > This seems fine in principle.
> >
> > Did you ever figure out why the compressdev_autotest was failing with
> coremask used in the first place? I haven't looked at the coremask
> deprecation patch that you had found, but David said on slack that it
> didn't remove the option to use the coremask EAL arg, it just discourages
> it with a warning.
> >
> > On Fri, Jul 11, 2025 at 4:32 PM Manit Mahajan <mmahajan@iol.unh.edu>
> wrote:
> >>
> >> The compress_common.py script previously used the --coremask parameter,
> >> which has been removed from DPDK. As a result, zlib_pmd test cases
> >> fail when invoking this script. This patch updates the script to
>
> There is no --coremask EAL option.
> And the option -c was not removed.
>
> Please refine the rca.
>
> >> use the --corelist parameter instead, which is the more common
> >> way to specify core assignment in DPDK.
>
> There is no --corelist EAL option.
>
> Only -c, -l and --lcores exist atm.
>
>
> --
> David Marchand
>
>

[-- Attachment #2: Type: text/html, Size: 2286 bytes --]