From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21E1746B9C; Thu, 17 Jul 2025 10:27:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 124784065B; Thu, 17 Jul 2025 10:27:28 +0200 (CEST) Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) by mails.dpdk.org (Postfix) with ESMTP id 10E83400D6 for ; Wed, 16 Jul 2025 17:53:31 +0200 (CEST) Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-70e5d953c0bso72855487b3.1 for ; Wed, 16 Jul 2025 08:53:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1752681210; x=1753286010; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=vCHgiGvXRvLJdaYK23yHVin8RQ5fK61shBIDq/k4omI=; b=Od7r82LV5sUDn1ILd0YjD30eduSZ4bq9kHQHX+xQAc0k2k8F67Yd/H7jbkTwIbSoNn J3Wd3DDe3T7GGm5YLzKdjlSo4+6hncFvj0oq0gU5apRGClt2m5MIIcUvMM2eJoXCZyNv sl48g3F9fRc7MbU351nD4Vf9Zzn8XfydBAlCc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752681210; x=1753286010; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vCHgiGvXRvLJdaYK23yHVin8RQ5fK61shBIDq/k4omI=; b=HlC6MMuRVWMFmG8fPrfEQ8Udp0X/2684aKR6AN9YEdSBW+nI9PocRpzo2CbkKAUBd3 EBGJG+Cf6HxBrhEG1wABu/VKXq9KywUNRfvuSGl6MrVoXaE/qKZneAuO+XYE2L/FDCnA 2wnKjA2Z/jMuIumBDE9/LOxj3yrdGUmln8r6J7D+3IZoUEQODTp2KEkj4SsSgPD5eqkz 3a1Nr0H7MdC0Q37W8c9Tmu+MGc4sgGgp9C3/yTU2kJJ8f2R6vCgzQmP/Ms43iZghqvkf dgrQmbIE6Ow1Vf+Dj95TjqmtYyG+QO06t9wNAFq5e7Ue/9feXtRzLAy5/ck6v2zxYgdZ 2bJA== X-Forwarded-Encrypted: i=1; AJvYcCXia8xqgDRme19XwVie6DPLA8Zv/AbbtwZ3cPNZIBRdjT7ynnxbPMuTMkbNLskA4bp17gU=@dpdk.org X-Gm-Message-State: AOJu0Yycs8N2d/ym828/DtQbFu+bOd+uk5qlonqiU13Xpc3OlIEbC9dD UtZGVT/tH/bdRTEOxY76KmcoI3UPZnSP3v2VwFjavYAY9men5URy3L+HuPLVQtpPfK+AxnjWhdm LZLkv4fZw/PJofIXKtkzPmAun8tN83Jw5o/ZVkkOcTQ== X-Gm-Gg: ASbGncslxAH8UxGeh8MgUnNAdofny/UtRhXonyLlyJqMhuVQicP4Ll6/S9cHnqJPyah 84UXih0AWVkCm/UAXAnVByZwjt2IIRxLej6+AzbiMNvfAIg5dI22xPBP9n22fD0jgjw/furkdWQ L5OjykaQpbs6N49WjmFEePQnKOoZ+HHxabu1IvP44Mp4FaaT0iMtqYCbXiw9zQDuoHQY3bEK1yN LJwz5qlkA== X-Google-Smtp-Source: AGHT+IFjtegmPRJTaLOlgqzCVFbs1SQJpAajadvrzxzfl4c3GyUVbh1ZrIYvDik8kU+l5wy6je98n98JhkCXwrnvTUY= X-Received: by 2002:a05:690c:5201:b0:718:38bd:bee5 with SMTP id 00721157ae682-71838bdd04dmr26329937b3.41.1752681210131; Wed, 16 Jul 2025 08:53:30 -0700 (PDT) MIME-Version: 1.0 References: <20250711203030.10147-1-mmahajan@iol.unh.edu> In-Reply-To: From: Manit Mahajan Date: Wed, 16 Jul 2025 11:53:18 -0400 X-Gm-Features: Ac12FXy1LpibjqhpHaXqUNUFEJKYc_KO3ac8r8ka-7xOWLJRR10lkBdw0Nvl7Ts Message-ID: Subject: Re: [PATCH] tests/compress_common: replace coremask with corelist in compress_common To: David Marchand Cc: Patrick Robb , dts@dpdk.org, Thomas Monjalon Content-Type: multipart/alternative; boundary="000000000000ef4f8e063a0de460" X-Mailman-Approved-At: Thu, 17 Jul 2025 10:27:24 +0200 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org --000000000000ef4f8e063a0de460 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Thanks for the clarification. I had misunderstood the patch that added the coremask warning and incorrectly assumed that -c was deprecated. Upon closer review, I see that the patch only adds warning logs when using coremask but does not deprecate the -c option. The actual problem is that the warning message includes a '>', which causes send_expect('>') to return prematurely and miss important test output. I will address this in v2 by changing the expected prompt to 'RTE>'. On Tue, Jul 15, 2025 at 3:42=E2=80=AFAM David Marchand wrote: > Hello, > > On Fri, Jul 11, 2025 at 11:36=E2=80=AFPM Patrick Robb = wrote: > > > > This seems fine in principle. > > > > Did you ever figure out why the compressdev_autotest was failing with > coremask used in the first place? I haven't looked at the coremask > deprecation patch that you had found, but David said on slack that it > didn't remove the option to use the coremask EAL arg, it just discourages > it with a warning. > > > > On Fri, Jul 11, 2025 at 4:32=E2=80=AFPM Manit Mahajan > wrote: > >> > >> The compress_common.py script previously used the --coremask parameter= , > >> which has been removed from DPDK. As a result, zlib_pmd test cases > >> fail when invoking this script. This patch updates the script to > > There is no --coremask EAL option. > And the option -c was not removed. > > Please refine the rca. > > >> use the --corelist parameter instead, which is the more common > >> way to specify core assignment in DPDK. > > There is no --corelist EAL option. > > Only -c, -l and --lcores exist atm. > > > -- > David Marchand > > --000000000000ef4f8e063a0de460 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Hi,

Thanks for the clarification. I had misunder= stood the patch that added the coremask warning and incorrectly assumed tha= t -c was deprecated. Upon closer review, I see that the patch only adds war= ning logs when using coremask but does not deprecate the -c option. The act= ual problem is that the warning message includes a '>', which ca= uses send_expect('>') to return prematurely and miss important t= est output. I will address this in v2 by changing the expected prompt to &#= 39;RTE>'.


On Tue, Jul 15, 2025 at 3= :42=E2=80=AFAM David Marchand <david.marchand@redhat.com> wrote:
Hello,

On Fri, Jul 11, 2025 at 11:36=E2=80=AFPM Patrick Robb <probb@iol.unh.edu> wrote:
>
> This seems fine in principle.
>
> Did you ever figure out why the compressdev_autotest was failing with = coremask used in the first place? I haven't looked at the coremask depr= ecation patch that you had found, but David said on slack that it didn'= t remove the option to use the coremask EAL arg, it just discourages it wit= h a warning.
>
> On Fri, Jul 11, 2025 at 4:32=E2=80=AFPM Manit Mahajan <mmahajan@iol.unh.edu> = wrote:
>>
>> The compress_common.py script previously used the --coremask param= eter,
>> which has been removed from DPDK. As a result, zlib_pmd test cases=
>> fail when invoking this script. This patch updates the script to
There is no --coremask EAL option.
And the option -c was not removed.

Please refine the rca.

>> use the --corelist parameter instead, which is the more common
>> way to specify core assignment in DPDK.

There is no --corelist EAL option.

Only -c, -l and --lcores exist atm.


--
David Marchand

--000000000000ef4f8e063a0de460--