[dts] [PATCH V1 0/2] remove fortville_rss_input/global_hash_configuration

[dts] [PATCH V1 0/2] remove fortville_rss_input/global_hash_configuration

[Yu Jiang]

According to dpdk commit 81db321da ethdev: remove legacy HASH filter type support,
remove case test_global_hash_configuration

Yu Jiang (2):
  test_plans/fortville_rss_input_test_plan: remove global configurations
    of hash filter case
  tests/fortville_rss_input: remove global configurations of hash filter
    case

 test_plans/fortville_rss_input_test_plan.rst | 29 -------------------------
 tests/TestSuite_fortville_rss_input.py       | 32 ----------------------------
 2 files changed, 61 deletions(-)

-- 
2.7.4

[dts] [PATCH V1 1/2] test_plans/fortville_rss_input_test_plan: remove global configurations of hash filter case

[Yu Jiang]

According to dpdk commit 81db321da ethdev: remove legacy HASH filter type support,
remove case test_global_hash_configuration 

Signed-off-by: Yu Jiang <yux.jiang@intel.com>
---
 test_plans/fortville_rss_input_test_plan.rst | 29 ----------------------------
 1 file changed, 29 deletions(-)

diff --git a/test_plans/fortville_rss_input_test_plan.rst b/test_plans/fortville_rss_input_test_plan.rst
index 1f249ac..a73b1b5 100644
--- a/test_plans/fortville_rss_input_test_plan.rst
+++ b/test_plans/fortville_rss_input_test_plan.rst
@@ -58,35 +58,6 @@ Prerequisites
     testpmd>set verbose 1
     testpmd>start
 
-Test Case: test global configurations of hash filter
-====================================================
-
-create a rule that set global configurations of hash filters is toeplitz::
-
-    testpmd> flow create 0 ingress pattern end actions rss types end queues end func simple_xor / end
-    testpmd> flow list 0
-
-verify the Rule is RSS.
-
-get the status of hash configuration::
-
-    testpmd> get_hash_global_config 0
-
-verify Hash function is simple_xor.
-
-delete the rule::
-
-    testpmd> flow flush 0
-    testpmd> flow list 0
-
-verify the rules have been destroyed.
-
-get the status of hash configuration::
-
-    testpmd> get_hash_global_config 0
-
-verify Hash function is toeplitz.
-
 Test Case: test symmetric hash configuration
 ============================================
 
-- 
2.7.4

[dts] [PATCH V1 2/2] tests/fortville_rss_input: remove global configurations of hash filter case

[Yu Jiang]

According to dpdk commit 81db321da ethdev: remove legacy HASH filter type support,
remove test case test_global_hash_configuration

Signed-off-by: Yu Jiang <yux.jiang@intel.com>
---
 tests/TestSuite_fortville_rss_input.py | 32 --------------------------------
 1 file changed, 32 deletions(-)

diff --git a/tests/TestSuite_fortville_rss_input.py b/tests/TestSuite_fortville_rss_input.py
index f542b66..4ba413f 100644
--- a/tests/TestSuite_fortville_rss_input.py
+++ b/tests/TestSuite_fortville_rss_input.py
@@ -305,38 +305,6 @@ class TestFortvilleRssInput(TestCase):
         res = self.pmdout.wait_link_status_up("all")
         self.verify(res is True, "link is down")
 
-    def test_global_hash_configuration(self):
-        """
-        Test with flow type ipv4-tcp.
-        """
-        flag = 1
-
-        self.start_testpmd()
-
-        # set hash input set by testpmd on dut, enable default input set
-        self.dut.send_expect(
-            "flow create 0 ingress pattern end actions rss types end queues end func simple_xor / end", "testpmd> ")
-            
-        out = self.dut.send_expect("get_hash_global_config 0", "testpmd>")
-        result_scanner = r"Hash function is Simple XOR"
-        scanner = re.compile(result_scanner, re.DOTALL)
-        m = scanner.search(out)
-        if m:
-            self.verify(1, "Pass")
-        else:
-            self.verify(0, "Fail")
-
-        self.dut.send_expect(
-            "flow destroy 0 rule 0", "testpmd>")
-        out = self.dut.send_expect("get_hash_global_config 0", "testpmd>")
-        rexp = r"Hash function is Toeplitz"
-        scanner = re.compile(rexp, re.DOTALL)
-        m = scanner.search(out)
-        if m:
-            self.verify(1, "Pass")
-        else:
-            self.verify(0, "Fail")
-
     def test_symmetric_hash_configuration(self):
         """
         Test with flow type ipv4-tcp.
-- 
2.7.4

Re: [dts] [PATCH V1 0/2] remove fortville_rss_input/global_hash_configuration

[Jiang, YuX]

[-- Attachment #1: Type: text/plain, Size: 877 bytes --]

> -----Original Message-----
> From: Jiang, YuX <yux.jiang@intel.com>
> Sent: Thursday, August 19, 2021 7:35 PM
> To: dts@dpdk.org
> Cc: Jiang, YuX <yux.jiang@intel.com>
> Subject: [dts][PATCH V1 0/2] remove
> fortville_rss_input/global_hash_configuration
> 
> According to dpdk commit 81db321da ethdev: remove legacy HASH filter
> type support, remove case test_global_hash_configuration
> 
> Yu Jiang (2):
>   test_plans/fortville_rss_input_test_plan: remove global configurations
>     of hash filter case
>   tests/fortville_rss_input: remove global configurations of hash filter
>     case
> 
>  test_plans/fortville_rss_input_test_plan.rst | 29 -------------------------
>  tests/TestSuite_fortville_rss_input.py       | 32 ----------------------------
>  2 files changed, 61 deletions(-)
> 
> --
> 2.7.4
Tested-by: Yu Jiang <yux.jiang@intel.com>

[-- Attachment #2: TestFortvilleRssInput.log --]
[-- Type: application/octet-stream, Size: 2440593 bytes --]

Re: [dts] [PATCH V1 2/2] tests/fortville_rss_input: remove global configurations of hash filter case

[Jiang, YuX]

> -----Original Message-----
> From: Jiang, YuX <yux.jiang@intel.com>
> Sent: Thursday, August 19, 2021 7:35 PM
> To: dts@dpdk.org
> Cc: Jiang, YuX <yux.jiang@intel.com>
> Subject: [dts][PATCH V1 2/2] tests/fortville_rss_input: remove global
> configurations of hash filter case
> 
> According to dpdk commit 81db321da ethdev: remove legacy HASH filter
> type support, remove test case test_global_hash_configuration
> 
> Signed-off-by: Yu Jiang <yux.jiang@intel.com>
> ---
Tested-by: Yu Jiang <yux.jiang@intel.com> 

Re: [dts] [PATCH V1 2/2] tests/fortville_rss_input: remove global configurations of hash filter case

[Peng, Yuan]

Acked-by Peng, Yuan <yuan.peng@intel.com>

-----Original Message-----
From: Jiang, YuX <yux.jiang@intel.com> 
Sent: Tuesday, September 14, 2021 2:07 PM
To: dts@dpdk.org
Cc: Peng, Yuan <yuan.peng@intel.com>
Subject: RE: [dts][PATCH V1 2/2] tests/fortville_rss_input: remove global configurations of hash filter case

> -----Original Message-----
> From: Jiang, YuX <yux.jiang@intel.com>
> Sent: Thursday, August 19, 2021 7:35 PM
> To: dts@dpdk.org
> Cc: Jiang, YuX <yux.jiang@intel.com>
> Subject: [dts][PATCH V1 2/2] tests/fortville_rss_input: remove global 
> configurations of hash filter case
> 
> According to dpdk commit 81db321da ethdev: remove legacy HASH filter 
> type support, remove test case test_global_hash_configuration
> 
> Signed-off-by: Yu Jiang <yux.jiang@intel.com>
> ---
Tested-by: Yu Jiang <yux.jiang@intel.com> 

Re: [dts] [PATCH V1 1/2] test_plans/fortville_rss_input_test_plan: remove global configurations of hash filter case

[Tu, Lijuan]

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Yu Jiang
> Sent: 2021年8月19日 19:35
> To: dts@dpdk.org
> Cc: Jiang, YuX <yux.jiang@intel.com>
> Subject: [dts] [PATCH V1 1/2] test_plans/fortville_rss_input_test_plan: remove
> global configurations of hash filter case
> 
> According to dpdk commit 81db321da ethdev: remove legacy HASH filter type
> support, remove case test_global_hash_configuration
> 
> Signed-off-by: Yu Jiang <yux.jiang@intel.com>

dpdk commit 81db321da says "Instead of HASH filter RTE flow API should be used"
Is the RTE flow API for HASH filter already in dts ? if yes, could you provide the position.

> ---
>  test_plans/fortville_rss_input_test_plan.rst | 29 ----------------------------
>  1 file changed, 29 deletions(-)
> 
> diff --git a/test_plans/fortville_rss_input_test_plan.rst
> b/test_plans/fortville_rss_input_test_plan.rst
> index 1f249ac..a73b1b5 100644
> --- a/test_plans/fortville_rss_input_test_plan.rst
> +++ b/test_plans/fortville_rss_input_test_plan.rst
> @@ -58,35 +58,6 @@ Prerequisites
>      testpmd>set verbose 1
>      testpmd>start
> 
> -Test Case: test global configurations of hash filter -
> ====================================================
> -
> -create a rule that set global configurations of hash filters is toeplitz::
> -
> -    testpmd> flow create 0 ingress pattern end actions rss types end queues end
> func simple_xor / end
> -    testpmd> flow list 0
> -
> -verify the Rule is RSS.
> -
> -get the status of hash configuration::
> -
> -    testpmd> get_hash_global_config 0
> -
> -verify Hash function is simple_xor.
> -
> -delete the rule::
> -
> -    testpmd> flow flush 0
> -    testpmd> flow list 0
> -
> -verify the rules have been destroyed.
> -
> -get the status of hash configuration::
> -
> -    testpmd> get_hash_global_config 0
> -
> -verify Hash function is toeplitz.
> -
>  Test Case: test symmetric hash configuration
> ============================================
> 
> --
> 2.7.4

Re: [dts] [PATCH V1 1/2] test_plans/fortville_rss_input_test_plan: remove global configurations of hash filter case

[Jiang, YuX]

> -----Original Message-----
> From: Tu, Lijuan <lijuan.tu@intel.com>
> Sent: Tuesday, September 14, 2021 3:57 PM
> To: Jiang, YuX <yux.jiang@intel.com>; dts@dpdk.org
> Cc: Jiang, YuX <yux.jiang@intel.com>
> Subject: RE: [dts] [PATCH V1 1/2] test_plans/fortville_rss_input_test_plan:
> remove global configurations of hash filter case
> 
> 
> 
> > -----Original Message-----
> > From: dts <dts-bounces@dpdk.org> On Behalf Of Yu Jiang
> > Sent: 2021年8月19日 19:35
> > To: dts@dpdk.org
> > Cc: Jiang, YuX <yux.jiang@intel.com>
> > Subject: [dts] [PATCH V1 1/2]
> > test_plans/fortville_rss_input_test_plan: remove global configurations
> > of hash filter case
> >
> > According to dpdk commit 81db321da ethdev: remove legacy HASH filter
> > type support, remove case test_global_hash_configuration
> >
> > Signed-off-by: Yu Jiang <yux.jiang@intel.com>
> 
> dpdk commit 81db321da says "Instead of HASH filter RTE flow API should be
> used"
> Is the RTE flow API for HASH filter already in dts ? if yes, could you provide
> the position.
> 
I check this suite has one case: Test Case: test query RSS rule  includes "testpmd> flow create 0 ingress pattern end actions rss types end queues end func simple_xor / end" and verify rule's hash function.
And get_hash_global_config 0 Is not supported due to commit id, only can use " testpmd> flow query 0 0 rss" to query rss  hash function. If no, rss rule, it can not query rss hash. 
So this is why i remove this case. @Peng, Yuan Do you have any good suggestion about this?

> > ---
> >  test_plans/fortville_rss_input_test_plan.rst | 29
> > ----------------------------
> >  1 file changed, 29 deletions(-)
> >
> > diff --git a/test_plans/fortville_rss_input_test_plan.rst
> > b/test_plans/fortville_rss_input_test_plan.rst
> > index 1f249ac..a73b1b5 100644
> > --- a/test_plans/fortville_rss_input_test_plan.rst
> > +++ b/test_plans/fortville_rss_input_test_plan.rst
> > @@ -58,35 +58,6 @@ Prerequisites
> >      testpmd>set verbose 1
> >      testpmd>start
> >
> > -Test Case: test global configurations of hash filter -
> > ====================================================
> > -
> > -create a rule that set global configurations of hash filters is toeplitz::
> > -
> > -    testpmd> flow create 0 ingress pattern end actions rss types end
> queues end
> > func simple_xor / end
> > -    testpmd> flow list 0
> > -
> > -verify the Rule is RSS.
> > -
> > -get the status of hash configuration::
> > -
> > -    testpmd> get_hash_global_config 0
> > -
> > -verify Hash function is simple_xor.
> > -
> > -delete the rule::
> > -
> > -    testpmd> flow flush 0
> > -    testpmd> flow list 0
> > -
> > -verify the rules have been destroyed.
> > -
> > -get the status of hash configuration::
> > -
> > -    testpmd> get_hash_global_config 0
> > -
> > -verify Hash function is toeplitz.
> > -
> >  Test Case: test symmetric hash configuration
> > ============================================
> >
> > --
> > 2.7.4
> 

Re: [dts] [PATCH V1 2/2] tests/fortville_rss_input: remove global configurations of hash filter case

[Tu, Lijuan]

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Peng, Yuan
> Sent: 2021年9月14日 14:31
> To: Jiang, YuX <yux.jiang@intel.com>; dts@dpdk.org
> Subject: Re: [dts] [PATCH V1 2/2] tests/fortville_rss_input: remove global
> configurations of hash filter case
> 
> Acked-by Peng, Yuan <yuan.peng@intel.com>
> 
> -----Original Message-----
> From: Jiang, YuX <yux.jiang@intel.com>
> Sent: Tuesday, September 14, 2021 2:07 PM
> To: dts@dpdk.org
> Cc: Peng, Yuan <yuan.peng@intel.com>
> Subject: RE: [dts][PATCH V1 2/2] tests/fortville_rss_input: remove global
> configurations of hash filter case
> 
> > -----Original Message-----
> > From: Jiang, YuX <yux.jiang@intel.com>
> > Sent: Thursday, August 19, 2021 7:35 PM
> > To: dts@dpdk.org
> > Cc: Jiang, YuX <yux.jiang@intel.com>
> > Subject: [dts][PATCH V1 2/2] tests/fortville_rss_input: remove global
> > configurations of hash filter case
> >
> > According to dpdk commit 81db321da ethdev: remove legacy HASH filter
> > type support, remove test case test_global_hash_configuration
> >
> > Signed-off-by: Yu Jiang <yux.jiang@intel.com>
> > ---
> Tested-by: Yu Jiang <yux.jiang@intel.com>

Applied.