test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts][PATCH V1] tests/pmdrss_hash: remove case test_dynamic_rss_bond_config
@ 2021-11-12  2:50 Yu Jiang
  2021-11-23  6:45 ` Peng, Yuan
  0 siblings, 1 reply; 2+ messages in thread
From: Yu Jiang @ 2021-11-12  2:50 UTC (permalink / raw)
  To: yuan.peng, dts; +Cc: Yu Jiang

According to dpdk commit id 81db321da ("ethdev: remove legacy HASH filter type support"),
No new rte_flow_api support get_hash_global_config, so remove this case.

Signed-off-by: Yu Jiang <yux.jiang@intel.com>
---
 test_plans/pmdrss_hash_test_plan.rst | 32 -----------------------------
 tests/TestSuite_pmdrss_hash.py       | 40 ------------------------------------
 2 files changed, 72 deletions(-)

diff --git a/test_plans/pmdrss_hash_test_plan.rst b/test_plans/pmdrss_hash_test_plan.rst
index 48a61e5..777115b 100644
--- a/test_plans/pmdrss_hash_test_plan.rst
+++ b/test_plans/pmdrss_hash_test_plan.rst
@@ -183,35 +183,3 @@ Test Case:  test_simple_symmetric
 
 The same as the above test case "test_toeplitz_symmetric". Just pay attention to set the hash function to "simple xor"
 
-Test Case:  test_dynamic_rss_bond_config
-========================================
-This case test bond slaves will auto sync rss hash config, it only support by fortville.
-
-#. set up testpmd with fortville NICs::
-
-      ./testpmd -c f -n 4 -- -i
-
-#. create bond device with mode 3::
-
-      create bonded device 3 0
-
-#. add slave to bond device::
-
-      add bonding slave 0 2
-      add bonding slave 1 2
-
-#. get default hash algorithm on slave::
-
-      get_hash_global_config 0
-      get_hash_global_config 1
-
-#. set hash algorithm on slave 0::
-
-      set_hash_global_config 0 simple_xor ipv4-other enable
-
-#. get hash algorithm on slave 0 and 1::
-
-      get_hash_global_config 0
-      get_hash_global_config 1
-
-#. check slave 0 and 1 use same hash algorithm
diff --git a/tests/TestSuite_pmdrss_hash.py b/tests/TestSuite_pmdrss_hash.py
index 9eb17cf..309e1b9 100644
--- a/tests/TestSuite_pmdrss_hash.py
+++ b/tests/TestSuite_pmdrss_hash.py
@@ -625,46 +625,6 @@ class TestPmdrssHash(TestCase):
 
         self.dut.send_expect("quit", "# ", 30)
 
-    def test_dynamic_rss_bond_config(self):
-        
-        # setup testpmd and finish bond config
-        self.verify(self.nic in ["columbiaville_25g", "columbiaville_100g","fortville_eagle", "fortville_spirit",
-                    "fortpark_TLV","fortpark_BASE-T", "fortville_25g", "carlsville", "foxville"],
-                    "NIC Unsupported: " + str(self.nic))
-
-        self.dut.send_expect("%s %s -- -i" % (self.path, self.eal_para), "testpmd> ", 120)
-        self.dut.send_expect("set promisc all off", "testpmd> ")
-        out = self.dut.send_expect("create bonded device 3 0", "testpmd> ", 30)
-        bond_device_id = int(re.search("port \d+", out).group().split(" ")[-1].strip())
-
-        self.dut.send_expect("add bonding slave 0 %d" % bond_device_id, "testpmd>", 30)
-        self.dut.send_expect("add bonding slave 1 %d" % bond_device_id, "testpmd>", 30)
-
-        # get slave device default rss hash algorithm
-        out = self.dut.send_expect("get_hash_global_config 0", "testpmd>")
-        slave0_hash_function = re.search("Hash function is .+", out).group().split(" ")[-1].strip()
-        out = self.dut.send_expect("get_hash_global_config 1", "testpmd>")
-        slave1_hash_function = re.search("Hash function is .+", out).group().split(" ")[-1].strip()
-        self.verify(slave0_hash_function == slave1_hash_function, "default hash function not match")
-
-        new_hash_function = ""
-        for hash_function in ["toeplitz", "simple_xor"]:
-            if slave0_hash_function[-3:].lower() != hash_function[-3:]:
-                new_hash_function = hash_function
-        # update slave 0 rss hash algorithm and get slave 0 and slave 1 rss new hash algorithm
-        self.dut.send_expect("set_hash_global_config 0 %s ipv4-other enable" % new_hash_function, "testpmd>")
-        out = self.dut.send_expect("get_hash_global_config 0", "testpmd>")
-        slave0_new_hash_function = re.search("Hash function is .+", out).group().split(" ")[-1].strip()
-        out = self.dut.send_expect("get_hash_global_config 1", "testpmd>")
-        slave1_new_hash_function = re.search("Hash function is .+", out).group().split(" ")[-1].strip()
-
-        self.verify(slave0_new_hash_function == slave1_new_hash_function, "bond slave auto sync hash function failed")
-        self.verify(slave0_new_hash_function[-3:].lower() == new_hash_function[-3:], "changed slave hash function failed")
-
-        self.dut.send_expect("remove bonding slave 0 %d" % bond_device_id, "testpmd>", 30)
-        self.dut.send_expect("remove bonding slave 1 %d" % bond_device_id, "testpmd>", 30)
-        self.dut.send_expect("quit","# ", 30)
-
     def tear_down(self):
         """
         Run after each test case.
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [dts][PATCH V1] tests/pmdrss_hash: remove case test_dynamic_rss_bond_config
  2021-11-12  2:50 [dts][PATCH V1] tests/pmdrss_hash: remove case test_dynamic_rss_bond_config Yu Jiang
@ 2021-11-23  6:45 ` Peng, Yuan
  0 siblings, 0 replies; 2+ messages in thread
From: Peng, Yuan @ 2021-11-23  6:45 UTC (permalink / raw)
  To: Jiang, YuX, dts

Acked-by Peng, Yuan <yuan.peng@intel.com>

-----Original Message-----
From: Jiang, YuX <yux.jiang@intel.com> 
Sent: Friday, November 12, 2021 10:51 AM
To: Peng, Yuan <yuan.peng@intel.com>; dts@dpdk.org
Cc: Jiang, YuX <yux.jiang@intel.com>
Subject: [dts][PATCH V1] tests/pmdrss_hash: remove case test_dynamic_rss_bond_config

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-23  6:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-12  2:50 [dts][PATCH V1] tests/pmdrss_hash: remove case test_dynamic_rss_bond_config Yu Jiang
2021-11-23  6:45 ` Peng, Yuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git