test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/ice_dcf_date_path: turn off promisc mode
@ 2022-05-19  1:55 Jiale Song
  2022-05-25 10:19 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Jiale Song @ 2022-05-19  1:55 UTC (permalink / raw)
  To: dts; +Cc: Jiale Song

DCF already supports promise mode, and it is started by default.
promisc should be turned off during the test.

According to dpdk commit cdfbcfa110a ("net/ice: support DCF promiscuous configuration")

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 tests/TestSuite_ice_dcf_date_path.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/TestSuite_ice_dcf_date_path.py b/tests/TestSuite_ice_dcf_date_path.py
index aad27f5b..21a0c875 100644
--- a/tests/TestSuite_ice_dcf_date_path.py
+++ b/tests/TestSuite_ice_dcf_date_path.py
@@ -283,6 +283,7 @@ class DcfDatePathTest(TestCase):
         )
 
         self.pmd_output.execute_cmd("set fwd rxonly")
+        self.pmd_output.execute_cmd("set promisc all off")
         self.pmd_output.execute_cmd("set verbose 1")
         self.pmd_output.execute_cmd("start")
         out = self.send_pkts_getouput(pkt, self.tester_intf0, status=True)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [dts] [PATCH V1] tests/ice_dcf_date_path: turn off promisc mode
  2022-05-19  1:55 [dts] [PATCH V1] tests/ice_dcf_date_path: turn off promisc mode Jiale Song
@ 2022-05-25 10:19 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2022-05-25 10:19 UTC (permalink / raw)
  To: Jiale, SongX, dts; +Cc: Jiale, SongX

> -----Original Message-----
> From: Jiale Song <songx.jiale@intel.com>
> Sent: 2022年5月19日 9:56
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: [dts] [PATCH V1] tests/ice_dcf_date_path: turn off promisc mode
> 
> DCF already supports promise mode, and it is started by default.
> promisc should be turned off during the test.
> 
> According to dpdk commit cdfbcfa110a ("net/ice: support DCF promiscuous configuration")
> 
> Signed-off-by: Jiale Song <songx.jiale@intel.com>

Test plan should be modified accordingly.

And is only this case impact? If yes, the reason should be put in the test plan too.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-05-25 10:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-19  1:55 [dts] [PATCH V1] tests/ice_dcf_date_path: turn off promisc mode Jiale Song
2022-05-25 10:19 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).