test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Jiale, SongX" <songx.jiale@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Jiale, SongX" <songx.jiale@intel.com>
Subject: RE: [dts] [PATCH V1] tests/queue_start_stop: optimize script
Date: Sun, 29 Jan 2023 02:13:49 +0000	[thread overview]
Message-ID: <CY5PR11MB618751839A99A0936CB599C1F5D29@CY5PR11MB6187.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230118154814.2109168-1-songx.jiale@intel.com>



> -----Original Message-----
> From: Song Jiale <songx.jiale@intel.com>
> Sent: Wednesday, January 18, 2023 11:48 PM
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: [dts] [PATCH V1] tests/queue_start_stop: optimize script
> 
> there is "#" in the echo after the "patch -p0" command of Linux is executed.
> this "#" is not the expected value, which will affect the subsequent tests.
> 
> Signed-off-by: Song Jiale <songx.jiale@intel.com>
> ---
>  tests/TestSuite_queue_start_stop.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_queue_start_stop.py
> b/tests/TestSuite_queue_start_stop.py
> index b6f4ba96..80baf8d6 100644
> --- a/tests/TestSuite_queue_start_stop.py
> +++ b/tests/TestSuite_queue_start_stop.py
> @@ -93,9 +93,9 @@ class TestQueueStartStop(TestCase):
>          """
>          try:
>              if on:
> -                self.dut.send_expect("patch -p0 < %s" % patch_dir, "#")
> +                self.dut.send_expect("patch -p0 < %s" % patch_dir, "[~|~\]]# ")
>              else:
> -                self.dut.send_expect("patch -p0 -R < %s" % patch_dir, "#")
> +                self.dut.send_expect("patch -p0 -R < %s" % patch_dir, "[~|~\]]# ")
>          except Exception as e:
>              raise ValueError("patch_hotfix_dpdk failure: %s" % e)

Applied, but it is not a good idea to apply a patch to change DPDK source code, even it is only a "printf" statement. 
Checking  queue statistics can be an alternative.

thanks


      reply	other threads:[~2023-01-29  2:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18 15:48 Song Jiale
2023-01-29  2:13 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY5PR11MB618751839A99A0936CB599C1F5D29@CY5PR11MB6187.namprd11.prod.outlook.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=songx.jiale@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).