* [dts] [PATCH V1] tests/shutdown_api: modify the command to adapt to the changes in ethtool
@ 2023-01-16 15:00 Song Jiale
2023-01-29 2:27 ` Tu, Lijuan
2023-03-07 6:22 ` lijuan.tu
0 siblings, 2 replies; 3+ messages in thread
From: Song Jiale @ 2023-01-16 15:00 UTC (permalink / raw)
To: dts; +Cc: Song Jiale
The ethtool after version 5.4 does not support changing the network card speed
when automatic negotiation is turned off. therefore, rm 'autoneg off' in script.
Signed-off-by: Song Jiale <songx.jiale@intel.com>
---
tests/TestSuite_shutdown_api.py | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index fc81c46a..9cd2b273 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -320,11 +320,6 @@ class TestShutdownApi(TestCase):
self.dut.destroy_sriov_vfs_by_port(self.used_dut_port)
self.used_dut_port = None
- for port in self.ports:
- self.dut.send_expect(
- "ethtool -s %s autoneg on " % self.dut.ports_info[port]["intf"], "#"
- )
-
self.bind_nic_driver(self.dut_ports, driver=self.used_driver or self.drivername)
if not self.vm_env_done:
@@ -629,7 +624,7 @@ class TestShutdownApi(TestCase):
for port in self.ports:
if len(configs) != 1:
self.dut.send_expect(
- "ethtool -s %s autoneg off speed %s duplex %s"
+ "ethtool -s %s speed %s duplex %s"
% (
self.dut.ports_info[port]["intf"],
config[0],
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [dts] [PATCH V1] tests/shutdown_api: modify the command to adapt to the changes in ethtool
2023-01-16 15:00 [dts] [PATCH V1] tests/shutdown_api: modify the command to adapt to the changes in ethtool Song Jiale
@ 2023-01-29 2:27 ` Tu, Lijuan
2023-03-07 6:22 ` lijuan.tu
1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2023-01-29 2:27 UTC (permalink / raw)
To: Jiale, SongX, dts; +Cc: Jiale, SongX
> -----Original Message-----
> From: Song Jiale <songx.jiale@intel.com>
> Sent: Monday, January 16, 2023 11:00 PM
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: [dts] [PATCH V1] tests/shutdown_api: modify the command to adapt to
> the changes in ethtool
>
> The ethtool after version 5.4 does not support changing the network card speed
> when automatic negotiation is turned off. therefore, rm 'autoneg off' in script.
Compatibility is very important.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [dts] [PATCH V1] tests/shutdown_api: modify the command to adapt to the changes in ethtool
2023-01-16 15:00 [dts] [PATCH V1] tests/shutdown_api: modify the command to adapt to the changes in ethtool Song Jiale
2023-01-29 2:27 ` Tu, Lijuan
@ 2023-03-07 6:22 ` lijuan.tu
1 sibling, 0 replies; 3+ messages in thread
From: lijuan.tu @ 2023-03-07 6:22 UTC (permalink / raw)
To: dts, Song Jiale; +Cc: Song Jiale
On Mon, 16 Jan 2023 15:00:02 +0000, Song Jiale <songx.jiale@intel.com> wrote:
> The ethtool after version 5.4 does not support changing the network card speed
> when automatic negotiation is turned off. therefore, rm 'autoneg off' in script.
>
>
> Signed-off-by: Song Jiale <songx.jiale@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-07 6:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-16 15:00 [dts] [PATCH V1] tests/shutdown_api: modify the command to adapt to the changes in ethtool Song Jiale
2023-01-29 2:27 ` Tu, Lijuan
2023-03-07 6:22 ` lijuan.tu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).