test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts][PATCH V1] tests/ieee1588: Add this test on ICE
@ 2022-12-29  9:28 Lingli Chen
  2023-01-04  1:27 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Lingli Chen @ 2022-12-29  9:28 UTC (permalink / raw)
  To: dts; +Cc: zhiminx.huang, Lingli Chen

According to dpdk commit f5ada3bcf12d (net/ice: fix mbuf offload flag for Rx timestamp)
add ieee1588_enable on ICE.

Signed-off-by: Lingli Chen <linglix.chen@intel.com>
---
 conf/test_case_checklist.json |  4 +---
 tests/TestSuite_ieee1588.py   | 12 +++++++++---
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json
index f88f5be1..14de236a 100644
--- a/conf/test_case_checklist.json
+++ b/conf/test_case_checklist.json
@@ -1285,9 +1285,7 @@
             "NIC": [
                 "IGB_1G-I210_COPPER",
                 "cavium_a034",
-                "cavium_0011",
-                "ICE_25G-E810C_SFP",
-                "ICE_100G-E810C_QSFP"
+                "cavium_0011"
             ],
             "Target": [
                 "ALL"
diff --git a/tests/TestSuite_ieee1588.py b/tests/TestSuite_ieee1588.py
index 300d85d4..8a43a8c2 100644
--- a/tests/TestSuite_ieee1588.py
+++ b/tests/TestSuite_ieee1588.py
@@ -37,9 +37,15 @@ class TestIeee1588(TestCase):
         # For IEEE1588, the full-feature tx path needs to be enabled.
         # Enabling any tx offload will force DPDK utilize full tx path.
         # Enabling multiple segment offload is more reasonable for user cases.
-        self.pmdout.start_testpmd(
-            "Default", " --tx-offloads=%s" % DEV_TX_OFFLOAD_MULTI_SEGS
-        )
+        if self.kdriver == "ice":
+            self.pmdout.start_testpmd(
+                "Default",
+                " --enable-rx-timestamp --tx-offloads=%s" % DEV_TX_OFFLOAD_MULTI_SEGS,
+            )
+        else:
+            self.pmdout.start_testpmd(
+                "Default", " --tx-offloads=%s" % DEV_TX_OFFLOAD_MULTI_SEGS
+            )
 
     def set_up(self):
         """
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [dts][PATCH V1] tests/ieee1588: Add this test on ICE
  2022-12-29  9:28 [dts][PATCH V1] tests/ieee1588: Add this test on ICE Lingli Chen
@ 2023-01-04  1:27 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2023-01-04  1:27 UTC (permalink / raw)
  To: Chen, LingliX, dts; +Cc: Huang, ZhiminX, Chen, LingliX

> -----Original Message-----
> From: Lingli Chen <linglix.chen@intel.com>
> Sent: Thursday, December 29, 2022 5:29 PM
> To: dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>; Chen, LingliX
> <linglix.chen@intel.com>
> Subject: [dts][PATCH V1] tests/ieee1588: Add this test on ICE
> 
> According to dpdk commit f5ada3bcf12d (net/ice: fix mbuf offload flag for Rx
> timestamp) add ieee1588_enable on ICE.
> 
> Signed-off-by: Lingli Chen <linglix.chen@intel.com>

Could you please also update test plan accordingly, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-04  1:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-29  9:28 [dts][PATCH V1] tests/ieee1588: Add this test on ICE Lingli Chen
2023-01-04  1:27 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).