From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB5BB42CB1; Wed, 14 Jun 2023 04:03:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AAA1F40E0F; Wed, 14 Jun 2023 04:03:20 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id F3A6D40DDB for ; Wed, 14 Jun 2023 04:03:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686708199; x=1718244199; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=oEzL3w3UpGaMN4llcZH0q2E6XBNL11WdmNJH+caCy8s=; b=T899V/16Y9FB6Z5KHV14dfHkizyuc/APThdicI+Jb9mexCjTfMhjvU7y jIc80mFfGj/ammboryLoHOFQogqED15SlNF+6/qMNTwCJZUWgpDQDNjXp kUX/uHGd5SaSsbtNyE3bFwacVaMWNrUSKUurzt/tSl+4i8MOL5kizRLIa WAfKNVoz2U/cAzasAoCe9OOlwZAYGwAxTcDT1orOLCpfQB6F6isaopaIQ /dozk9530+S8KPU+iH529qgx7Ni1FlDPvXHW8+XoI8MEBPQsAb6RYGjtt XH7DIM6oIxmD3WEcpwryJxky8bIlqWWVxQrsRZJY8r5CiAtGnm//cBtC8 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10740"; a="444872142" X-IronPort-AV: E=Sophos;i="6.00,241,1681196400"; d="scan'208";a="444872142" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2023 19:03:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10740"; a="1042003447" X-IronPort-AV: E=Sophos;i="6.00,241,1681196400"; d="scan'208";a="1042003447" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga005.fm.intel.com with ESMTP; 13 Jun 2023 19:03:17 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 13 Jun 2023 19:03:17 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 13 Jun 2023 19:03:16 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 13 Jun 2023 19:03:16 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 13 Jun 2023 19:03:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D3hjD0bVyH6it4CMXhWnuoZkP4ZhqV59W+TrEeRxl6oG/R4CaSQMmB3GxN0n02i3vsUtQ/yiIwtiYTaK3k4agFU5xUqwKCXX9mxB/ZCK3/m6HqCUvxSbDoSjuJTJO3mHGZGmbMbunE4hIIvqr6x9fh+a8ra0GQgrltFEkMXJATedMvtbIJdDhixa+8muZcbPAqtPi1m8cySnHGs/iTkAKU6cXiZ7DvrOPLfJ1ty3TT1dN1pLTgcGEJL5XKiFZcNfR/iUJ43XA+D7i3k6zOVngE+JgQ9DHqLY++JvoU5H6tCzISdTR9SJh9d+HB+5o1arMnvf8L1oaPOpMSB6HtrjHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZOlbVT6LVHSLzkV7p3FrRKzFSY3BHKlhUaXQ0Y+Hlvo=; b=PVsdMT3KnP32923N1JbVwfsMJW7vItrhWjIQau8WgUefpxX1JsOeoMu+gBa8W0Ijq8QdpeOZ/Gr1aU5nzYJuyxsB4V9K2Z4+zzta3IWsGbvnQ+mlA7NdheOme3wYlCtvl9NsM2U6IGw2uHJWfI1qkdzuJMixdJ0s23gw6cFZab8uPyzglzAD49GHhg3PdSj4n9GoIi499kQX8zX5t0h61Quow0ystdNWo2kb6dktsok1gJmOlBjTWK8iJcM0Gjlpdqo854GTagLZPbjaKNDSkTWmqUyppu8IrsTU/6W+CYI2DrGLFClHhX9gqFxGv80ZMGW1ZEfujGGaydmX1otU1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY5PR11MB6187.namprd11.prod.outlook.com (2603:10b6:930:25::11) by SA1PR11MB8595.namprd11.prod.outlook.com (2603:10b6:806:3a9::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.36; Wed, 14 Jun 2023 02:03:09 +0000 Received: from CY5PR11MB6187.namprd11.prod.outlook.com ([fe80::41b:9ed1:3c5e:32a9]) by CY5PR11MB6187.namprd11.prod.outlook.com ([fe80::41b:9ed1:3c5e:32a9%5]) with mapi id 15.20.6455.039; Wed, 14 Jun 2023 02:03:09 +0000 From: "Tu, Lijuan" To: "Huang, ZhiminX" , "dts@dpdk.org" CC: "Huang, ZhiminX" Subject: RE: [dts][PATCH V1 2/6] tests/kernelpf_vf:add new suite to cover most of the basic vf cases Thread-Topic: [dts][PATCH V1 2/6] tests/kernelpf_vf:add new suite to cover most of the basic vf cases Thread-Index: AQHZmfJQLTWdar/cFEamSP5z0ukZ3q+Jkr2w Date: Wed, 14 Jun 2023 02:03:08 +0000 Message-ID: References: <20230608182742.360594-1-zhiminx.huang@intel.com> <20230608182742.360594-3-zhiminx.huang@intel.com> In-Reply-To: <20230608182742.360594-3-zhiminx.huang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CY5PR11MB6187:EE_|SA1PR11MB8595:EE_ x-ms-office365-filtering-correlation-id: 8ce6448c-72ed-4650-02cc-08db6c7b7fe9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RrzZOfxB1T6FYpdSSwzEEd9ToGAEXc6nL0f/IkjPLZvNlg4WuYnV7BCOMqGkX+NR3X8kQjrHrHBI5tATOCXJOAno3kRr5+1mn37jTwRZZqciVmByPnTWTOrGph7UJXMUOHZF+UdfHGWqZJrlVrngCRogUGzpCQzshGyRWwMPcfDhEsNvbru80sroAsDVG6cLG0oEh3vfw5/5q+JlGRjdewXVeOf/5mgp+bgBUnlVY7Pyzbpfx0zwbhIHIbvPc/hE1Ola7ITwDNlo5ivaotxBagXWqVjQlGxKMGXx7C6nHSAsJ/8jcqN526Bu+29W3zQxAKNDxA2ZpBdSX0MATyaryqrdgH90YxP2TW9IcRyOS2qIGXJp/kcVnDdHQXcXubcwHcUi3XCL5hfXdDIIvaKgkExYb9CYu6cvyU1SR7NtlolPghpFcMJNSnRFlXDloLKQGE1TPVX8Kh6fWrlcThcL7KwNkF4oN7zbmiOa9WbOPCfavGgC+rBClR8jU8qe71kQ/SJHf1sHZiKd2ji7bgyRplY+5HLAgK9F4BkGNTWq1lEP06l3pfQXdWF7WpkoeEu43LvfvAtt1eYZDNo1S9W7X90lHw5WhkK82KB2KBdxJV8PLaNdK7ssUHz4dzcPvGpV x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY5PR11MB6187.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(39860400002)(136003)(366004)(346002)(376002)(451199021)(6506007)(33656002)(26005)(55016003)(83380400001)(5660300002)(107886003)(53546011)(41300700001)(9686003)(186003)(52536014)(8676002)(38100700002)(110136005)(66446008)(82960400001)(8936002)(71200400001)(478600001)(66476007)(66946007)(4326008)(66556008)(76116006)(64756008)(86362001)(122000001)(38070700005)(316002)(2906002)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wIzx52vrb/G7gZ7rlNLZFlABjAjILNGFsZCj5Z2RwGKCtvTWMMN6XQEfcrTE?= =?us-ascii?Q?GQ86D170bzq8XApZBBWI1KISJWJCO0yb9vkYDwQ8ycEtMLrMbC6kz6uBsZMF?= =?us-ascii?Q?oeME2DgxGIwoq+orlWMmHqwtkjBPIA5mrqJRKX7i5UXRUIxml8sKugkw8xmo?= =?us-ascii?Q?HsSCokA6mLWqJjQQyrGkkvmZWHIJji+UwHo4DGHUTrZieBNK6WvaeM/ivc6n?= =?us-ascii?Q?B96fPFmC2BxbcGpXKO3chkr6AMaG7Rc4MKkLUJPZwkE//NDeQiSZq/wzBxfv?= =?us-ascii?Q?YuxYCitOZgBfJoaStOjJKOSy905jxTpLgB6ut1zw2EkhI0GMACLq6VNkZ7/t?= =?us-ascii?Q?sbwquNb+DqPiM7pI2GIs6y+uGBmQOMYHxjA2j3PoKtSOBQD0t5VnA0Of83MZ?= =?us-ascii?Q?uKes5W6z77zF7NUu+B2JGh9iw9DOFVja20H3Q0umbNXv3qicmiP6RPOgyMli?= =?us-ascii?Q?94ENcNI8uBxNx/gBzkRX3+FREvD44XuS8eayGNMlmfPBJOVCZJ7TeYFKHalY?= =?us-ascii?Q?NmW1rjTpuabid+8dd5sIcp9Hob9p0gLVb+mU0vla/GHVbf1p6xkztPZDLH6K?= =?us-ascii?Q?657xnIJ/Gx5aVVPrGocjlvxZKxCePyImFYSGlSRpqzAOC6hI/uzjzO7ezM/L?= =?us-ascii?Q?t523LJ+kTQNlC9Qbbt1EB/IUMN5N7HcobbsMtcIhO67oKPdsywAnlWXlIcvY?= =?us-ascii?Q?sbSXmyorppSZO71ENB3a1qe5u4GY9ROsYWB+Fa6P6SCpmit8HQm6knRm/0Ad?= =?us-ascii?Q?Bi2tMr7wntFQwIyCeQH+wQ2xqEvyDOrylPYe+Hdc8MiOf0h4IU25YNPbViLZ?= =?us-ascii?Q?JIs05yNohYcjEMzli7F8hG7RGhqGzMwV14IwsClwJdt8HW019/H7v+Gub2Q4?= =?us-ascii?Q?mYvFEk7RtagpRbFiQKX15MWYSPgg+2FVsQIn8uxQgRt0qu2jgpSLeBI3I5rh?= =?us-ascii?Q?x/UqrwF33BW8jpAEl+wsNnNllS4T0/erTpL33sx0VTmOTQsIkP6ee3wZzqyn?= =?us-ascii?Q?IeleStHig7/fZBDgbkelt5MXU2XAclobiSOSFt45garZGjLlOruygZUS9qNG?= =?us-ascii?Q?P2ao1fidIQvvz0GvtQSk9PUz4jlH0rgqgN2PVuzqgPIUYnATkqCfT2QvKDIv?= =?us-ascii?Q?saKs7gjugh7JDMGQJFI/ih1h2GFtMm0AwDrxfzEUMsLtV2SjOaNqrPGruY/W?= =?us-ascii?Q?SfSvqXGm10CkuvGzlgwhZf8MPDR81T2AMm4YwWfl5MKo83nAe2RoTmqr8osR?= =?us-ascii?Q?9zDj5L54dH5jTGQrSpl1+D+gACYKplk2CYkfgWc3c7heHhKu6U/UiGsLzl59?= =?us-ascii?Q?NKL6ykKv9W8hiWyDtZEHp/MyzoZ+VULJNIOBBOSDcseFIxRGDRhTvv7SM9XS?= =?us-ascii?Q?c0akMazjXiybWiQicASO1eNVpjKqKbm27wZ1tSsKcfT0jbXo8L0qGIbH9mIE?= =?us-ascii?Q?76wQcw2lAYGCMOq3FokDgEJS1LcRv82NMtLFx6yGfvIpjTQO5U2l3uxpRpot?= =?us-ascii?Q?GFE2iWe4nWBVsQiihASVJtT2/AXhP+kfbgJX9VBwlBkwfLwS124Bv9OYhHEa?= =?us-ascii?Q?7ehtWQosuRdTxAn5K8YP/OHMdte3ScptfwxOqKOR?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6187.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ce6448c-72ed-4650-02cc-08db6c7b7fe9 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2023 02:03:08.5680 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Benrer7oiKHE529jGdwH3STmYdkVxRbPSAaEMKmbS3iikodbHZd8PGQ0nBHhAVS5qhTjoiz26q4q8Zy+2+2thA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8595 X-OriginatorOrg: intel.com X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org > -----Original Message----- > From: Zhimin Huang > Sent: Friday, June 9, 2023 2:28 AM > To: dts@dpdk.org > Cc: Huang, ZhiminX > Subject: [dts][PATCH V1 2/6] tests/kernelpf_vf:add new suite to cover mos= t of > the basic vf cases >=20 > add kernelpf_vf new suite and refactor with func_test_base common module: > cover kernelpf_iavf/vf_vlan/vf_macfilter/vf_rss/vf_xstats_check. >=20 > Signed-off-by: Zhimin Huang > --- > tests/TestSuite_kernelpf_vf.py | 1007 ++++++++++++++++++++++++++++++++ > 1 file changed, 1007 insertions(+) > create mode 100644 tests/TestSuite_kernelpf_vf.py >=20 ...... > + > + def test_vf_multicast(self): > + self.rxtx_base.launch_testpmd() > + self.rxtx_base.basic_multicast_check( > + normal_mac=3DVF_MAC_ADDR, multicast_mac=3DMULTICAST_MAC_ADDR > + ) > + > + def test_vf_broadcast(self): > + self.rxtx_base.launch_testpmd() > + self.rxtx_base.basic_rx_check(packets_num=3D1, > + packet_dst_mac=3DBROADCAST_MAC_ADDR) I don't think it is a good idea to launch testpmd in every single case. It = costs a lot of time.=20 A good suite and cases organization could avoid this and save a lot of exec= ution time. 1. adjust test cases that could use same args for testpmd. 2. separate those testpmd with different args to other suites. > + > + def test_vf_queue_start_stop(self): > + self.rxtx_base.launch_testpmd() > + self.rxtx_base.basic_macfwd_check( > + packet_num=3D4, dst_mac=3DVF_MAC_ADDR, > rx_port=3Dself.used_dut_rx_port > + ) > + packets_captured, _, stats =3D self.rxtx_base.execute_fwd_check_= process( > + packets=3Dself.rxtx_base.generate_random_packets( > + dstmac=3DVF_MAC_ADDR, pktnum=3D4 > + ), > + rx_port=3Dself.used_dut_rx_port, > + pmd_commands=3D["stop", "port 0 rxq 0 stop", "start"], > + ) > + self.verify( > + len(packets_captured) =3D=3D 0 > + and stats[self.used_dut_rx_port]["TX-packets"] =3D=3D 0, > + "receive packet num is not match", > + ) > + packets_captured, _, stats =3D self.rxtx_base.execute_fwd_check_= process( > + packets=3Dself.rxtx_base.generate_random_packets( > + dstmac=3DVF_MAC_ADDR, pktnum=3D4 > + ), > + rx_port=3Dself.used_dut_rx_port, > + pmd_commands=3D["stop", "port 0 rxq 0 start", "port 1 txq 0 = stop", > "start"], > + ) > + self.verify( > + len(packets_captured) =3D=3D 0 > + and stats[self.used_dut_rx_port]["TX-packets"] =3D=3D 0, > + "receive packet num is not match", > + ) > + self.rxtx_base.basic_macfwd_check( > + packet_num=3D4, > + dst_mac=3DVF_MAC_ADDR, > + rx_port=3Dself.used_dut_rx_port, > + pmd_commands=3D["stop", "port 1 txq 0 start", "start"], > + ) > +