From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40048.outbound.protection.outlook.com [40.107.4.48]) by dpdk.org (Postfix) with ESMTP id E67CCF04 for ; Fri, 21 Sep 2018 09:32:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gQDS2FN7nUuHMxfmuH+Lvw+ufaqhSYrTh2bhcaeN9b8=; b=cTeVuqCZngTk/qKFkJHUuBVc818e7huW43JEhXqPHCbwMCfIRv6BBJoGz35o4Le2gXsk8D0HH9HDv1JDvE1uZatuKaJ05oCHPE1LOitDukvX3EmGxxMIRQikrN8x+Yg5hpCmXRgPGWD13KEgBrRg0rCaNlEw+Vor+FAGHe0e9Xs= Received: from DB7PR08MB3385.eurprd08.prod.outlook.com (20.176.238.90) by DB7PR08MB3580.eurprd08.prod.outlook.com (20.177.120.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.18; Fri, 21 Sep 2018 07:32:18 +0000 Received: from DB7PR08MB3385.eurprd08.prod.outlook.com ([fe80::f0e6:1c3d:9285:472f]) by DB7PR08MB3385.eurprd08.prod.outlook.com ([fe80::f0e6:1c3d:9285:472f%3]) with mapi id 15.20.1143.017; Fri, 21 Sep 2018 07:32:18 +0000 From: "Phil Yang (Arm Technology China)" To: "Tu, Lijuan" , "Phil@dpdk.org" , "dts@dpdk.org" CC: nd , "Liu, Yong" Thread-Topic: [dts] [PATCH v5 01/22] framework/packet: support packet sniffer to specify running machine Thread-Index: AQHUUViHHgNaAboMz0qWfdwdCXAIRaT6D6MggAAHsICAAC7jYIAADe8AgAADFcA= Date: Fri, 21 Sep 2018 07:32:18 +0000 Message-ID: References: <1523526771-7437-1-git-send-email-phil.yang@arm.com> <1536049595-22271-1-git-send-email-phil.yang@arm.com> <8CE3E05A3F976642AAB0F4675D0AD20EEC707E@SHSMSX101.ccr.corp.intel.com> <8CE3E05A3F976642AAB0F4675D0AD20EEC70F7@SHSMSX101.ccr.corp.intel.com> <8CE3E05A3F976642AAB0F4675D0AD20EEC829E@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <8CE3E05A3F976642AAB0F4675D0AD20EEC829E@SHSMSX101.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Phil.Yang@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR08MB3580; 6:+tvLxrL8oJOPXciaeA/cT1DCKsL9WqE93oZKyrVo6tq+HCWCysndPFVJmAPNLDVj14wQ8I8dwiNxVg8F7vU5g2mBXNnlZrydhPhY751R9+H/ANaNovHQ7bg5pCgq8KCyPr9e1kiy9/uhKWpW05bAtzfRO/ASUf/Gdy/QUH9FijUIIJvIPABCw2c3cMoAaAUFHZ7uBYQHHYnOi6zErGBrapsAlAcEbG5o+enQdZaAp5MDKA0NV9LEukrpR6IisGS0D7Jkx5vN30bCKNE6+w01NBu8V6+GNrkS0ju0sjOFg7aciiFHrPZJSmv1PcMlmeJuLCJhCsn1Ofx4aRALcX2hX4MsiLsKtvv2UTLkL4yHVrVv7ca1t8bwJoMbOBsARxDAXzCUzC48G14ptkktYlcONK6/EJuTm3vknNiax0jrWHOYRbaZ1PoZEYJMsx4Aezo/SHbl/9UlAVhFIxzWihqQDw==; 5:sxoEs4gT6pPTWL54ITUXStrUWt1S26uXXSHWLSuL5QcSM4ohPJCXpohXxwPWSVx0A15NCdIeEH1lYwZPu3y67EFN3RYtyCVzQgYX9KApdr+tL+mMKsZpftXV1NUuqFIl6iHnYzA7CKSETQX7ZtZXQtDvg+kCyfXr/+y8mn2rGwU=; 7:x5ifVlPXNcJCf/HEv13CM6wevXGY7I8mv8k/O/RwKmMjXYJMVaHWw3Ri1fo9LzailkR1Q2L2y4+go0MoFhUJrNtJe4AqSaTSViTbQeYP97TPdZ48E8kYEqOm/fSuZMOr84qbqbMF7BTJt4MNLSVpPCA4NtFC0Rj2Wd0dONv5lsN3O4YVH2s8LOyEw26d+45eJx7v4jNnLpsA7mq7Aqe1GuivowiAnhOsbNiAbGJMlvqiG3AbK2CXcQ9JUStH0/nK x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: c11d5e99-95c7-4a7e-6896-08d61f945c95 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR08MB3580; x-ms-traffictypediagnostic: DB7PR08MB3580: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(158342451672863)(180628864354917)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(201708071742011)(7699051); SRVR:DB7PR08MB3580; BCL:0; PCL:0; RULEID:; SRVR:DB7PR08MB3580; x-forefront-prvs: 0802ADD973 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(366004)(39860400002)(376002)(346002)(136003)(189003)(199004)(13464003)(6436002)(305945005)(54906003)(6116002)(72206003)(6246003)(11346002)(966005)(476003)(446003)(486006)(3846002)(14454004)(86362001)(2501003)(5250100002)(316002)(551544002)(81156014)(71190400001)(8936002)(97736004)(21490400003)(74316002)(106356001)(71200400001)(110136005)(2201001)(81166006)(7736002)(53546011)(68736007)(102836004)(186003)(6506007)(478600001)(53936002)(7696005)(99286004)(26005)(256004)(4326008)(33656002)(105586002)(2906002)(93886005)(5660300001)(53946003)(6306002)(25786009)(9686003)(55016002)(66066001)(14444005)(229853002)(2900100001)(76176011); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR08MB3580; H:DB7PR08MB3385.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: IVvGo7oY/jBbS+l9R7FR8rO+g8NpzqSQrWSsMOjkDZfjw0iXI1BrvhzvHdHSEQluvB3mYp2+jSPpD5zZxG+h/vkvy1DDNs3816XiNTT1KpyySwcKQFWfmJlOkVw6D8Zuhj+DqOBVS6vG1X1V9CbdQusA2cmtdnAoICMw4WLJCz2CKfuxNccs+TQJ5IRhi+lSOM59/NKe31a3Y6uJuhLfMliN5824CQrPJI4mZNpBwNiH6/7K9P5MImi6riATsGMPl3DeKjQGJjUUAqVqQ2yb5aJA0nRoPuXYwlBnSjnFgDGfIiJH/LrwR+WdMU+F1Qq8nji03dkwvgY1WxV724bedlohAXTBNw2MpBcz8RWZryw= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: c11d5e99-95c7-4a7e-6896-08d61f945c95 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2018 07:32:18.7149 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3580 Subject: Re: [dts] [PATCH v5 01/22] framework/packet: support packet sniffer to specify running machine X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2018 07:32:20 -0000 tcpdump_sniff_packet and load_tcpdump_sniff_pcap in class Tester will call = those two functions. def tcpdump_sniff_packets(self, intf, count=3D0, timeout=3D5, filters= =3D[]): """ Wrapper for packet module sniff_packets """ # load functions in packet module module =3D __import__("packet") sniff_f =3D getattr(module, "sniff_packets") target=3D[] target.append(self.get_username()) target.append(self.get_ip_address()) target.append(self.get_password()) return sniff_f(intf, count, timeout, filters, target) Please check test.py in this patch. Thanks, Phil Yang > -----Original Message----- > From: Tu, Lijuan > Sent: Friday, September 21, 2018 3:19 PM > To: Phil Yang (Arm Technology China) ; Phil@dpdk.org; > dts@dpdk.org > Cc: nd ; Liu, Yong > Subject: RE: [dts] [PATCH v5 01/22] framework/packet: support packet snif= fer to > specify running machine >=20 > I am glad we reach an agreement. >=20 > Of course, the parameter "target" have password, but I found no any funct= ion > would call it. > Only username and ip are used. The target[2] is the password, and is not = called. > + if target: > + tcpdump_help_pipe =3D subprocess.Popen(["ssh", > + "%s@%s" % (target[0], target[1]), > + "tcpdump -h"], > + stderr=3Dsubprocess.PIPE, > + stdout=3Dsubprocess.PIPE, > + shell=3DFalse) > Anything I missed? >=20 >=20 > > -----Original Message----- > > From: Phil Yang (Arm Technology China) [mailto:Phil.Yang@arm.com] > > Sent: Friday, September 21, 2018 2:59 PM > > To: Tu, Lijuan ; Phil@dpdk.org; dts@dpdk.org > > Cc: nd ; Liu, Yong > > Subject: RE: [dts] [PATCH v5 01/22] framework/packet: support packet > > sniffer to specify running machine > > > > Yes. I agreed with that. > > > > I think my patch has also followed this rule. > > In the packet.py, I added one more parameter "target" for > > sniff_packets and load_sniff_pcap to specify the username and IP addres= s. > > In the test.py, I passed the Tester's passwd and IP address to these > > two functions. Thus, it will make sure sniff packet operation done on t= he > Tester. > > > > Thanks, > > Phil Yang > > > > > -----Original Message----- > > > From: Tu, Lijuan > > > Sent: Friday, September 21, 2018 11:42 AM > > > To: Phil Yang (Arm Technology China) ; > > > Phil@dpdk.org; dts@dpdk.org > > > Cc: nd ; Liu, Yong > > > Subject: RE: [dts] [PATCH v5 01/22] framework/packet: support packet > > > sniffer to specify running machine > > > > > > DTS supports either login server by password or utilize authorized l= ogin. > > > For logging by password, we could get some codes like " self.session > > > =3D SSHPexpect(host, username, password, dut_id) " in SSHConnection > > > module. and we have ip, username, password information in crb.cfg I > > > think we don't want to force user to utilize authorized login. > > > > > > > -----Original Message----- > > > > From: Phil Yang (Arm Technology China) [mailto:Phil.Yang@arm.com] > > > > Sent: Friday, September 21, 2018 11:22 AM > > > > To: Tu, Lijuan ; Phil@dpdk.org; dts@dpdk.org > > > > Cc: nd ; Liu, Yong > > > > Subject: RE: [dts] [PATCH v5 01/22] framework/packet: support > > > > packet sniffer to specify running machine > > > > > > > > Hi Lijuan, > > > > > > > > It also need to follow the DTS setup steps in > > > > https://doc.dpdk.org/dts/gsg/sys_reqs.html#authorized-login-session= . > > > > > > > > Since you know where are your DUT and Tester, so you can use tool > > > > ssh-copy-id to save local available keys on DUT and Tester. > > > > > > > > Thanks, > > > > Phil Yang > > > > > > > > > -----Original Message----- > > > > > From: Tu, Lijuan > > > > > Sent: Friday, September 21, 2018 11:09 AM > > > > > To: Phil@dpdk.org; dts@dpdk.org > > > > > Cc: nd ; Liu, Yong ; Phil Yang > > > > > (Arm Technology China) > > > > > Subject: RE: [dts] [PATCH v5 01/22] framework/packet: support > > > > > packet sniffer to specify running machine > > > > > > > > > > One comments, when we ssh to a server, it might request a > > > > > password, but we don't handle it. > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of > > > > > > Phil@dpdk.org > > > > > > Sent: Tuesday, September 4, 2018 4:26 PM > > > > > > To: dts@dpdk.org > > > > > > Cc: nd@arm.com; Liu, Yong ; Phil Yang > > > > > > > > > > > > Subject: [dts] [PATCH v5 01/22] framework/packet: support > > > > > > packet sniffer to specify running machine > > > > > > > > > > > > From: Phil Yang > > > > > > > > > > > > By default, the Tester is supposed to be the server which > > > > > > running DTS and the packet sniff methods are running on it. > > > > > > However, if DTS was not running on the Tester and the Tester > > > > > > is another remote server, so packet sniff methods cannot sniff > > > > > > Tester's packets correctly. > > > > > > > > > > > > This patch adds support for packet sniff methods to specify > > > > > > running machine and implements sniff packet methods in class te= ster. > > > > > > > > > > > > 1. Add parameter to sniff_packet and load_sniff_pcap methods > > > > > > to specify the running machine. > > > > > > 2. Remove load_sniff_packets method in packet.py. > > > > > > 3. Add tcpdump_sniff_packets, load_tcpdump_sniff_pcap and > > > > > > load_tcpdump_sniff_packets for class tester with the new > > > > > > sniff_packet > > > > API. > > > > > > 4. Update tester.check_random_pkts method with > > > > > > tester.tcpdump_sniff_packets and > > > > > > tester.load_tcpdump_sniff_packets to make it execution on the > > Tester. > > > > > > > > > > > > Signed-off-by: Phil Yang > > > > > > Suggested-by: Marvin Liu > > > > > > --- > > > > > > framework/packet.py | 86 > > > > > > +++++++++++++++++++++++++---------------------------- > > > > > > framework/tester.py | 48 +++++++++++++++++++++++++++--- > > > > > > 2 files changed, 84 insertions(+), 50 deletions(-) > > > > > > > > > > > > diff --git a/framework/packet.py b/framework/packet.py index > > > > > > 976b82b..1f3f07d 100755 > > > > > > --- a/framework/packet.py > > > > > > +++ b/framework/packet.py > > > > > > @@ -812,15 +812,31 @@ def get_filter_cmd(filters=3D[]): > > > > > > return "" > > > > > > > > > > > > > > > > > > -def sniff_packets(intf, count=3D0, timeout=3D5, filters=3D[]): > > > > > > +def sniff_packets(intf, count=3D0, timeout=3D5, filters=3D[], = target=3D[]): > > > > > > """ > > > > > > sniff all packets for certain port in certain seconds > > > > > > """ > > > > > > param =3D "" > > > > > > direct_param =3D r"(\s+)\[ (\S+) in\|out\|inout \]" > > > > > > - tcpdump_help =3D subprocess.check_output("tcpdump -h; echo > > 0", > > > > > > - > > > > > > stderr=3Dsubprocess.STDOUT, > > > > > > - shell=3DTrue) > > > > > > + remote_terminate =3D 0 > > > > > > + > > > > > > + # target[] contain the remote machine info for ssh connect= ion > > > > > > + # target[0]: username > > > > > > + # target[1]: ip address > > > > > > + # target[2]: pass word > > > > > > + if target: > > > > > > + tcpdump_help_pipe =3D subprocess.Popen(["ssh", > > > > > > + "%s@%s" % (target[0], target[1]), > > > > > > + "tcpdump -h"], > > > > > > + stderr=3Dsubprocess.PIPE, > > > > > > + stdout=3Dsubprocess.PIPE, > > > > > > + shell=3DFalse) > > > > > [Lijuan] Action will be blocked if SSH need password. > > > > > > + tcpdump_help =3D > > > > > > "".join(tuple(tcpdump_help_pipe.communicate())) > > > > > > + tcpdump_help_pipe.wait() > > > > > > + else: > > > > > > + tcpdump_help =3D subprocess.check_output("tcpdump -h; > > > > > > + echo > > > > 0", > > > > > > + > > > > stderr=3Dsubprocess.STDOUT, > > > > > > + shell=3DTrue) > > > > > > + > > > > > > for line in tcpdump_help.split('\n'): > > > > > > m =3D re.match(direct_param, line) > > > > > > if m: > > > > > > @@ -850,22 +866,29 @@ def sniff_packets(intf, count=3D0, > > > > > > timeout=3D5, > > > > > > filters=3D[]): > > > > > > else: > > > > > > cmd =3D sniff_cmd % options > > > > > > > > > > > > - args =3D shlex.split(cmd) > > > > > > + if target: > > > > > > + pipe =3D subprocess.Popen(['ssh', > > > > > > + '%s@%s' % (target[0], target[1]), cmd], > > > > > > + stdin=3Dsubprocess.PIPE, > > > > > > + shell=3DFalse) > > > > > > + remote_terminate =3D 1 > > > > > > + else: > > > > > > + args =3D shlex.split(cmd) > > > > > > + pipe =3D subprocess.Popen(args) > > > > > > > > > > > > - pipe =3D subprocess.Popen(args) > > > > > > index =3D str(time.time()) > > > > > > - SNIFF_PIDS[index] =3D (pipe, intf, timeout) > > > > > > + SNIFF_PIDS[index] =3D (pipe, intf, timeout, > > > > > > + remote_terminate) > > > > > > time.sleep(1) > > > > > > return index > > > > > > > > > > > > > > > > > > -def load_sniff_pcap(index=3D''): > > > > > > +def load_sniff_pcap(index=3D'', target=3D[]): > > > > > > """ > > > > > > Stop sniffer and return pcap file > > > > > > """ > > > > > > child_exit =3D False > > > > > > if index in SNIFF_PIDS.keys(): > > > > > > - pipe, intf, timeout =3D SNIFF_PIDS[index] > > > > > > + pipe, intf, timeout, remote_terminate =3D > > > > > > + SNIFF_PIDS[index] > > > > > > time_elapse =3D int(time.time() - float(index)) > > > > > > while time_elapse < timeout: > > > > > > if pipe.poll() is not None: > > > > > > @@ -876,6 +899,14 @@ def load_sniff_pcap(index=3D''): > > > > > > time_elapse +=3D 1 > > > > > > > > > > > > if not child_exit: > > > > > > + if remote_terminate =3D=3D 1: > > > > > > + stop_tcpdump_pipe =3D subprocess.Popen(['ssh', > > > > > > + '%s@%s' % (target[0], > > > > > > target[1]), > > > > > > + 'kill -2 $(pidof > > tcpdump)'], > > > > > > + stderr=3Dsubprocess.PIPE, > > > > > > + shell=3DFalse) > > > > > > + stop_tcpdump_pipe.wait() > > > > > > + > > > > > > pipe.send_signal(signal.SIGINT) > > > > > > pipe.wait() > > > > > > > > > > > > @@ -886,42 +917,6 @@ def load_sniff_pcap(index=3D''): > > > > > > return "" > > > > > > > > > > > > > > > > > > -def load_sniff_packets(index=3D''): > > > > > > - """ > > > > > > - Stop sniffer and return packet objects > > > > > > - """ > > > > > > - pkts =3D [] > > > > > > - child_exit =3D False > > > > > > - if index in SNIFF_PIDS.keys(): > > > > > > - pipe, intf, timeout =3D SNIFF_PIDS[index] > > > > > > - time_elapse =3D int(time.time() - float(index)) > > > > > > - while time_elapse < timeout: > > > > > > - if pipe.poll() is not None: > > > > > > - child_exit =3D True > > > > > > - break > > > > > > - > > > > > > - time.sleep(1) > > > > > > - time_elapse +=3D 1 > > > > > > - > > > > > > - if not child_exit: > > > > > > - pipe.send_signal(signal.SIGINT) > > > > > > - pipe.wait() > > > > > > - > > > > > > - # wait pcap file ready > > > > > > - time.sleep(1) > > > > > > - try: > > > > > > - cap_pkts =3D rdpcap("/tmp/sniff_%s.pcap" % intf) > > > > > > - for pkt in cap_pkts: > > > > > > - # packet gen should be scapy > > > > > > - packet =3D Packet(tx_port=3Dintf) > > > > > > - packet.pktgen.assign_pkt(pkt) > > > > > > - pkts.append(packet) > > > > > > - except: > > > > > > - pass > > > > > > - > > > > > > - return pkts > > > > > > - > > > > > > - > > > > > > def load_pcapfile(filename=3D""): > > > > > > pkts =3D [] > > > > > > try: > > > > > > @@ -983,7 +978,6 @@ if __name__ =3D=3D "__main__": > > > > > > inst =3D sniff_packets("lo", timeout=3D5) > > > > > > pkt =3D Packet(pkt_type=3D'UDP') > > > > > > pkt.send_pkt(tx_port=3D'lo') > > > > > > - pkts =3D load_sniff_packets(inst) > > > > > > > > > > > > pkt =3D Packet(pkt_type=3D'UDP', pkt_len=3D1500, > > ran_payload=3DTrue) > > > > > > pkt.send_pkt(tx_port=3D'lo') diff --git > > > > > > a/framework/tester.py b/framework/tester.py index > > > > > > a775f68..c5b705d 100755 > > > > > > --- a/framework/tester.py > > > > > > +++ b/framework/tester.py > > > > > > @@ -35,6 +35,7 @@ Interface for bulk traffic generators. > > > > > > > > > > > > import re > > > > > > import subprocess > > > > > > +import os > > > > > > from time import sleep > > > > > > from settings import NICS, load_global_setting, PERF_SETTING > > > > > > from crb import Crb @@ -560,8 +561,6 @@ class Tester(Crb): > > > > > > module =3D __import__("packet") > > > > > > pkt_c =3D getattr(module, "Packet") > > > > > > send_f =3D getattr(module, "send_packets") > > > > > > - sniff_f =3D getattr(module, "sniff_packets") > > > > > > - load_f =3D getattr(module, "load_sniff_packets") > > > > > > compare_f =3D getattr(module, "compare_pktload") > > > > > > strip_f =3D getattr(module, "strip_pktload") > > > > > > save_f =3D getattr(module, "save_packets") @@ -606,7 > > > > > > +605,7 @@ class Tester(Crb): > > > > > > > > > > > > # send and sniff packets > > > > > > save_f(pkts=3Dpkts, filename=3D"/tmp/%s_tx.pcap" % > > txIntf) > > > > > > - inst =3D sniff_f(intf=3DrxIntf, count=3Dpktnum, > > > > timeout=3Dtimeout, > > > > > > filters=3D > > > > > > + inst =3D self.tcpdump_sniff_packets(intf=3DrxIntf, > > > > > > + count=3Dpktnum, timeout=3Dtimeout, filters=3D > > > > > > [{'layer': 'network', 'config': {'srcport': '6= 5535'}}, > > > > > > {'layer': 'network', 'config': {'dstport': > > '65535'}}]) > > > > > > rx_inst[rxport] =3D inst @@ -627,7 +626,7 @@ class > > > > > > Tester(Crb): > > > > > > # Verify all packets > > > > > > prev_id =3D -1 > > > > > > for txport, rxport in portList: > > > > > > - recv_pkts =3D load_f(rx_inst[rxport]) > > > > > > + recv_pkts =3D > > > > > > + self.load_tcpdump_sniff_packets(rx_inst[rxport]) > > > > > > > > > > > > # only report when recevied number not matched > > > > > > if len(tx_pkts[txport]) > len(recv_pkts): > > > > > > @@ -704,6 +703,47 @@ class Tester(Crb): > > > > > > self.proc.kill() > > > > > > self.proc =3D None > > > > > > > > > > > > + def tcpdump_sniff_packets(self, intf, count=3D0, timeout= =3D5, > > > > filters=3D[]): > > > > > > + """ > > > > > > + Wrapper for packet module sniff_packets > > > > > > + """ > > > > > > + # load functions in packet module > > > > > > + module =3D __import__("packet") > > > > > > + sniff_f =3D getattr(module, "sniff_packets") > > > > > > + > > > > > > + target=3D[] > > > > > > + target.append(self.get_username()) > > > > > > + target.append(self.get_ip_address()) > > > > > > + target.append(self.get_password()) > > > > > > + return sniff_f(intf, count, timeout, filters, target) > > > > > > + > > > > > > + def load_tcpdump_sniff_pcap(self, index=3D''): > > > > > > + """ > > > > > > + Wrapper for packet module load_sniff_pcap > > > > > > + """ > > > > > > + # load functions in packet module > > > > > > + module =3D __import__("packet") > > > > > > + load_pcap_f =3D getattr(module, "load_sniff_pcap") > > > > > > + > > > > > > + target=3D[] > > > > > > + target.append(self.get_username()) > > > > > > + target.append(self.get_ip_address()) > > > > > > + target.append(self.get_password()) > > > > > > + pcap =3D load_pcap_f(index, target) > > > > > > + self.session.copy_file_from(pcap) > > > > > > + > > > > > > + return pcap.split(os.sep)[-1] > > > > > > + > > > > > > + def load_tcpdump_sniff_packets(self, index=3D''): > > > > > > + """ > > > > > > + Wrapper for packet module load_pcapfile > > > > > > + """ > > > > > > + # load functions in packet module > > > > > > + packet =3D __import__("packet") > > > > > > + file =3D self.load_tcpdump_sniff_pcap(index) > > > > > > + > > > > > > + return packet.load_pcapfile(file) > > > > > > + > > > > > > def kill_all(self, killall=3DFalse): > > > > > > """ > > > > > > Kill all scapy process or DPDK application on tester. > > > > > > -- > > > > > > 2.7.4