test suite reviews and discussions
 help / color / mirror / Atom feed
From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: David Marchand <david.marchand@redhat.com>,
	"Peng, Yuan" <yuan.peng@intel.com>
Cc: "An, XiangX" <xiangx.an@intel.com>, "dts@dpdk.org" <dts@dpdk.org>,
	"techboard@dpdk.org" <techboard@dpdk.org>,
	"Juraj Linkeš" <juraj.linkes@pantheon.tech>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"Lijuan Tu" <lijuan.tu@intel.com>, nd <nd@arm.com>,
	"Honnappa Nagarahalli" <Honnappa.Nagarahalli@arm.com>,
	nd <nd@arm.com>
Subject: Re: [dts] [PATCH V5 0/2] tests/rss_gtpogre: add a new case to PF and VF gtpogre
Date: Mon, 7 Jun 2021 19:41:15 +0000	[thread overview]
Message-ID: <DBAPR08MB581479581779B9170B4A4F5E98389@DBAPR08MB5814.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8x=_-Ja=PhaW+6aLiYBN2g=ttQRJ0z1EfDmRDeE+5uKMQ@mail.gmail.com>

+ Lijuan

<snip>

> 
> On Mon, Jun 7, 2021 at 8:33 AM Peng, Yuan <yuan.peng@intel.com> wrote:
> >
> > Acked-by Peng, Yuan <yuan.peng@intel.com>
> 
> NAK on this series.
> Please, stop changing DPDK sources in the test tool.
+1

Hi Yuan/An,
	I am not sure if you are aware of a DTS WG that the Techboard has setup. The goal of this WG is to find a path to make it mandatory to submit a DTS test case along with the patches to DPDK. One ask from this WG is that the test case should not modify the DPDK code to ensure we are testing a sane code base.

While writing the test case, please think if the DPDK code lacks something which would benefit overall. You could submit such as patch to the DPDK community rather than changing the code in DTS. You could also submit a bug report which the community can look into.

If you need more info, Lijuan from Intel is involved in this WG, she can provide more information.

Thank you,
Honnappa

> 
> 
> --
> David Marchand


      reply	other threads:[~2021-06-16  6:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-07  6:31 Xiang An
2021-06-07  6:31 ` [dts] [PATCH V5 1/2] tests/cvl_advanced_rss_gtpogre: add case parse_pfcp_over_gre_packet Xiang An
2021-06-09  7:04   ` Tu, Lijuan
2021-06-07  6:31 ` [dts] [PATCH V5 2/2] tests/cvl_advanced_iavf_rss_gtpogre: " Xiang An
2021-06-07  6:33 ` [dts] [PATCH V5 0/2] tests/rss_gtpogre: add a new case to PF and VF gtpogre Peng, Yuan
2021-06-07  9:01   ` David Marchand
2021-06-07 19:41     ` Honnappa Nagarahalli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DBAPR08MB581479581779B9170B4A4F5E98389@DBAPR08MB5814.eurprd08.prod.outlook.com \
    --to=honnappa.nagarahalli@arm.com \
    --cc=david.marchand@redhat.com \
    --cc=dts@dpdk.org \
    --cc=juraj.linkes@pantheon.tech \
    --cc=lijuan.tu@intel.com \
    --cc=nd@arm.com \
    --cc=techboard@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=xiangx.an@intel.com \
    --cc=yuan.peng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).