test suite reviews and discussions
 help / color / mirror / Atom feed
From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: David Marchand <david.marchand@redhat.com>,
	Wei Ling <weix.ling@intel.com>
Cc: "dts@dpdk.org" <dts@dpdk.org>, "Tu, Lijuan" <lijuan.tu@intel.com>,
	nd <nd@arm.com>
Subject: RE: [dts][PATCH V1 3/3] tests/dpdk_gro_lib_cbdma: add dpdk_gro_lib_cbdma testsuite
Date: Mon, 9 May 2022 19:15:25 +0000
Message-ID: <DBAPR08MB5814EA39DB2F22D9BFC269C098C69@DBAPR08MB5814.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8zs-pkYLWPz2R2bpM6TLupNDeP6u7unNWS+nBTbzS7kMg@mail.gmail.com>



> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Monday, May 9, 2022 1:52 AM
> To: Wei Ling <weix.ling@intel.com>
> Cc: dts@dpdk.org; Tu, Lijuan <lijuan.tu@intel.com>; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>
> Subject: Re: [dts][PATCH V1 3/3] tests/dpdk_gro_lib_cbdma: add
> dpdk_gro_lib_cbdma testsuite
> 
> On Sat, May 7, 2022 at 10:44 AM Wei Ling <weix.ling@intel.com> wrote:
> > +    def prepare_dpdk(self):
> > +        # Changhe the testpmd checksum fwd code for mac change
> > +        self.dut.send_expect("cp ./app/test-pmd/csumonly.c ./app/test-
> pmd/csumonly_backup.c", "#")
> > +        self.dut.send_expect("cp ./drivers/net/vhost/rte_eth_vhost.c
> ./drivers/net/vhost/rte_eth_vhost-backup.c", "#")
> > +        self.dut.send_expect("sed -i '/ether_addr_copy(&peer_eth/i\#if 0'
> ./app/test-pmd/csumonly.c", "#")
> > +        self.dut.send_expect("sed -i '/parse_ethernet(eth_hdr, &info/i\#endif'
> ./app/test-pmd/csumonly.c", "#")
> > +        # change offload of vhost
> > +        tx_offload = 'RTE_ETH_TX_OFFLOAD_VLAN_INSERT | ' + \
> > +                    'RTE_ETH_TX_OFFLOAD_UDP_CKSUM | ' + \
> > +                    'RTE_ETH_TX_OFFLOAD_TCP_CKSUM | ' + \
> > +                    'RTE_ETH_TX_OFFLOAD_IPV4_CKSUM | ' + \
> > +                    'RTE_ETH_TX_OFFLOAD_TCP_TSO;'
> > +        rx_offload = 'RTE_ETH_RX_OFFLOAD_VLAN_STRIP | ' + \
> > +                    'RTE_ETH_RX_OFFLOAD_TCP_CKSUM | ' + \
> > +                    'RTE_ETH_RX_OFFLOAD_UDP_CKSUM | ' + \
> > +                    'RTE_ETH_RX_OFFLOAD_IPV4_CKSUM | ' + \
> > +                    'RTE_ETH_RX_OFFLOAD_TCP_LRO;'
> > +        self.dut.send_expect("sed -i
> 's/RTE_ETH_TX_OFFLOAD_VLAN_INSERT;/%s/'
> drivers/net/vhost/rte_eth_vhost.c" % tx_offload, "#")
> > +        self.dut.send_expect("sed -i
> 's/RTE_ETH_RX_OFFLOAD_VLAN_STRIP;/%s/'
> drivers/net/vhost/rte_eth_vhost.c" % rx_offload, "#")
> > +        self.dut.build_install_dpdk(self.dut.target)
> 
> This hack is getting copy/pasted again and again.
> 
> _Don't modify DPDK sources in DTS_.
Yes, please, no more modifications to DPDK code.

> 
> 
> > +
> > +    def unprepare_dpdk(self):
> > +        # Recovery the DPDK code to original
> > +        self.dut.send_expect("cp ./app/test-pmd/csumonly_backup.c
> ./app/test-pmd/csumonly.c ", "#")
> > +        self.dut.send_expect("cp ./drivers/net/vhost/rte_eth_vhost-backup.c
> ./drivers/net/vhost/rte_eth_vhost.c ", "#")
> > +        self.dut.send_expect("rm -rf ./app/test-pmd/csumonly_backup.c", "#")
> > +        self.dut.send_expect("rm -rf ./drivers/net/vhost/rte_eth_vhost-
> backup.c", "#")
> > +        self.dut.build_install_dpdk(self.dut.target)
> 
> 
> --
> David Marchand


      reply	other threads:[~2022-05-09 19:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-07  8:43 Wei Ling
2022-05-09  6:52 ` David Marchand
2022-05-09 19:15   ` Honnappa Nagarahalli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DBAPR08MB5814EA39DB2F22D9BFC269C098C69@DBAPR08MB5814.eurprd08.prod.outlook.com \
    --to=honnappa.nagarahalli@arm.com \
    --cc=david.marchand@redhat.com \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \
    --cc=nd@arm.com \
    --cc=weix.ling@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git