From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8053A0509; Wed, 30 Mar 2022 11:11:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9EF8A40685; Wed, 30 Mar 2022 11:11:57 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id DBC4C4013F for ; Wed, 30 Mar 2022 11:11:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648631516; x=1680167516; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=t2fU9T54sIbE8pyKk3gFqSEWJfbB8FW8s8NxOza93T0=; b=aXq2pQgWze5Ed2sVmeH26HgyVMfgI+gm6gtQ7AnCwOkxGardhzHyCb22 aFD0wQiLl7AhRfCPKESmQmdjGokzPonm8pDC7c7DTGDvLfl0Tb+n9DLz/ 7n3EFeo0GQIoh+MqyaXNPUO+ez9jtUujFf9DROT39rIlwA0aeKmWMK4Zz Cx4vJqHvVOfqoP3HIHxFVsrS5U4l1PUPfYmDJUZ4KD/zXxi/VHyEmy6iF 2Gm5CydXjK0gXe9Lu3iJOTlOdY+6MRzXbH9OWkyoLJiOjQrZVo7LgaKFK hwXbwfAULZJVCrHGDKZ111VXW6HLZQd8cE/+zgoJMIvr3q15aVs727dDy Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10301"; a="240088139" X-IronPort-AV: E=Sophos;i="5.90,222,1643702400"; d="scan'208";a="240088139" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2022 02:11:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,222,1643702400"; d="scan'208";a="605352137" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga008.fm.intel.com with ESMTP; 30 Mar 2022 02:11:54 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 30 Mar 2022 02:11:54 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 30 Mar 2022 02:11:54 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Wed, 30 Mar 2022 02:11:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kPqBw7ZWEbbqi9sr+9rmbnwEWXFM3qr2k9FY1+K/GP2XXwwIBza9XRV1M5C08CSWtM+OwrhkwMcyVYA+9wDCXAcPK28hl3YfRzMOgWjjGAIDdRLLMxDVYH9F226WwMGE/CCmqiemDLja+gzd4FPbwHGjGvRdFoR0VIYp/EG3uhchumChanHf9H0fo6IAbcxqisBoyqao1G3mo+uNcdHyMIKZSihEZ669F0Xk1at6tfWTz9fsNjMfGq+Qe8hX1qRTRGBh1rWo0V2/ara0WJ2eA2CHbg6xwzy3daFIatPaCu57A9qV3MKspSSQZgAOpkswU56WucnxrWRfc9AhPpI4gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FYEuD8c6QjkVK/kqq66kdHCXIJnRYzIlXCQxw596pvQ=; b=laWDvwu+jd8dTK+YBufzGUC1CwZ+DkbIYG2/NFGkPxt5o9TVjYIIbuQW7LzgxYBE5lns+h9b0CHucaUtO1cg5MkwFSItJbq++xo7iZsE1UdOmzeH4BeS01m/RZ/BssCe8aylxBGbDOWarklAxsxvnsj727vKmLHB526S1npo+dk+rRkj3JvFFp0hs/4vKYlGZL59wZXXh+2bdGwBFirJTror/XWG3HpV417mOC76GGJycI1NcC0LZX1VuWJmfCuIiaA+zbwEH6GuNF94LJpYQBh29sBZYn5mgflzsaJ5nNKoiujrshl4dD9ZiiyujtWrTrgSeYZ8/rxGLT8gP2XXXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1404.namprd11.prod.outlook.com (2603:10b6:3:c::18) by BN6PR11MB1377.namprd11.prod.outlook.com (2603:10b6:404:49::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.18; Wed, 30 Mar 2022 09:11:50 +0000 Received: from DM5PR11MB1404.namprd11.prod.outlook.com ([fe80::15f9:ecb:c0fd:e4e1]) by DM5PR11MB1404.namprd11.prod.outlook.com ([fe80::15f9:ecb:c0fd:e4e1%4]) with mapi id 15.20.5102.023; Wed, 30 Mar 2022 09:11:50 +0000 From: "Dong, JunX" To: =?iso-8859-2?Q?Juraj_Linke=B9?= , "dts@dpdk.org" CC: "Tu, Lijuan" , "Sun, QingX" Subject: RE: [V1] framework/*: Replace framework texttable with third party library Thread-Topic: [V1] framework/*: Replace framework texttable with third party library Thread-Index: AdhEFHyAsiOc8KV6TlKppJVyxwPcKQ== Date: Wed, 30 Mar 2022 09:11:50 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c2588d69-ecdc-4383-4236-08da122d5313 x-ms-traffictypediagnostic: BN6PR11MB1377:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9i5iS4UaoOTqnyXZHgDyAm7VciS5g9kTTmH0k0k6j/ESniH1kuJB9Ow+G6DHPQBviItogG7VaQtscljvhJjYTHZj+tfCENFhhZlhVkSkP3YW/0A2TNoRAkktXgk8SEG2xvclPT0uzJRiVlbWUlgl+gn4lQ6pOpKnOtr1K59iqXgr6bz7oxf4Uugek2A80gVZzxSQzVaj4XIiDKB4fgo2dlTiTFZaIxeZZKg/q6JC+syMvdAwayGrAgO+/8+P8R3cjkAPdlowXh6dMwlcD97VHfXwRkVaPRTGybRoV2UQRcFng+04pNDxqL9dDa5JsIGl/FYTfj6Nc6KP5qNXuUajbvNumWzomo71sXtVGnHVJRflPCsC24G74kox4EfN4CnEkWmvLvK71pGCviWYoeH65Sm5G5HTv6Db65getqf8d269jd8cD7RVTYCZp0ahaw6E9Vkkf5Qb5BCybc0/ie2fo97ix8VzDBY0RIajOfTBuURkdK6PtmqJR57XtumW/+WqGiEwVYQSYP2IHYA+nRcNwjULSonZYIdt8e/muA7OtEqbELHasYs5ZK/JN+bocaT8kirTalQsccJaPQUdsoidS3+UuSWijFvk9U7erXIy+NhzDj1VqGqFeay0hEkNm5I5AppzB47U73XqFxoXSLJ7g/C1TdCzY7J1ZydwFohVVIOb0ja7RB6hkrrc8HKkTWPW4Hrker4G+kqkbic5ccwRvQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1404.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(86362001)(9686003)(316002)(8676002)(53546011)(66556008)(83380400001)(54906003)(7696005)(76116006)(64756008)(66446008)(66946007)(66476007)(6506007)(38100700002)(33656002)(110136005)(4326008)(82960400001)(5660300002)(186003)(122000001)(26005)(508600001)(52536014)(107886003)(55016003)(38070700005)(8936002)(71200400001)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-2?Q?U2u+iLocPBSaIL99+o7yk+Iw19LPPGBRnkW2ciPKxgFdyU7hRyR5wy5kHr?= =?iso-8859-2?Q?nbKov3JHIpRR8XPtS2aDioBQv9edLCCBl9Kfwv+UFtJ94KvWsUorY/3EaZ?= =?iso-8859-2?Q?s8dXWvl3CK34YEA2hWmYaKbJcF/1wVeke6h74QhuEPLOb7ZmGIFwR4jLst?= =?iso-8859-2?Q?jpbfVAo5pl67eHYI3ijirgzVcWtCDFGWamc5cP5+NQbjDPUMnTUv46Kftv?= =?iso-8859-2?Q?urJKROm0qNepkC3Wd3W/k6+PuQ0fMyHLb3Veazb6wxt2NwSLO6SwJEdEBa?= =?iso-8859-2?Q?TqIclvKrEQqFr9KWb3Tbtzg1keAY7/5josgLTdFhNQpx4CO/LfpNXmdCAZ?= =?iso-8859-2?Q?4M9Cax6biFrYTkEBXvFnJ7J2btWfJpHIYJ0GGW5t6AteKV1YV+XxjfIOua?= =?iso-8859-2?Q?pd/pvArcvgZ1b0/Llaz4fj9k+gMfbC5ZOduxCcBcweGWJIoU9qOqwWT00+?= =?iso-8859-2?Q?O8lnNhq4Jl3cS0+OyQ8rsQQJK+FZZyq76gLPggVGh54dyXbSqkGkjF204P?= =?iso-8859-2?Q?ALda5T02bBGG2rl6ssWu4euQ9aCRNK9rtueL0IVFL+RquBTvuKuDhfEK4R?= =?iso-8859-2?Q?6wXoJAgDZuuP+xAyO2zb4V+Kzm0ITTSwagn2405FWOtv52E3JpjJQfXS+x?= =?iso-8859-2?Q?fXJB9Zx23x9E807sdzc3lnXcuubOxgzNd0EXmuEI+eg5AhoaA0aX3nhA1U?= =?iso-8859-2?Q?I7EQETajMNIBiGlqG0NRjIV8AkbGD946HjyivkG4OQeM7fVhsOF+nZbPOY?= =?iso-8859-2?Q?OltvbBxym106JqbLcw7Q/MeHK4QuefHg1t6K3R65hSbX0bWOOYzBFFZdo8?= =?iso-8859-2?Q?tQ2LtlGdq1NQYTIS0SQsnXyr9UXBP8X+lqDXPwkD/ltVXj/+f9VTkqkzjx?= =?iso-8859-2?Q?/g8Nq/YJfUBvVlw2pJlVkW8A1Fc2qsHPLVwAHiBc8GQGGOb7Q7/DdeLs3W?= =?iso-8859-2?Q?PzsAunHKJV/ingwK7gNisx9+Lg/yenDk94cqgQslVQWzQ4TDUbJiXgQh1H?= =?iso-8859-2?Q?Sk6Uy7rWul5Cej7ksYdZkfmIhhyDnpvW3Yj2fgy0mVaLqF2zS2Db5/5HYe?= =?iso-8859-2?Q?9GNLDdEvzlxFh51HKkT3Y8QFP7tONqaIOaQLXs/y4RyzaCLvDDrl7CC9jR?= =?iso-8859-2?Q?BX9MDgQBg5nH5vU09wT4EIaFYWgX0WlazQtNfrIdnbO4kTM//zx9Lbm79v?= =?iso-8859-2?Q?Y0/Pf5FfCn5PP6UYbPnDZrvLG9cPkR9J5tRGbYid6sIdQwfoDPFRLkZQyI?= =?iso-8859-2?Q?UPIJSKsZbm+yTxweflQI2zWKl3Aoz61WHAngwx3NC1iEFo+iMORF8xi3BG?= =?iso-8859-2?Q?eKGspEwkR2oCcmJ+CfH1UtEIAK6vErYIXfVFREiH6MKV3fTp7SoXvitvz4?= =?iso-8859-2?Q?2aNnNanBiWwapSDnOQsl3gvqMWdKBKjY4lGgZdzoEQCyMt2sQd3uhYlX5w?= =?iso-8859-2?Q?aIaOIXz47ZqinUV7x132phiLR1x4EYrZXKkwtANsv4kmVjjBZvqiv6jFHl?= =?iso-8859-2?Q?0s1PmeisDSWVjjY+0bpdevIxkvfMrCo7QXTxHvJ3OeR7y8Kon1kV8JlBZ5?= =?iso-8859-2?Q?JVpONYQxxDk7KD+IFDUcpv37i43NqVG0IxyKi5rYoVSR6J0BxgFZyMr5gY?= =?iso-8859-2?Q?/JzL8HWPZDY1NmsrC30bWTR/BYN6dq/rC0SHNu5oI3QVCcDpFn9j7P14/m?= =?iso-8859-2?Q?BS/xgjlhCyG3yWJajGYIWdt/TWuP4GZaZyjM1K4QvL5cnQC1R+1RG7nKUM?= =?iso-8859-2?Q?a2v7Ufm/3V5QUNtxtfP3HnJkxr0IZfQEg5iOAQUA4xfccfBvWhENjlL1zi?= =?iso-8859-2?Q?sGNk1K1pzA=3D=3D?= Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1404.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c2588d69-ecdc-4383-4236-08da122d5313 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2022 09:11:50.2164 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QvqIL2xzze81lobTLJhMj5NjzqhMEpn2hoaZokO4YfZn35xafWyYyE+XNYBqPwHE79gp/T4/9/brqM3waREWHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1377 X-OriginatorOrg: intel.com X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org > -----Original Message----- > From: Juraj Linke=B9 > Sent: Wednesday, March 30, 2022 4:03 PM > To: Dong, JunX ; dts@dpdk.org > Cc: Tu, Lijuan ; Sun, QingX > Subject: RE: [V1] framework/*: Replace framework texttable with third par= ty > libary > > -----Original Message----- > > From: Jun Dong > > Sent: Wednesday, March 30, 2022 9:14 AM > > To: dts@dpdk.org > > Cc: lijuan.tu@intel.com; qingx.sun@intel.com; junx.dong@intel.com > > Subject: [V1] framework/*: Replace framework texttable with third > > party libary > > > > Signed-off-by: Jun Dong > > --- > > framework/dts.py | 1 - > > framework/test_result.py | 5 +- > > framework/texttable.py | 645 --------------------------------------- > > requirements.txt | 3 +- > > tests/perf_test_base.py | 5 +- > > 5 files changed, 8 insertions(+), 651 deletions(-) delete mode > > 100644 framework/texttable.py > > >=20 > > diff --git a/framework/test_result.py b/framework/test_result.py index > > 0231e769..abf8edb9 100644 > > --- a/framework/test_result.py > > +++ b/framework/test_result.py > > @@ -32,7 +32,6 @@ > > """ > > Generic result container and reporters """ > > -import framework.texttable as texttable # text format > > > > > > class Result(object): > > @@ -445,9 +444,11 @@ class ResultTable(object): > > rt.add_row(row) > > rt.table_print() > > """ > > + from texttable import Texttable > > + > > self.results_table_rows =3D [] > > self.results_table_rows.append([]) > > - self.table =3D texttable.Texttable(max_width=3D150) > > + self.table =3D Texttable(max_width=3D150) > > self.results_table_header =3D header > > self.logger =3D None > > self.rst =3D None >=20 > Is there a reason for moving the import statement? I'd prefer to have it = at > the beginning of the file. =20 Hi, Juraj Linke=B9, thanks for your comments. Sometimes, the trex will be used When execute performance suite, And trex also used texttable that comes from itself. But, the third party library texttable wasn't full compatible with the t= rex's version, If import texttable in global in DTS framework will effect trex which no= t import again, So, import texttable locally in the DTS framework. =20 > > diff --git a/tests/perf_test_base.py b/tests/perf_test_base.py index > > 0666f3bf..82ae74f4 100644 > > --- a/tests/perf_test_base.py > > +++ b/tests/perf_test_base.py > > @@ -44,7 +44,6 @@ from pprint import pformat > > > > import numpy as np > > > > -import framework.texttable as texttable import framework.utils as > > utils from framework.config import SuiteConf from > > framework.exception import VerifyFailure @@ -1039,11 +1038,13 @@ class > PerfTestBase(object): > > return mode_name > > > > def __display_suite_result(self, data): > > + from texttable import Texttable > > + > > values =3D data.get("values") > > title =3D data.get("title") > > max_length =3D sum([len(item) + 5 for item in title]) > > self.result_table_create(title) > > - self._result_table.table =3D texttable.Texttable(max_width=3Dm= ax_length) > > + self._result_table.table =3D Texttable(max_width=3Dmax_length) > > for value in values: > > self.result_table_add(value) > > self.result_table_print() > > -- > > 2.33.1.windows.1 > > >=20 > Same here.