test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Wan, Zhe" <zhe.wan@intel.com>
To: "Tu, Lijuan" <lijuan.tu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Zhao, XinfengX" <xinfengx.zhao@intel.com>
Subject: Re: [dts] [PATCH V1 6/6] tests/unit_tests_cryptodev_func: rework	cryptodev unit test script
Date: Fri, 12 Jun 2020 01:46:42 +0000	[thread overview]
Message-ID: <DM5PR11MB2059DEB23A73E1CF52BE8AF8EE810@DM5PR11MB2059.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200604005445.110297-7-xinfengx.zhao@intel.com>

Acked-by: Wan, Zhe <zhe.wan@intel.com>

-----Original Message-----
From: dts <dts-bounces@dpdk.org> On Behalf Of xinfengx
Sent: 2020年6月4日 8:55
To: dts@dpdk.org
Cc: Zhao, XinfengX <xinfengx.zhao@intel.com>
Subject: [dts] [PATCH V1 6/6] tests/unit_tests_cryptodev_func: rework cryptodev unit test script

rework cryptodev unit test script
remove the redundant code

Signed-off-by: xinfengx <xinfengx.zhao@intel.com>
---
 tests/TestSuite_unit_tests_cryptodev_func.py | 56 ++++++++------------
 1 file changed, 21 insertions(+), 35 deletions(-)

diff --git a/tests/TestSuite_unit_tests_cryptodev_func.py b/tests/TestSuite_unit_tests_cryptodev_func.py
index a370fc4..e990192 100644
--- a/tests/TestSuite_unit_tests_cryptodev_func.py
+++ b/tests/TestSuite_unit_tests_cryptodev_func.py
@@ -54,77 +54,63 @@ class UnitTestsCryptodev(TestCase):
         cc.clear_dpdk_config(self)
 
     def test_cryptodev_qat_autotest(self):
-        eal_opt_str = cc.get_eal_opt_str(self)
-        self.__run_unit_test("cryptodev_qat_autotest", eal_opt_str)
+        self.__run_unit_test("cryptodev_qat_autotest")
 
     def test_cryptodev_qat_asym_autotest(self):
-        eal_opt_str = cc.get_eal_opt_str(self)
-        self.__run_unit_test("cryptodev_qat_asym_autotest", eal_opt_str)
+        self.__run_unit_test("cryptodev_qat_asym_autotest")
 
     def _test_cryptodev_qat_perftest(self):
-        eal_opt_str = cc.get_eal_opt_str(self)
-        self.__run_unit_test("cryptodev_qat_perftest", eal_opt_str)
+        self.__run_unit_test("cryptodev_qat_perftest")
 
     def _test_cryptodev_qat_continual_perftest(self):
-        eal_opt_str = cc.get_eal_opt_str(self)
-        self.__run_unit_test("cryptodev_qat_continual_perftest", eal_opt_str)
+        self.__run_unit_test("cryptodev_qat_continual_perftest")
 
     def _test_cryptodev_qat_snow3g_perftest(self):
-        eal_opt_str = cc.get_eal_opt_str(self)
-        self.__run_unit_test("cryptodev_qat_snow3g_perftest", eal_opt_str)
+        self.__run_unit_test("cryptodev_qat_snow3g_perftest")
 
     def test_cryptodev_aesni_mb_autotest(self):
-        eal_opt_str = cc.get_eal_opt_str(self)
-        self.__run_unit_test("cryptodev_aesni_mb_autotest", eal_opt_str)
+        self.__run_unit_test("cryptodev_aesni_mb_autotest")
 
     def _test_cryptodev_aesni_mb_perftest(self):
-        eal_opt_str = cc.get_eal_opt_str(self)
-        self.__run_unit_test("cryptodev_aesni_mb_perftest", eal_opt_str)
+        self.__run_unit_test("cryptodev_aesni_mb_perftest")
 
     def test_cryptodev_aesni_gcm_autotest(self):
-        eal_opt_str = cc.get_eal_opt_str(self)
-        self.__run_unit_test("cryptodev_aesni_gcm_autotest", eal_opt_str)
+        self.__run_unit_test("cryptodev_aesni_gcm_autotest")
 
     def _test_cryptodev_aesni_gcm_perftest(self):
-        eal_opt_str = cc.get_eal_opt_str(self)
-        self.__run_unit_test("cryptodev_aesni_gcm_perftest", eal_opt_str)
+        self.__run_unit_test("cryptodev_aesni_gcm_perftest")
 
     def test_cryptodev_sw_snow3g_autotest(self):
-        eal_opt_str = cc.get_eal_opt_str(self)
-        self.__run_unit_test("cryptodev_sw_snow3g_autotest", eal_opt_str)
+        self.__run_unit_test("cryptodev_sw_snow3g_autotest")
 
     def _test_cryptodev_sw_snow3g_perftest(self):
-        eal_opt_str = cc.get_eal_opt_str(self)
-        self.__run_unit_test("cryptodev_sw_snow3g_perftest", eal_opt_str)
+        self.__run_unit_test("cryptodev_sw_snow3g_perftest")
 
     def test_cryptodev_sw_kasumi_autotest(self):
-        eal_opt_str = cc.get_eal_opt_str(self)
-        self.__run_unit_test("cryptodev_sw_kasumi_autotest", eal_opt_str)
+        self.__run_unit_test("cryptodev_sw_kasumi_autotest")
 
     def test_cryptodev_sw_zuc_autotest(self):
-        eal_opt_str = cc.get_eal_opt_str(self)
-        self.__run_unit_test("cryptodev_sw_zuc_autotest", eal_opt_str)
+        self.__run_unit_test("cryptodev_sw_zuc_autotest")
 
     def test_cryptodev_null_autotest(self):
-        eal_opt_str = cc.get_eal_opt_str(self)
-        self.__run_unit_test("cryptodev_null_autotest", eal_opt_str)
+        self.__run_unit_test("cryptodev_null_autotest")
 
     def test_cryptodev_openssl_autotest(self):
-        eal_opt_str = cc.get_eal_opt_str(self)
-        self.__run_unit_test("cryptodev_openssl_autotest", eal_opt_str)
+        self.__run_unit_test("cryptodev_openssl_autotest")
 
     def _test_cryptodev_openssl_perftest(self):
-        eal_opt_str = cc.get_eal_opt_str(self)
-        self.__run_unit_test("cryptodev_openssl_perftest", eal_opt_str)
+        self.__run_unit_test("cryptodev_openssl_perftest")
 
     def test_cryptodev_scheduler_autotest(self):
+        self.__run_unit_test("cryptodev_scheduler_autotest")
+
+    def __run_unit_test(self, testsuite, timeout=600):
         eal_opt_str = cc.get_eal_opt_str(self)
-        self.__run_unit_test("cryptodev_scheduler_autotest", eal_opt_str)
+        w = cc.get_qat_devices(self, num=1)
 
-    def __run_unit_test(self, testsuite, eal_opt_str, timeout=600):
         self.logger.info("STEP_TEST: " + testsuite)
         self.dut.send_expect("dmesg -C", "# ", 30)
-        cmd_str = cc.get_dpdk_app_cmd_str(self._app_path, eal_opt_str)
+        cmd_str = cc.get_dpdk_app_cmd_str(self._app_path, eal_opt_str + " --log-level=6 -w %s" % w[0])
         self.dut.send_expect(cmd_str, "RTE>>", 30)
 
         out = ""
-- 
2.17.1


  reply	other threads:[~2020-06-12  1:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-04  0:54 [dts] [PATCH V1 0/6] rework cryptodev test script and conf xinfengx
2020-06-04  0:54 ` [dts] [PATCH V1 1/6] conf: simplify conf settings for cryptodev test xinfengx
2020-06-04  0:54 ` [dts] [PATCH V1 2/6] tests/cryptodev_common: improve cryptodev common methods xinfengx
2020-06-04  0:54 ` [dts] [PATCH V1 3/6] tests/crypto_perf_cryptodev_perf: rework crypto_perf test script xinfengx
2020-06-04  0:54 ` [dts] [PATCH V1 4/6] tests/l2fwd_cryptodev_func: rework l2fwd_crypto " xinfengx
2020-06-04  0:54 ` [dts] [PATCH V1 5/6] tests/ipsec_gw_cryptodev_func: rework cryptodev ipsec " xinfengx
2020-06-04  0:54 ` [dts] [PATCH V1 6/6] tests/unit_tests_cryptodev_func: rework cryptodev unit " xinfengx
2020-06-12  1:46   ` Wan, Zhe [this message]
2020-06-04  0:59 ` [dts] [PATCH V1 0/6] rework cryptodev test script and conf Zhao, XinfengX
2020-06-19  3:32 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM5PR11MB2059DEB23A73E1CF52BE8AF8EE810@DM5PR11MB2059.namprd11.prod.outlook.com \
    --to=zhe.wan@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \
    --cc=xinfengx.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).