* [dts] [PATCH V1] tests/TestSuite_telemetry: Adapting python3 code rules
@ 2021-01-19 8:32 ChenBo
2021-01-19 8:36 ` Chen, BoX C
2021-01-21 8:24 ` Tu, Lijuan
0 siblings, 2 replies; 4+ messages in thread
From: ChenBo @ 2021-01-19 8:32 UTC (permalink / raw)
To: dts; +Cc: ChenBo
The coding styles of python2 and python3 are different, modify script to adapt to python3.
Signed-off-by: ChenBo <box.c.chen@intel.com>
---
tests/TestSuite_telemetry.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/TestSuite_telemetry.py b/tests/TestSuite_telemetry.py
index 81e14a6c..7e474bc2 100644
--- a/tests/TestSuite_telemetry.py
+++ b/tests/TestSuite_telemetry.py
@@ -70,8 +70,8 @@ class TestTelemetry(TestCase):
with open(self.json_file, 'w') as fp:
fp.write(data)
def requestMetrics(self): # Requests metrics for given client
- self.socket.client_fd.send(METRICS_REQ)
- data = self.socket.client_fd.recv(BUFFER_SIZE)
+ self.socket.client_fd.send(METRICS_REQ.encode())
+ data = self.socket.client_fd.recv(BUFFER_SIZE).decode()
return data
def singleRequestMetrics(self):
data = self.requestMetrics()
@@ -128,7 +128,7 @@ class TestTelemetry(TestCase):
self.query_tool = ';'.join([
'cd {}'.format(self.target_dir),
'chmod 777 {}'.format(fileName),
- './' + fileName])
+ 'python3 ' + fileName])
def rename_dpdk_telemetry_tool(self):
'''
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dts] [PATCH V1] tests/TestSuite_telemetry: Adapting python3 code rules
2021-01-19 8:32 [dts] [PATCH V1] tests/TestSuite_telemetry: Adapting python3 code rules ChenBo
@ 2021-01-19 8:36 ` Chen, BoX C
2021-01-19 9:13 ` Zhao, HaiyangX
2021-01-21 8:24 ` Tu, Lijuan
1 sibling, 1 reply; 4+ messages in thread
From: Chen, BoX C @ 2021-01-19 8:36 UTC (permalink / raw)
To: Chen, BoX C, dts
[-- Attachment #1: Type: text/plain, Size: 307 bytes --]
Tested-by: ChenBo <box.c.chen@intel.com>
Regards,
Chen Bo
> -----Original Message-----
> From: ChenBo <box.c.chen@intel.com>
> Sent: January 19, 2021 16:32
> To: dts@dpdk.org
> Cc: Chen, BoX C <box.c.chen@intel.com>
> Subject: [dts][PATCH V1] tests/TestSuite_telemetry: Adapting python3 code
[-- Attachment #2: TestTelemetry.log --]
[-- Type: application/octet-stream, Size: 16913 bytes --]
19/01/2021 16:25:28 dts:
TEST SUITE : TestTelemetry
19/01/2021 16:25:28 dts: NIC : fortville_spirit
19/01/2021 16:25:28 dut.10.240.183.77:
19/01/2021 16:25:28 tester:
19/01/2021 16:25:28 dut.10.240.183.77: rm -f /root/dpdk/dpdk_telemetry_client.py;cp -f /root/dpdk/usertools/dpdk-telemetry-client.py /root/dpdk/dpdk_telemetry_client.py;sed -i -e 's/class Client:/class Client(object):/g' /root/dpdk/dpdk_telemetry_client.py
19/01/2021 16:25:28 dut.10.240.183.77:
19/01/2021 16:25:29 dut.10.240.183.77: scp -v /home/chenbo/fvl40g_dts/output/telemetry/query_tool.py root@10.240.183.77:/root/dpdk
19/01/2021 16:25:31 TestTelemetry: Test Case test_basic_connection Begin
19/01/2021 16:25:31 dut.10.240.183.77:
19/01/2021 16:25:31 tester:
19/01/2021 16:25:31 dut.10.240.183.77: x86_64-native-linuxapp-gcc/app/dpdk-testpmd -l 1,2 -n 4 -a 0000:0a:00.0 -a 0000:0a:00.1 --file-prefix=dpdk_15632_20210119162509 --telemetry -- -i
19/01/2021 16:25:32 dut.10.240.183.77: EAL: Detected 40 lcore(s)
EAL: Detected 2 NUMA nodes
EAL: Multi-process socket /var/run/dpdk/dpdk_15632_20210119162509/mp_socket
EAL: Selected IOVA mode 'VA'
EAL: No available hugepages reported in hugepages-2048kB
EAL: Probing VFIO support...
EAL: VFIO support initialized
EAL: using IOMMU type 1 (Type 1)
EAL: Probe PCI driver: net_i40e (8086:1583) device: 0000:0a:00.0 (socket 0)
EAL: Probe PCI driver: net_i40e (8086:1583) device: 0000:0a:00.1 (socket 0)
Interactive-mode selected
testpmd: create a new mbuf pool <mb_pool_0>: n=155456, size=2176, socket=0
testpmd: preferred mempool ops selected: ring_mp_mc
Configuring Port 0 (socket 0)
Port 0: 68:05:CA:30:68:70
Configuring Port 1 (socket 0)
Port 1: 68:05:CA:30:68:71
Checking link statuses...
Done
19/01/2021 16:25:42 dut.10.240.183.77: start
19/01/2021 16:25:42 dut.10.240.183.77:
io packet forwarding - ports=2 - cores=1 - streams=2 - NUMA support enabled, MP allocation mode: native
Logical Core 2 (socket 0) forwards packets on 2 streams:
RX P=0/Q=0 (socket 0) -> TX P=1/Q=0 (socket 0) peer=02:00:00:00:00:01
RX P=1/Q=0 (socket 0) -> TX P=0/Q=0 (socket 0) peer=02:00:00:00:00:00
io packet forwarding packets/burst=32
nb forwarding cores=1 - nb forwarding ports=2
port 0: RX queue number: 1 Tx queue number: 1
Rx offloads=0x0 Tx offloads=0x10000
RX queue: 0
RX desc=2048 - RX free threshold=32
RX threshold registers: pthresh=0 hthresh=0 wthresh=0
RX Offloads=0x0
TX queue: 0
TX desc=1024 - TX free threshold=32
TX threshold registers: pthresh=32 hthresh=0 wthresh=0
TX offloads=0x10000 - TX RS bit threshold=32
port 1: RX queue number: 1 Tx queue number: 1
Rx offloads=0x0 Tx offloads=0x10000
RX queue: 0
RX desc=2048 - RX free threshold=32
RX threshold registers: pthresh=0 hthresh=0 wthresh=0
RX Offloads=0x0
TX queue: 0
TX desc=1024 - TX free threshold=32
TX threshold registers: pthresh=32 hthresh=0 wthresh=0
TX offloads=0x10000 - TX RS bit threshold=32
19/01/2021 16:25:42 dut.10.240.183.77: sed -i 's/self.socket.send_fd.connect("\/var\/run\/dpdk\/.*\/telemetry")/self.socket.send_fd.connect("\/var\/run\/dpdk\/dpdk_15632_20210119162509\/telemetry")/g' /root/dpdk/usertools/dpdk-telemetry-client.py
19/01/2021 16:25:42 dut.10.240.183.77:
19/01/2021 16:25:43 dut.10.240.183.77: sed -i 's/self.socket.send_fd.connect("\/var\/run\/dpdk\/.*\/telemetry")/self.socket.send_fd.connect("\/var\/run\/dpdk\/dpdk_15632_20210119162509\/telemetry")/g' /root/dpdk/dpdk_telemetry_client.py
19/01/2021 16:25:43 dut.10.240.183.77:
19/01/2021 16:25:48 dut.10.240.183.77: ps aux | grep -i 'dpdk-telemetry-client.py' | grep -v grep | awk {'print $2'}
19/01/2021 16:25:48 dut.10.240.183.77:
19/01/2021 16:25:49 dut.10.240.183.77: stop
19/01/2021 16:25:49 dut.10.240.183.77:
Telling cores to ...
Waiting for lcores to finish...
---------------------- Forward statistics for port 0 ----------------------
RX-packets: 0 RX-dropped: 0 RX-total: 0
TX-packets: 0 TX-dropped: 0 TX-total: 0
----------------------------------------------------------------------------
---------------------- Forward statistics for port 1 ----------------------
RX-packets: 0 RX-dropped: 0 RX-total: 0
TX-packets: 0 TX-dropped: 0 TX-total: 0
----------------------------------------------------------------------------
+++++++++++++++ Accumulated forward statistics for all ports+++++++++++++++
RX-packets: 0 RX-dropped: 0 RX-total: 0
TX-packets: 0 TX-dropped: 0 TX-total: 0
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Done.
19/01/2021 16:25:49 dut.10.240.183.77: quit
19/01/2021 16:25:50 dut.10.240.183.77:
Stopping port 0...
Stopping ports...
Done
Stopping port 1...
Stopping ports...
Port 0: link state change event
Done
Shutting down port 0...
Closing ports...
Port 0 is closed
Invalid port_id=0
Done
Shutting down port 1...
Closing ports...
Port 1 is closed
Invalid port_id=1
Done
Bye...
19/01/2021 16:25:50 dut.10.240.183.77: x86_64-native-linuxapp-gcc/app/dpdk-testpmd -l 1,2 -n 4 -a 0000:0a:00.0 -a 0000:0a:00.1 --file-prefix=dpdk_15632_20210119162509 --telemetry -- -i
19/01/2021 16:25:51 dut.10.240.183.77: EAL: Detected 40 lcore(s)
EAL: Detected 2 NUMA nodes
EAL: Multi-process socket /var/run/dpdk/dpdk_15632_20210119162509/mp_socket
EAL: Selected IOVA mode 'VA'
EAL: No available hugepages reported in hugepages-2048kB
EAL: Probing VFIO support...
EAL: VFIO support initialized
EAL: using IOMMU type 1 (Type 1)
EAL: Probe PCI driver: net_i40e (8086:1583) device: 0000:0a:00.0 (socket 0)
EAL: Probe PCI driver: net_i40e (8086:1583) device: 0000:0a:00.1 (socket 0)
Interactive-mode selected
testpmd: create a new mbuf pool <mb_pool_0>: n=155456, size=2176, socket=0
testpmd: preferred mempool ops selected: ring_mp_mc
Configuring Port 0 (socket 0)
Port 0: 68:05:CA:30:68:70
Configuring Port 1 (socket 0)
Port 1: 68:05:CA:30:68:71
Checking link statuses...
Done
19/01/2021 16:26:01 dut.10.240.183.77: start
19/01/2021 16:26:01 dut.10.240.183.77:
io packet forwarding - ports=2 - cores=1 - streams=2 - NUMA support enabled, MP allocation mode: native
Logical Core 2 (socket 0) forwards packets on 2 streams:
RX P=0/Q=0 (socket 0) -> TX P=1/Q=0 (socket 0) peer=02:00:00:00:00:01
RX P=1/Q=0 (socket 0) -> TX P=0/Q=0 (socket 0) peer=02:00:00:00:00:00
io packet forwarding packets/burst=32
nb forwarding cores=1 - nb forwarding ports=2
port 0: RX queue number: 1 Tx queue number: 1
Rx offloads=0x0 Tx offloads=0x10000
RX queue: 0
RX desc=2048 - RX free threshold=32
RX threshold registers: pthresh=0 hthresh=0 wthresh=0
RX Offloads=0x0
TX queue: 0
TX desc=1024 - TX free threshold=32
TX threshold registers: pthresh=32 hthresh=0 wthresh=0
TX offloads=0x10000 - TX RS bit threshold=32
port 1: RX queue number: 1 Tx queue number: 1
Rx offloads=0x0 Tx offloads=0x10000
RX queue: 0
RX desc=2048 - RX free threshold=32
RX threshold registers: pthresh=0 hthresh=0 wthresh=0
RX Offloads=0x0
TX queue: 0
TX desc=1024 - TX free threshold=32
TX threshold registers: pthresh=32 hthresh=0 wthresh=0
TX offloads=0x10000 - TX RS bit threshold=32
19/01/2021 16:26:01 dut.10.240.183.77: cd /root/dpdk;chmod 777 query_tool.py;python3 query_tool.py -c 1 -j /root/dpdk/metric.json
19/01/2021 16:26:04 dut.10.240.183.77: Options Menu
[1] Send for Metrics for all ports
Unregister client
Get metrics done
19/01/2021 16:26:05 dut.10.240.183.77: scp -v root@10.240.183.77:/root/dpdk/metric.json /home/chenbo/fvl40g_dts/output/telemetry/metric.json
19/01/2021 16:26:06 TestTelemetry: {0: {'mac_local_errors': 0,
'mac_remote_errors': 0,
'rx_broadcast_packets': 0,
'rx_crc_errors': 0,
'rx_dropped_packets': 0,
'rx_error_bytes': 0,
'rx_errors': 0,
'rx_flow_director_atr_match_packets': 0,
'rx_flow_director_sb_match_packets': 0,
'rx_fragmented_errors': 0,
'rx_good_bytes': 332,
'rx_good_packets': 4,
'rx_illegal_byte_errors': 0,
'rx_jabber_errors': 0,
'rx_length_errors': 0,
'rx_low_power_idle_count': 0,
'rx_low_power_idle_status': 0,
'rx_mac_short_dropped': 0,
'rx_mbuf_allocation_errors': 0,
'rx_missed_errors': 0,
'rx_multicast_packets': 4,
'rx_oversize_errors': 0,
'rx_priority0_xoff_packets': 0,
'rx_priority0_xon_packets': 0,
'rx_priority1_xoff_packets': 0,
'rx_priority1_xon_packets': 0,
'rx_priority2_xoff_packets': 0,
'rx_priority2_xon_packets': 0,
'rx_priority3_xoff_packets': 0,
'rx_priority3_xon_packets': 0,
'rx_priority4_xoff_packets': 0,
'rx_priority4_xon_packets': 0,
'rx_priority5_xoff_packets': 0,
'rx_priority5_xon_packets': 0,
'rx_priority6_xoff_packets': 0,
'rx_priority6_xon_packets': 0,
'rx_priority7_xoff_packets': 0,
'rx_priority7_xon_packets': 0,
'rx_q0_bytes': 0,
'rx_q0_errors': 0,
'rx_q0_packets': 0,
'rx_size_1024_to_1522_packets': 0,
'rx_size_128_to_255_packets': 0,
'rx_size_1523_to_max_packets': 0,
'rx_size_256_to_511_packets': 0,
'rx_size_512_to_1023_packets': 0,
'rx_size_64_packets': 0,
'rx_size_65_to_127_packets': 4,
'rx_undersized_errors': 0,
'rx_unicast_packets': 0,
'rx_unknown_protocol_packets': 4,
'rx_xoff_packets': 0,
'rx_xon_packets': 0,
'tx_broadcast_packets': 0,
'tx_dropped_packets': 0,
'tx_errors': 0,
'tx_good_bytes': 0,
'tx_good_packets': 0,
'tx_link_down_dropped': 0,
'tx_low_power_idle_count': 0,
'tx_low_power_idle_status': 0,
'tx_multicast_packets': 0,
'tx_priority0_xoff_packets': 0,
'tx_priority0_xon_packets': 0,
'tx_priority0_xon_to_xoff_packets': 0,
'tx_priority1_xoff_packets': 0,
'tx_priority1_xon_packets': 0,
'tx_priority1_xon_to_xoff_packets': 0,
'tx_priority2_xoff_packets': 0,
'tx_priority2_xon_packets': 0,
'tx_priority2_xon_to_xoff_packets': 0,
'tx_priority3_xoff_packets': 0,
'tx_priority3_xon_packets': 0,
'tx_priority3_xon_to_xoff_packets': 0,
'tx_priority4_xoff_packets': 0,
'tx_priority4_xon_packets': 0,
'tx_priority4_xon_to_xoff_packets': 0,
'tx_priority5_xoff_packets': 0,
'tx_priority5_xon_packets': 0,
'tx_priority5_xon_to_xoff_packets': 0,
'tx_priority6_xoff_packets': 0,
'tx_priority6_xon_packets': 0,
'tx_priority6_xon_to_xoff_packets': 0,
'tx_priority7_xoff_packets': 0,
'tx_priority7_xon_packets': 0,
'tx_priority7_xon_to_xoff_packets': 0,
'tx_q0_bytes': 0,
'tx_q0_packets': 0,
'tx_size_1024_to_1522_packets': 0,
'tx_size_128_to_255_packets': 0,
'tx_size_1523_to_max_packets': 0,
'tx_size_256_to_511_packets': 0,
'tx_size_512_to_1023_packets': 0,
'tx_size_64_packets': 0,
'tx_size_65_to_127_packets': 0,
'tx_unicast_packets': 0,
'tx_xoff_packets': 0,
'tx_xon_packets': 0},
1: {'mac_local_errors': 0,
'mac_remote_errors': 0,
'rx_broadcast_packets': 0,
'rx_crc_errors': 0,
'rx_dropped_packets': 0,
'rx_error_bytes': 0,
'rx_errors': 0,
'rx_flow_director_atr_match_packets': 0,
'rx_flow_director_sb_match_packets': 0,
'rx_fragmented_errors': 0,
'rx_good_bytes': 332,
'rx_good_packets': 4,
'rx_illegal_byte_errors': 0,
'rx_jabber_errors': 0,
'rx_length_errors': 0,
'rx_low_power_idle_count': 0,
'rx_low_power_idle_status': 0,
'rx_mac_short_dropped': 0,
'rx_mbuf_allocation_errors': 0,
'rx_missed_errors': 0,
'rx_multicast_packets': 4,
'rx_oversize_errors': 0,
'rx_priority0_xoff_packets': 0,
'rx_priority0_xon_packets': 0,
'rx_priority1_xoff_packets': 0,
'rx_priority1_xon_packets': 0,
'rx_priority2_xoff_packets': 0,
'rx_priority2_xon_packets': 0,
'rx_priority3_xoff_packets': 0,
'rx_priority3_xon_packets': 0,
'rx_priority4_xoff_packets': 0,
'rx_priority4_xon_packets': 0,
'rx_priority5_xoff_packets': 0,
'rx_priority5_xon_packets': 0,
'rx_priority6_xoff_packets': 0,
'rx_priority6_xon_packets': 0,
'rx_priority7_xoff_packets': 0,
'rx_priority7_xon_packets': 0,
'rx_q0_bytes': 0,
'rx_q0_errors': 0,
'rx_q0_packets': 0,
'rx_size_1024_to_1522_packets': 0,
'rx_size_128_to_255_packets': 0,
'rx_size_1523_to_max_packets': 0,
'rx_size_256_to_511_packets': 0,
'rx_size_512_to_1023_packets': 0,
'rx_size_64_packets': 0,
'rx_size_65_to_127_packets': 4,
'rx_undersized_errors': 0,
'rx_unicast_packets': 0,
'rx_unknown_protocol_packets': 4,
'rx_xoff_packets': 0,
'rx_xon_packets': 0,
'tx_broadcast_packets': 0,
'tx_dropped_packets': 0,
'tx_errors': 0,
'tx_good_bytes': 0,
'tx_good_packets': 0,
'tx_link_down_dropped': 0,
'tx_low_power_idle_count': 0,
'tx_low_power_idle_status': 0,
'tx_multicast_packets': 0,
'tx_priority0_xoff_packets': 0,
'tx_priority0_xon_packets': 0,
'tx_priority0_xon_to_xoff_packets': 0,
'tx_priority1_xoff_packets': 0,
'tx_priority1_xon_packets': 0,
'tx_priority1_xon_to_xoff_packets': 0,
'tx_priority2_xoff_packets': 0,
'tx_priority2_xon_packets': 0,
'tx_priority2_xon_to_xoff_packets': 0,
'tx_priority3_xoff_packets': 0,
'tx_priority3_xon_packets': 0,
'tx_priority3_xon_to_xoff_packets': 0,
'tx_priority4_xoff_packets': 0,
'tx_priority4_xon_packets': 0,
'tx_priority4_xon_to_xoff_packets': 0,
'tx_priority5_xoff_packets': 0,
'tx_priority5_xon_packets': 0,
'tx_priority5_xon_to_xoff_packets': 0,
'tx_priority6_xoff_packets': 0,
'tx_priority6_xon_packets': 0,
'tx_priority6_xon_to_xoff_packets': 0,
'tx_priority7_xoff_packets': 0,
'tx_priority7_xon_packets': 0,
'tx_priority7_xon_to_xoff_packets': 0,
'tx_q0_bytes': 0,
'tx_q0_packets': 0,
'tx_size_1024_to_1522_packets': 0,
'tx_size_128_to_255_packets': 0,
'tx_size_1523_to_max_packets': 0,
'tx_size_256_to_511_packets': 0,
'tx_size_512_to_1023_packets': 0,
'tx_size_64_packets': 0,
'tx_size_65_to_127_packets': 0,
'tx_unicast_packets': 0,
'tx_xoff_packets': 0,
'tx_xon_packets': 0}}
19/01/2021 16:26:21 dut.10.240.183.77:
19/01/2021 16:26:21 dut.10.240.183.77: stop
19/01/2021 16:26:22 dut.10.240.183.77:
Telling cores to ...
Waiting for lcores to finish...
---------------------- Forward statistics for port 0 ----------------------
RX-packets: 0 RX-dropped: 0 RX-total: 0
TX-packets: 0 TX-dropped: 0 TX-total: 0
----------------------------------------------------------------------------
---------------------- Forward statistics for port 1 ----------------------
RX-packets: 0 RX-dropped: 0 RX-total: 0
TX-packets: 0 TX-dropped: 0 TX-total: 0
----------------------------------------------------------------------------
+++++++++++++++ Accumulated forward statistics for all ports+++++++++++++++
RX-packets: 0 RX-dropped: 0 RX-total: 0
TX-packets: 0 TX-dropped: 0 TX-total: 0
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Done.
19/01/2021 16:26:22 dut.10.240.183.77: quit
19/01/2021 16:26:22 dut.10.240.183.77:
Stopping port 0...
Stopping ports...
Done
Stopping port 1...
Stopping ports...
Port 0: link state change event
Done
Shutting down port 0...
Closing ports...
Port 1: link state change event
Port 0 is closed
Invalid port_id=0
Done
Shutting down port 1...
Closing ports...
Port 1 is closed
Invalid port_id=1
Done
Bye...
19/01/2021 16:26:22 TestTelemetry: Test Case test_basic_connection Result PASSED:
19/01/2021 16:26:22 dts:
TEST SUITE ENDED: TestTelemetry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dts] [PATCH V1] tests/TestSuite_telemetry: Adapting python3 code rules
2021-01-19 8:36 ` Chen, BoX C
@ 2021-01-19 9:13 ` Zhao, HaiyangX
0 siblings, 0 replies; 4+ messages in thread
From: Zhao, HaiyangX @ 2021-01-19 9:13 UTC (permalink / raw)
To: Chen, BoX C, Chen, BoX C, dts
Acked-by: Haiyang Zhao <haiyangx.zhao@intel.com>
Best Regards,
Zhao Haiyang
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Chen, BoX C
> Sent: Tuesday, January 19, 2021 16:37
> To: Chen, BoX C <box.c.chen@intel.com>; dts@dpdk.org
> Subject: Re: [dts] [PATCH V1] tests/TestSuite_telemetry: Adapting python3
> code rules
>
> Tested-by: ChenBo <box.c.chen@intel.com>
>
> Regards,
> Chen Bo
>
> > -----Original Message-----
> > From: ChenBo <box.c.chen@intel.com>
> > Sent: January 19, 2021 16:32
> > To: dts@dpdk.org
> > Cc: Chen, BoX C <box.c.chen@intel.com>
> > Subject: [dts][PATCH V1] tests/TestSuite_telemetry: Adapting python3
> code
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dts] [PATCH V1] tests/TestSuite_telemetry: Adapting python3 code rules
2021-01-19 8:32 [dts] [PATCH V1] tests/TestSuite_telemetry: Adapting python3 code rules ChenBo
2021-01-19 8:36 ` Chen, BoX C
@ 2021-01-21 8:24 ` Tu, Lijuan
1 sibling, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2021-01-21 8:24 UTC (permalink / raw)
To: Chen, BoX C, dts; +Cc: Chen, BoX C
> Subject: [dts] [PATCH V1] tests/TestSuite_telemetry: Adapting python3 code
> rules
>
> The coding styles of python2 and python3 are different, modify script to
> adapt to python3.
>
> Signed-off-by: ChenBo <box.c.chen@intel.com>
Applied, next time please:
1, remove prefix "TestSuite" in subject to reduce text count
2, don't use capitals in general
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-21 8:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-19 8:32 [dts] [PATCH V1] tests/TestSuite_telemetry: Adapting python3 code rules ChenBo
2021-01-19 8:36 ` Chen, BoX C
2021-01-19 9:13 ` Zhao, HaiyangX
2021-01-21 8:24 ` Tu, Lijuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).