test suite reviews and discussions
 help / color / Atom feed
From: "Lu, Nannan" <nannan.lu@intel.com>
To: "Mei, JianweiX" <jianweix.mei@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Mei, JianweiX" <jianweix.mei@intel.com>
Subject: Re: [dts] [PATCH V1] tests/cvl_switch_filter:update class name and	instance Packet class
Date: Wed, 29 Jul 2020 08:20:46 +0000
Message-ID: <DM6PR11MB3900161268E1600FE92EB85EF8700@DM6PR11MB3900.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200727183311.18274-1-jianweix.mei@intel.com>

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Jianwei Mei
> Sent: Tuesday, July 28, 2020 2:33 AM
> To: dts@dpdk.org
> Cc: Mei, JianweiX <jianweix.mei@intel.com>
> Subject: [dts] [PATCH V1] tests/cvl_switch_filter:update class name and instance
> Packet class
> 
> 1. Suite TestSuite_cvl_dcf_switch_filter.py and TestSuite_cvl_switch_filter.py
> have the same class name, lead to logs generated in one log file.
> 2. Class packet have not instantiated.
> 
> Signed-off-by: Jianwei Mei <jianweix.mei@intel.com>
> ---
>  tests/TestSuite_cvl_switch_filter.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_cvl_switch_filter.py
> b/tests/TestSuite_cvl_switch_filter.py
> index 01a2842..5dc7d21 100644
> --- a/tests/TestSuite_cvl_switch_filter.py
> +++ b/tests/TestSuite_cvl_switch_filter.py
> @@ -2487,7 +2487,7 @@ tvs_mac_ipv6_tcp_non_pipeline_mode = [
> 
>  test_results = OrderedDict()
> 
> -class SwitchFilterTest(TestCase):
> +class CVLSwitchFilterTest(TestCase):
> 
>      def set_up_all(self):
>          """
> @@ -2506,6 +2506,7 @@ class SwitchFilterTest(TestCase):
>          src_file = 'dep/testpmd_cmds_rte_flow_fdir_rules'
>          self.dut_file_dir = '/tmp'
>          self.dut.session.copy_file_to(src_file, self.dut_file_dir)
> +        self.pkt = Packet()
> 
>      def set_up(self):
>          """

Acked-by: Nannan Lu <nannan.lu@intel.com>

> --
> 2.17.1


      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-27 18:33 Jianwei Mei
2020-07-29  8:20 ` Lu, Nannan [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB3900161268E1600FE92EB85EF8700@DM6PR11MB3900.namprd11.prod.outlook.com \
    --to=nannan.lu@intel.com \
    --cc=dts@dpdk.org \
    --cc=jianweix.mei@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox