test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1] tests/cvl_switch_filter:update class name and instance Packet class
@ 2020-07-27 18:33 Jianwei Mei
  2020-07-29  8:20 ` Lu, Nannan
  2020-08-12  5:58 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Jianwei Mei @ 2020-07-27 18:33 UTC (permalink / raw)
  To: dts; +Cc: Jianwei Mei

1. Suite TestSuite_cvl_dcf_switch_filter.py and TestSuite_cvl_switch_filter.py have 
the same class name, lead to logs generated in one log file.
2. Class packet have not instantiated.

Signed-off-by: Jianwei Mei <jianweix.mei@intel.com>
---
 tests/TestSuite_cvl_switch_filter.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_cvl_switch_filter.py b/tests/TestSuite_cvl_switch_filter.py
index 01a2842..5dc7d21 100644
--- a/tests/TestSuite_cvl_switch_filter.py
+++ b/tests/TestSuite_cvl_switch_filter.py
@@ -2487,7 +2487,7 @@ tvs_mac_ipv6_tcp_non_pipeline_mode = [
 
 test_results = OrderedDict()
 
-class SwitchFilterTest(TestCase):
+class CVLSwitchFilterTest(TestCase):
 
     def set_up_all(self):
         """
@@ -2506,6 +2506,7 @@ class SwitchFilterTest(TestCase):
         src_file = 'dep/testpmd_cmds_rte_flow_fdir_rules'
         self.dut_file_dir = '/tmp'
         self.dut.session.copy_file_to(src_file, self.dut_file_dir)
+        self.pkt = Packet()
 
     def set_up(self):
         """
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/cvl_switch_filter:update class name and instance Packet class
  2020-07-27 18:33 [dts] [PATCH V1] tests/cvl_switch_filter:update class name and instance Packet class Jianwei Mei
@ 2020-07-29  8:20 ` Lu, Nannan
  2020-08-12  5:58 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Lu, Nannan @ 2020-07-29  8:20 UTC (permalink / raw)
  To: Mei, JianweiX, dts; +Cc: Mei, JianweiX

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Jianwei Mei
> Sent: Tuesday, July 28, 2020 2:33 AM
> To: dts@dpdk.org
> Cc: Mei, JianweiX <jianweix.mei@intel.com>
> Subject: [dts] [PATCH V1] tests/cvl_switch_filter:update class name and instance
> Packet class
> 
> 1. Suite TestSuite_cvl_dcf_switch_filter.py and TestSuite_cvl_switch_filter.py
> have the same class name, lead to logs generated in one log file.
> 2. Class packet have not instantiated.
> 
> Signed-off-by: Jianwei Mei <jianweix.mei@intel.com>
> ---
>  tests/TestSuite_cvl_switch_filter.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_cvl_switch_filter.py
> b/tests/TestSuite_cvl_switch_filter.py
> index 01a2842..5dc7d21 100644
> --- a/tests/TestSuite_cvl_switch_filter.py
> +++ b/tests/TestSuite_cvl_switch_filter.py
> @@ -2487,7 +2487,7 @@ tvs_mac_ipv6_tcp_non_pipeline_mode = [
> 
>  test_results = OrderedDict()
> 
> -class SwitchFilterTest(TestCase):
> +class CVLSwitchFilterTest(TestCase):
> 
>      def set_up_all(self):
>          """
> @@ -2506,6 +2506,7 @@ class SwitchFilterTest(TestCase):
>          src_file = 'dep/testpmd_cmds_rte_flow_fdir_rules'
>          self.dut_file_dir = '/tmp'
>          self.dut.session.copy_file_to(src_file, self.dut_file_dir)
> +        self.pkt = Packet()
> 
>      def set_up(self):
>          """

Acked-by: Nannan Lu <nannan.lu@intel.com>

> --
> 2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/cvl_switch_filter:update class name and instance Packet class
  2020-07-27 18:33 [dts] [PATCH V1] tests/cvl_switch_filter:update class name and instance Packet class Jianwei Mei
  2020-07-29  8:20 ` Lu, Nannan
@ 2020-08-12  5:58 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2020-08-12  5:58 UTC (permalink / raw)
  To: Mei, JianweiX, dts; +Cc: Mei, JianweiX

> > 1. Suite TestSuite_cvl_dcf_switch_filter.py and TestSuite_cvl_switch_filter.py
> > have the same class name, lead to logs generated in one log file.
>  >2. Class packet have not instantiated.
> > 
> > Signed-off-by: Jianwei Mei <jianweix.mei@intel.com>
> > ---
> >  tests/TestSuite_cvl_switch_filter.py | 3 ++-
> Acked-by: Nannan Lu <nannan.lu@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-27 18:33 [dts] [PATCH V1] tests/cvl_switch_filter:update class name and instance Packet class Jianwei Mei
2020-07-29  8:20 ` Lu, Nannan
2020-08-12  5:58 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox