From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 641DFA0C53; Wed, 3 Nov 2021 11:39:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 34B1B41134; Wed, 3 Nov 2021 11:39:20 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 2A3EC410E5 for ; Wed, 3 Nov 2021 11:39:17 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10156"; a="255095516" X-IronPort-AV: E=Sophos;i="5.87,205,1631602800"; d="scan'208";a="255095516" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 03:39:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,205,1631602800"; d="scan'208";a="449744434" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga006.jf.intel.com with ESMTP; 03 Nov 2021 03:39:16 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 3 Nov 2021 03:39:16 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 3 Nov 2021 03:39:16 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 3 Nov 2021 03:39:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mZVKrcica70BqoRUvlb9x5mi4qPD9li6THnNFJqJeR8cG1G68rdVWmU7qgye0/7tZ/cKHhHurUTzG2aAO1ckWtEVONV7De9OspZDSrSlhkEVxBU7/mQcuuYJCB/pZknkRdamhktB8KZKaBzgMeKbXgIfGH84tia3tmLPZX54kCD1l2sYEqYdc8J7qKKoqmtECYbEcmQaMiloMmpAB0wQj9dsp9oQUbukRIvztqUJOs4839XwZcH1x9oRgindscet1VFOx+9KSKAVqs1PPlvJU6oJ3pyFgRnGTzC1PaK3JFSVgPh0YatnM1UqjPSC9Lu7InNY5Cssg1b73ZxNirVLnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CkSvBNxqiI11oni2VO2ULiOdA66bwKzhtRaLaiUPjxI=; b=DlnBZQ0qEh6PjWhXy8DJOPyTEI169uj09SrcigBgPJ7Sx0xQkrAgPtydsblL9HVD8C+dLKAx8a20TqDh9AxPxiExCG03AznqOMzvZuq6RZ0E5VLtTOQVJ3NcbAmieRLp8nLItp2QinAqTKONr2K9XNeFA5u/BU2Q0BGYIhKq28Ejiav8a7IOM+oFJMLZDf+kqCkueRmhh6IH1aOTm3lmzF3hTQGz47axjrl9JU+6lEejOiU0FJts8JBcPOPFx0+31icc/Jh74UEyDGXuDhRBwJ3x7X2dUUCYawFZkfpx1empk7WfQU01NHZThML/fNAG4eY6Y5kanfGacqtI7rh1Bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CkSvBNxqiI11oni2VO2ULiOdA66bwKzhtRaLaiUPjxI=; b=krJeBWEQ33c8OZbbC6zsHp7eUdIvEyHThxRmU5OmQZSVvMJjTjw+ZqZMkFI6IQz1ke39d7ySwfAdZrvEjv0M49HdhEUfBETMgSM0R+mbBDBFiJBfH37/z+IFnxw6v6do+OraWQqG6QU46NydsU1X6EOpMWDIjFXOkEqcX/Won/o= Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by DM6PR11MB3770.namprd11.prod.outlook.com (2603:10b6:5:13c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Wed, 3 Nov 2021 10:39:14 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::2c0c:5383:f814:3b4e]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::2c0c:5383:f814:3b4e%6]) with mapi id 15.20.4649.020; Wed, 3 Nov 2021 10:39:14 +0000 From: "Ananyev, Konstantin" To: "Huang, ZhiminX" , "dts@dpdk.org" CC: "An, XiangX" Thread-Topic: [dts] [PATCH V1 4/4] tests/unit_tests_eal: modify code to adapt avx512 Thread-Index: AQHXz7UPTbRcnffHcUGptd0XJAt2wqvwDRnggAAJnYCAAAHwsIABB8QAgAB9XZA= Date: Wed, 3 Nov 2021 10:39:14 +0000 Message-ID: References: <1635835398-70543-1-git-send-email-xiangx.an@intel.com> <1635835398-70543-4-git-send-email-xiangx.an@intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 68c06707-980b-43ce-91e6-08d99eb62e1d x-ms-traffictypediagnostic: DM6PR11MB3770: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cTAYrRNZjOg6dVmS46uDHpXRE4yaqoH07dAgfYRXN5Yt4KyNE7P7AxoS1nJGVNCANcHoujIu6IOkUUq+XmSu1ZTI8JuR8QK5U5RBB5si0py1wynp9mOy+WKJncgHDQgyAA4nNqgd34b4sS5j+a6E8+eQ6vwDCyTV9q+xsrPyLWWb4R8Vng79pxPrKNL3RXkSzg95lUZaeFgx+7kat4FCH2yk2tu0ra6eJC6B1uit+UnXLeiRiOSf8Tre6oUMARHq7KVjLNouRJW8Zt0476msEOw4XgnuwrD1SY7ecjx00HUOYCYkLdVHauvsM1Smo1tTiy5ZlM2eXm+yCFY4J40KosbklYmFi55RX0TlXrRIrQWAZjFtxXGptrRYnp7rOhR0eqhvujQ8f0pJBTK5y40WDfDQ6xnWoNitYV8fqJ3a6pylEp/44zLY785nKVSOGfmteihRX4shd1VRwiaBHNLdOJIKCbVq1N/msyA/tVFoUdDeZovpwUbBgECZD/fF2UNetbMgHTgkwNx4iRTKkCVUS5FN9jqHF2Z1tan+U+90Ez+sfHW9f1l4cPv/706aN09M553pIvl0AEqtXmeM/RFoviYCsiagxz8b/FB2epwQem5kxu3q4r9EqpPNRWua8Pavv1wd4+tVHa6jbtUMu7x8cefXtd81dc7tY0PHJ4FYJ3qwVz5l85isW0+9cZge0COj9oLLV9/XV8gVjmgOh+W6QQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(38070700005)(52536014)(2906002)(107886003)(5660300002)(86362001)(82960400001)(26005)(83380400001)(71200400001)(110136005)(55236004)(186003)(508600001)(76116006)(66476007)(66946007)(55016002)(64756008)(66556008)(8676002)(66446008)(38100700002)(7696005)(6506007)(122000001)(9686003)(33656002)(4326008)(8936002)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RD6isIuY1XbnJtyyqlytUIiFxDBbSoyJ6/eTKiOwQw4kmtcSKxpV+LEMlr4u?= =?us-ascii?Q?rLvnNvlfkkx1/Cyt8obcMgxPSt6yP+DZdYK7AIbTvdt3eAxJ6kVDjyb2w/rO?= =?us-ascii?Q?DXK4Th44AbPM/JOGuUldM3VkQXUpn+O9EKVk0nZyCkcgQnMgM35oke93eIA3?= =?us-ascii?Q?FCuWeD16QommRa/GHFCB/rZP5Scb7Oy9NMrsazb0N5WFGRL17xZ8W/WGdq5b?= =?us-ascii?Q?oniA9kYWMHjeP05K1934v9Ty1IykGNr08/xvVIa0AxsfXsLyr6f0f+j8Psta?= =?us-ascii?Q?JCK7N7Jt/U+AhEZFGSsir1fn1Y5E2UR6260BOzdUxcLqKwto47jBqZHt6gJH?= =?us-ascii?Q?YZ8JHD4CrFn5Mw3Q5phlGwW3Jz0tcD+h11Ao2iQmIfJpFkN1aPr8KY74Unsa?= =?us-ascii?Q?sYVbjLNgPVYcZxPC+wgCj98U90jpOgAL1u7xp4jPZg0eN/XpbqnVQzF6Bb2S?= =?us-ascii?Q?9NLoKxSx9GAC7AjnbpKQJLMx92ZiU9j5+fUeiRGh7pRhjSgsP3Sps+2vb3vo?= =?us-ascii?Q?5gILoZTncoM5jSCDiyp2sW/bprbXltQMLE/ghCPuVI6e+4pSrKK30rltjXgb?= =?us-ascii?Q?+HUen4ziNbxJX8OahJjkBa8DKAMqqMSn4vv9xiOKCAp8hJ6PaG2OCeDhA9zz?= =?us-ascii?Q?d94+qPGmpmjI9ikWxEvVEzlgYbQ1UztY8CqMEH+4Q4U/DbNo5SvqR9P1LXmL?= =?us-ascii?Q?qbea1GKspzdLbluWpwd/coAe/WyorlrC/mwGw6XYyNwB/Ic7MmUaQo3lKwvX?= =?us-ascii?Q?iOnNSfe70dk22aOUc2rIm3HbpuoSq2mylak+Nr4gAVOEFO8nZ4kSwnp5lAo6?= =?us-ascii?Q?/eUj4Fz0+Z44r23gcCphiszPJU1AiVjhjctb7a/JoQIHQaOdOtybwR4Pdovl?= =?us-ascii?Q?GBD3AQvQqBrfn2aEHm71MdPmZqIJ+CgKr6ePqjeWKioCe/vxzgwnbzCazefZ?= =?us-ascii?Q?NVQoRTIplKotNYtuc0LhjSEMHgj+6bAD0vw8QNUuldivs5AX00EovJc/SVwT?= =?us-ascii?Q?HekpnbVhpYS/hrvNmfKqYTzyk/NkehR7dgYdVwCeX8rS0e+SAN4mc5Nhg7Jw?= =?us-ascii?Q?O5IkSeI49o+Is8Jkkos6AYsDcZHVhITWXyjCEdg2AabhWael5RRWVRGC2yZA?= =?us-ascii?Q?Ak+6ABiyRxdkyTfWYIxvZeII6THyNJho+hbQQxWjAMn60dNvmCJ98bkA0x7p?= =?us-ascii?Q?+jSWLOBQgRR9HE0JBgpCY4/yrbfbkpI3lTmaIUFzuOaBS4OVUpbfcxa12jFu?= =?us-ascii?Q?p/heGDJPsCsIcCmoxlSG0XqflDUcQe0khPXrzd7LSnfEdN+dMhnh5ot0GG5Y?= =?us-ascii?Q?pyEJ1F1Fm3rrnSYpwL4dmijhBc6ARuv2z26BEQCu2w135ywf2xhMegcMt5f0?= =?us-ascii?Q?9R4tYQOcNpet7zPR4uAiE2AyOJccmBh/nIvgSWFtMl2H2/rfRSZoH8ILP/aW?= =?us-ascii?Q?xYAOIYlcWHW5/8VjbGuU8nbLmfDVyvdBZlOEbVQhexkVISH+K6Aosj2kEyfE?= =?us-ascii?Q?o3EcimgDjtPesXirquJnjBi5Vqer8sHaIIU4D/peRK0SSTMNFt7VSwrxPxSI?= =?us-ascii?Q?NrBBKtba5pAyTaNacLvkprvuxYlaUsQmOZHDnJy4JCv+m1QGth5szgHz4GcM?= =?us-ascii?Q?k6taaEwriFY3ZjLabrKmzh1Yu+ytgKZCm8zQicrn7yLQr+4juJVB9axc/khE?= =?us-ascii?Q?Q/0HbA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68c06707-980b-43ce-91e6-08d99eb62e1d X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2021 10:39:14.3462 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UPQfwEalRNjj5NsKhnaKwl+0Ps3GpxLwxxBzIrV8kTG7VO7YsILIEgD5NwouUjNRDmllyEuxCZZugcUs/i8En22vI2IjHJKioQt+bHJvDaA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3770 X-OriginatorOrg: intel.com Subject: Re: [dts] [PATCH V1 4/4] tests/unit_tests_eal: modify code to adapt avx512 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" > > > > > > Hi Xiang, > > > > > > > > > Modify code to adapt rxmod avx512. > > > > > > > > > > Signed-off-by: Xiang An > > > > > --- > > > > > tests/TestSuite_unit_tests_eal.py | 5 +++-- > > > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/tests/TestSuite_unit_tests_eal.py > > > > b/tests/TestSuite_unit_tests_eal.py > > > > > index 8096183..b5cb7a2 100644 > > > > > --- a/tests/TestSuite_unit_tests_eal.py > > > > > +++ b/tests/TestSuite_unit_tests_eal.py > > > > > @@ -38,7 +38,7 @@ EAL autotest. > > > > > > > > > > import framework.utils as utils > > > > > from framework.test_case import TestCase > > > > > - > > > > > +from framework.settings import load_global_setting, > > > > DPDK_RXMODE_SETTING > > > > > # > > > > > # > > > > > # Test class. > > > > > @@ -462,7 +462,8 @@ class TestUnitTestsEal(TestCase): > > > > > self.test_app_cmdline +=3D "--no-pci" > > > > > > > > > > if self.dut.dpdk_version >=3D '20.11.0': > > > > > - self.test_app_cmdline +=3D " --force-max-simd-bitwid= th=3D0" > > > > > + if load_global_setting(DPDK_RXMODE_SETTING) =3D=3D > > 'default': > > > > > + self.test_app_cmdline +=3D " > > > > --force-max-simd-bitwidth=3D0" > > > > > > > > Could you probably explain why it is needed here? > > > > > > > > > self.dut.send_expect(self.test_app_cmdline, > > > > > "R.*T.*E.*>.*>", > > > > self.start_test_time) > > > > > out =3D self.dut.send_expect("acl_autotest", "RTE>>", > > > > self.run_cmd_time) > > > > > self.dut.send_expect("quit", "# ") > > > > > -- > > > > > 1.8.3.1 > > > > > > Hi Konstantin, > > > We have add this case to test avx512 mode, if this judgment is not ad= ded, the > > cmdline will invalid. > > > > > > Take a example: > > > x86_64-native-linuxapp-gcc/app/test/dpdk-test -l 1,2,3,4 -n 4 > > > --file-prefix=3Ddpdk_237965_20211103034106 --force-max-simd-bitwidth= =3D512 > > > --no-pci --force-max-simd-bitwidth=3D0 > > > > > > > So DPDK_RXMODE_SETTING controls whether '--force-max-simd-bitwidth' is > > set or not? > > If so, can we then just override it here for this test-case? > > I'd like this test-case to always run with '--force-max-simd-bitwidth= =3D0'. > > That way it provides best possible coverage. > > > > > So according your decription, in any avx mode should be excuted '--force-= max-simd-bitwidth=3D0'? Yes, basically '--force-max-simd-bitwidth=3D0' says use max available SIMD = on that box. So on machine with avx512 it will test: avx512, avx2, sse, scalar. On machine with avx2 only it will test: avx2, sse, scalar. ... > If so, I will re-submit dst patch to cover about acl test. Good, thanks.