From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0162FA00C4; Wed, 27 Jul 2022 05:26:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DEE3640E03; Wed, 27 Jul 2022 05:26:33 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id BB91440A89 for ; Wed, 27 Jul 2022 05:26:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658892392; x=1690428392; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=p/HVAMVyYjesjMcrJwR/0MH7gNGDh9J+SspT0IOo59U=; b=HhvHaIPWepMLaNUK1D+LQLu1+oBKzT4DoyofKEm787rw6497qv/BMu1W qTXKOhc/ce3gm7CPt8KkhJKGJfG5G8G9hyfe4AskamgQfrc7Nm53RpCeD cFgupboM7jdiJwdhRV3XD9ERMMFlXlkv2khjnb+RJYfaK6EeRniUfyYe1 DG/sGouMntUqBp8AS0nWhP2NnCUK1B5srtSja+/RodCpohjP4TFEFXkGY dTZArPmB2iUJ3cOqp0mMFSwtBveBhGX9WMZiQwYjXje+u61KjUTYnM71y FbkZr+yUstGkFyumA9BMe7r94UKeIlbB2G4ASCPf31lBpXEd1Kl8QQDoO w==; X-IronPort-AV: E=McAfee;i="6400,9594,10420"; a="288895330" X-IronPort-AV: E=Sophos;i="5.93,194,1654585200"; d="scan'208";a="288895330" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2022 20:26:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,194,1654585200"; d="scan'208";a="597272295" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga007.jf.intel.com with ESMTP; 26 Jul 2022 20:26:27 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 26 Jul 2022 20:26:27 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Tue, 26 Jul 2022 20:26:27 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Tue, 26 Jul 2022 20:26:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JmSi/dEBPREejA5K7zxq+FXtW6VJKdBlelYwUJT/iuwPAMWgfwm2f4px7rBBNoHQDKRPGw7IJzb4+t3XEMs6puPydg6ULO7VEz8fq6FCDGj10obN0eoL4tLX0ASUPIc9F7g37TfFDaERM+k6w4Cx0bFaZF3XrAVA2DzXBsu+ea4H5TRso5HQxGY+AwffusnupyBGZFjZMF3NMxVYcc8gUQp4eZilMdfGsspcamh9QMCPW0C5wtyxgomu1bRCRYB5zDWShVbWL2UbcJCabi48ZqNpbSAyt6zGEBaFhqq/vH/TmbH/vOxA1WSJLpP+rDo4S/CRX/oy0tG5MaIdNA4ScA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eh2qtq0JU36Mtf4//FiZrJaOySPLkIk1YadCtKjV0mk=; b=UO1AkgKYFlKWfHB8n9uY1I4vkEfDs1imi7ykLT71WXt/KgGNSb/w7Lr5Gmj4+9VPNBCq5P5AAV40kpQVdlfqf4bnA2RN1EQvJGW5eORaKuqskPX2jLHtAiSNHoxlYj1UFEaJP6f6y9ITeSjh8mL/ny54mNNI7eSWJKokz92le5jvDKMfuXeXU0nmz4cwncwBgyVWZdT33cq94r3PZ0kBlLNOXtPz7Wvqx6vD4gs65z9MrR/XoQlvNl+bK1I/7xYOtZ7L0fFFSPVVBVjLvHIqdB7Lk4v6f6I/imy9wLKS7NAiAgmxgV2eYwuYCCxnyAysZ3SBFlsL1U3O6SJw9xwxTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4611.namprd11.prod.outlook.com (2603:10b6:5:2a5::11) by DM6PR11MB4282.namprd11.prod.outlook.com (2603:10b6:5:1db::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.20; Wed, 27 Jul 2022 03:26:25 +0000 Received: from DM6PR11MB4611.namprd11.prod.outlook.com ([fe80::5da3:d5b7:3d15:9723]) by DM6PR11MB4611.namprd11.prod.outlook.com ([fe80::5da3:d5b7:3d15:9723%5]) with mapi id 15.20.5458.025; Wed, 27 Jul 2022 03:26:25 +0000 From: "Fu, Qi" To: "Xu, Ke1" , "dts@dpdk.org" CC: "Fu, Qi" Subject: RE: [dts][PATCH V1 2/2] tests/tso: modify get_chksum_value_and_verify to improve the execution efficiency Thread-Topic: [dts][PATCH V1 2/2] tests/tso: modify get_chksum_value_and_verify to improve the execution efficiency Thread-Index: AQHYnMkMXWpCGWysaEamyBa5g1m+2K2Rl5bw Date: Wed, 27 Jul 2022 03:26:25 +0000 Message-ID: References: <20220721061314.984469-1-ke1.xu@intel.com> <20220721061314.984469-2-ke1.xu@intel.com> In-Reply-To: <20220721061314.984469-2-ke1.xu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ab0766ef-a617-4063-b1ab-08da6f7fc94d x-ms-traffictypediagnostic: DM6PR11MB4282:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5ZaZw3+jRUhA4GBuNUqkOEs3A9dJtl90bW+ay9bWYBM6ogDpgwaRZORZHfru7kWS3YliTnklvmYjbskx9G4K/ofYLWA3CSwMfJgNpfvgZdI11fQ1DKvNb+MLi/f7HoYPPdm3M4d9jD4r3m1km8Xk9TTNX9DUYbclEc2Mm2aC/CpXEVoSBK8IjTQfhkzWmV2FE/tdSBuRXjrCxSoMo79Z6sqwiYT9lSEEbt6CJvgPlpgCf/+Nq7DW3EHVIDxFGdo92N3s2mVeqMK9/84xYCUIk1KQZOlAiJf9FSBTPfnROoSA0q4G1au3nXxtftjBObh2tPnpOCIlQlqaSTQsrxearDQEu989+7cFmMw/0isHk+E8HdEF2G3T2+3azy7Jpz535eHYPVTO0Vmr+lHyXONzt3UO1trjnR0tacyg1h4ccSPscQsnpsUYKsiYyITNQOaJjRbU/IdYVWn2jLWguMWajRxcbwJYbeWlvJWg5jsIBSiycF0AlJSyNsZlDb6fC4r+EtXBRMUCt3Uuts/1DSIryow9DqVHI3jvE2pADqNJmucexbENlkxctLavsKOXN7hR/SX/G+ZriKWXGgFe6xhS9Brlrperk+0qs/zfeaGBAS8fRM5bP7kRwN2F8cPR7dQ/DN2CMuJIc1mKty5hJWQIG8kV0QFQn2gfOu5JfKTjSAj+c9qmLH3Ft5ksZ5rmqnufBKUnovxUjcm7n7COopD4N+PlGoOvfwnEAzDRFmTCwkQoNaZbBH/JGqfApvDJk6XUce1n+aKo9FTf8XLkXBGrtLiuKJcJz5kfT49ooRSh9fTe0wMF6Gy0KWrcaCMvacnn x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4611.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(136003)(39860400002)(366004)(396003)(346002)(8676002)(5660300002)(4326008)(8936002)(316002)(110136005)(76116006)(86362001)(6506007)(66946007)(64756008)(9686003)(53546011)(66476007)(26005)(55016003)(478600001)(66446008)(66556008)(41300700001)(52536014)(7696005)(38070700005)(71200400001)(82960400001)(122000001)(107886003)(186003)(83380400001)(33656002)(38100700002)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?O4f62Il4XCUyk6ygZoy3tH/QwfTYYv4HbmXyj6EYoP6iJM3eqVVeX6pdBXyN?= =?us-ascii?Q?7/DfxfM/SSSpUmDwhkj/9fsPa0IKUgiyLbrQ96U14fC2Uj5Y8KWuijvwDFsf?= =?us-ascii?Q?aQHVkrlA8N1lCYUN/vf6LQPfFNf2BPzNyGapGpwPNsINsDxjz8pPBU1efVox?= =?us-ascii?Q?5p92+02b7keWS9meIaTl9l1TGlmQWA36FSXL652mEbRQzKXO86DvnXUhoq0m?= =?us-ascii?Q?za6qB8rAyeY0resOFVnUzfXUHZb7gzbVl2r/OUQbgtYJOnUhgRVFHjjxb5cU?= =?us-ascii?Q?U9JoNaLBQTe9KC7sfbQvWpolsaZJfP/wR2P95Zs1HllOvSicHL/w0sG3VNi+?= =?us-ascii?Q?IL1qdk6RaFGkfF9kfFMhYg31w9n9pNJnoMrM5u4s+RALZ/J9IK8NIG8tpNHi?= =?us-ascii?Q?A6OsW/39Ge71Wxm8dHlwuKMqC1EAXgdvMw4jHULt45CFmHlwiJY3/N34RO5Z?= =?us-ascii?Q?kP4cYktCexGIelr0m6lyPfb6KqpUpZiACDnvrDvU0LqZ1bAbpiT8FIvw9GbV?= =?us-ascii?Q?1dE+GPMr+oXUnjrRn2JR5RrD5YUYjYvbEEgtPmseq4mTY+A0+r0UWTxKdSAX?= =?us-ascii?Q?8pGpMGXddwTuV4vj4URGIx3/XSUrAYbceivv9psNZHwYx0p+Zr264HvWOT8e?= =?us-ascii?Q?YqTArd6ltoDOnpzUajUxz1ZzpY90B7xpVlOet+HEmLp8AvR2oXqkMTSVrqQo?= =?us-ascii?Q?5+V1hM3oadi6y1xPWIV/Yvn4pXQA1QZOAj7Fa9fCS9NjaArcylWsjuT89v8+?= =?us-ascii?Q?8Df5oG2ADCoagfwCpekMTgwT7yFywPhwSfYpSBQ/OjCWuHbQ/KHuRWwGBUmQ?= =?us-ascii?Q?HoFr+qRkgWFEXP1bZYbRpO0V9D4x50yvQVNxrLwx7q1S3yIaiZOF6ngTaTCS?= =?us-ascii?Q?RBlrHBgGfdS+uP+hqPLMkYT+HT2W66RxGO2btzHVvOie1vxnhAYel0fW0VeK?= =?us-ascii?Q?XbNbcSWytK+teT/xnhRGO1/Hv+doXCaLCcJPxIZ9ewO1ddAeiboHIGjoez5w?= =?us-ascii?Q?h2wiNxKu5DJ5XA7yFM5+kOj92kQnfHDjNfQHdbPgyLUwh6qJcBAIcT8rw1AE?= =?us-ascii?Q?6TchfMj4dfRegOBv7MsgObHjczWp18ErZSpg6+3O3HFj7jFHhD/CVVBpWr86?= =?us-ascii?Q?QedLdHHTuiDDXMxqH5bdY52cXE+KwH4Ef7dRXIdr8FGSIN4w6o24cgWSlxIk?= =?us-ascii?Q?d6GDzswG5RXUSH1yfA45gUNW40QC0raMsp/farCc3v3nwj3gjpnXBejW53/J?= =?us-ascii?Q?39YSHDI02nMao6c3VAfE+jJQRNkvQs+SS1JuBEHzkjXHSr/NePG1wKYejJbO?= =?us-ascii?Q?/L++SKs4wNxaorrK/cqYm+fFuZSW8jiuyfbe7lMDe1MJPh1nRH6/+Uj8TrA5?= =?us-ascii?Q?Ol1YWzQGoVoCNYGrxK/nouLfjnp7/Ried0EGreqY2wXVK9pzcFWqBdRTTEup?= =?us-ascii?Q?a6gqLtJAXDES3/NCRDqBra1CvHdTTXzIXAI0t0p3dX8XONq/vVNMLPn/cKZb?= =?us-ascii?Q?6todXiVWqz+WhQNbgEVNilxV2CNVtaR/Hr3u2duS7UoGZ+q/qbL9MuRqe7V4?= =?us-ascii?Q?9AfIye08RHRN1QIFSic=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4611.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab0766ef-a617-4063-b1ab-08da6f7fc94d X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 03:26:25.4563 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jb8Y1JGWTEUAGypmRmGxjxG9/MJWgwLiCaIBm9Uhil6JcqjtgLj0oPNdxPBURk8q X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4282 X-OriginatorOrg: intel.com X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Acked-by: Fu, Qi > -----Original Message----- > From: Xu, Ke1 > Sent: Thursday, July 21, 2022 2:13 PM > To: dts@dpdk.org > Cc: Fu, Qi ; Xu, Ke1 > Subject: [dts][PATCH V1 2/2] tests/tso: modify get_chksum_value_and_verif= y to > improve the execution efficiency >=20 > Function "get_chksum_value_and_verify" in test suite TSO case > test_tso_tunneling is of low efficiency. Methods are wrongly used. >=20 > Duplicated call to method "packet.read_pcapfile" in this function will le= ngthen > the packet sequence stored in "packet.pktgen.pkts", consuming more time w= hen > save pcap file. Duplicated call to method "packet.save_pcapfile" is also = time > consuming. >=20 > Method "pks.show" and "self.pks1[i].show" is not used as expected. "*.sho= w" is > used to print the packet object, not intended to return a string. Current= code is > actually getting a method object and using "str(*)" method to turn a meth= od > object to a string, this may fail when "*.show" method is updated. The pa= cket > information printing here is equivilant to "repr(pks)". >=20 > Signed-off-by: Ke Xu > --- > tests/TestSuite_tso.py | 25 +++++++++++++++---------- > 1 file changed, 15 insertions(+), 10 deletions(-) >=20 > 2.25.1