[dts][PATCH V1 1/2] tests/checksum_offload: checksum suite script and testplan optimization

[dts][PATCH V1 1/2] tests/checksum_offload: checksum suite script and testplan optimization

[Weiyuan Li]

Optimize the test case name to match test plan, add test case in test
plan to map test suite and delete the cmd "tx_checksum set 0x0 0" using "csum set".

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---
 tests/TestSuite_checksum_offload.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py
index 3554f5eb..3680db11 100644
--- a/tests/TestSuite_checksum_offload.py
+++ b/tests/TestSuite_checksum_offload.py
@@ -604,7 +604,7 @@ class TestChecksumOffload(TestCase):
         # send the packet checksum value different from the expected value
         self.checksum_valid_flags(pkts_bad, 0)
 
-    def test_checksum_offload_enable(self):
+    def test_insert_checksum_on_the_transmit_packet(self):
         """
         Insert IPv4/IPv6 UDP/TCP/SCTP checksum on the transmit packet.
         Enable Checksum offload.
@@ -653,7 +653,7 @@ class TestChecksumOffload(TestCase):
 
         self.verify(len(result) == 0, ",".join(list(result.values())))
 
-    def test_checksum_offload_disable(self):
+    def test_do_not_insert_checksum_on_the_transmit_packet(self):
         """
         Do not insert IPv4/IPv6 UDP/TCP checksum on the transmit packet.
         Disable Checksum offload.
-- 
2.25.1

[dts][PATCH V1 2/2] test_plans/checksum_offload: checksum suite script and testplan optimization

[Weiyuan Li]

Optimize the test case name to match test plan, add test case in test
plan to map test suite and delete the cmd "tx_checksum set 0x0 0" using "csum set".

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---
 test_plans/checksum_offload_test_plan.rst | 27 ++++++++++-------------
 1 file changed, 12 insertions(+), 15 deletions(-)

diff --git a/test_plans/checksum_offload_test_plan.rst b/test_plans/checksum_offload_test_plan.rst
index 45f081b0..7f51cc1f 100644
--- a/test_plans/checksum_offload_test_plan.rst
+++ b/test_plans/checksum_offload_test_plan.rst
@@ -71,16 +71,17 @@ Set the verbose level to 1 to display information for each received packet::
 
   testpmd> set verbose 1
 
-Test Case: Validate checksum on the receive packet
-==================================================
+Test Case: checksum offload with vlan
+=====================================
 
 Setup the ``csum`` forwarding mode::
 
   testpmd> set fwd csum
   Set csum packet forwarding mode
 
-Start the packet forwarding::
+Enable the IPv4/UDP/TCP/SCTP checksum offload on port 0::
 
+  testpmd> csum set 0xf 0
   testpmd> start
     csum packet forwarding - CRC stripping disabled - packets/burst=32
     nb forwarding cores=1 - nb forwarding ports=10
@@ -89,21 +90,17 @@ Start the packet forwarding::
     TX queues=1 - TX desc=512 - TX free threshold=0
     TX threshold registers: pthresh=32 hthresh=8 wthresh=8
 
-Configure the traffic generator to send the multiple packets with the following
-combination: good/bad ip checksum + good/bad udp/tcp checksum.
+Configure the traffic generator to send the multiple packets with vlan for the 
+following combination: IPv4/UDP, IPv4/TCP, IPv4/SCTP, IPv6/UDP, IPv6/TCP.
 
 Except that SCTP header + payload length must be a multiple of 4 bytes.
 IPv4 + UDP/TCP packet length can range from the minimum length to 1518 bytes.
 
-Then verify that how many packets found with Bad-ipcsum or Bad-l4csum::
-
-  testpmd> stop
-  ---------------------- Forward statistics for port 0  ----------------------
-  RX-packets: 0              RX-dropped: 0             RX-total: 0
-  Bad-ipcsum: 0              Bad-l4csum: 0
-  TX-packets: 0              TX-dropped: 0             TX-total: 0
-  ----------------------------------------------------------------------------
+Then verify that the same number of packet are correctly received on the traffic
+generator side. And IPv4 checksum, TCP checksum, UDP checksum, SCTP CRC32c need
+be validated as pass by the IXIA.
 
+The IPv4 source address will not be changed by testpmd.
 
 Test Case: Insert IPv4/IPv6 UDP/TCP/SCTP checksum on the transmit packet
 ========================================================================
@@ -115,7 +112,7 @@ Setup the ``csum`` forwarding mode::
 
 Enable the IPv4/UDP/TCP/SCTP checksum offload on port 0::
 
-  testpmd> tx_checksum set 0xf 0
+  testpmd> csum set 0xf 0
   testpmd> start
     csum packet forwarding - CRC stripping disabled - packets/burst=32
     nb forwarding cores=1 - nb forwarding ports=10
@@ -147,7 +144,7 @@ Setup the ``csum`` forwarding mode::
 
 Disable the IPv4/UDP/TCP/SCTP checksum offload on port 0::
 
-  testpmd> tx_checksum set 0x0 0
+  testpmd> csum set 0x0 0
   testpmd> start
     csum packet forwarding - CRC stripping disabled - packets/burst=32
     nb forwarding cores=1 - nb forwarding ports=10
-- 
2.25.1

RE: [dts][PATCH V1 2/2] test_plans/checksum_offload: checksum suite script and testplan optimization

[Fu, Qi]

> -----Original Message-----
> From: Weiyuan Li <weiyuanx.li@intel.com>
> Sent: Monday, July 18, 2022 4:26 PM
> To: dts@dpdk.org
> Cc: Li, WeiyuanX <weiyuanx.li@intel.com>
> Subject: [dts][PATCH V1 2/2] test_plans/checksum_offload: checksum suite
> script and testplan optimization
> 
> Optimize the test case name to match test plan, add test case in test plan to
> map test suite and delete the cmd "tx_checksum set 0x0 0" using "csum set".
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
> ---
>  test_plans/checksum_offload_test_plan.rst | 27 ++++++++++-------------
>  1 file changed, 12 insertions(+), 15 deletions(-)
> 
> 2.25.1
Acked-by: Fu, Qi <qi.fu@intel.com>

RE: [dts][PATCH V1 2/2] test_plans/checksum_offload: checksum suite script and testplan optimization

[Chen, LingliX]

> -----Original Message-----
> From: Weiyuan Li <weiyuanx.li@intel.com>
> Sent: Monday, July 18, 2022 4:26 PM
> To: dts@dpdk.org
> Cc: Li, WeiyuanX <weiyuanx.li@intel.com>
> Subject: [dts][PATCH V1 2/2] test_plans/checksum_offload: checksum suite
> script and testplan optimization
> 
> Optimize the test case name to match test plan, add test case in test plan to
> map test suite and delete the cmd "tx_checksum set 0x0 0" using "csum set".
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
> ---

Tested-by: Lingli Chen <linglix.chen@intel.com>