From: "Fu, Qi" <qi.fu@intel.com>
To: "Xu, Ke1" <ke1.xu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Fu, Qi" <qi.fu@intel.com>
Subject: RE: [dts][PATCH V1 1/2] tests/tso: modify get_chksum_value_and_verify to fix a checksum-verify error
Date: Wed, 27 Jul 2022 03:25:08 +0000 [thread overview]
Message-ID: <DM6PR11MB4611CEED4970BD4FEB867F29EA979@DM6PR11MB4611.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220721061314.984469-1-ke1.xu@intel.com>
Acked-by: Fu, Qi <qi.fu@intel.com>
> -----Original Message-----
> From: Xu, Ke1 <ke1.xu@intel.com>
> Sent: Thursday, July 21, 2022 2:13 PM
> To: dts@dpdk.org
> Cc: Fu, Qi <qi.fu@intel.com>; Xu, Ke1 <ke1.xu@intel.com>
> Subject: [dts][PATCH V1 1/2] tests/tso: modify get_chksum_value_and_verify to
> fix a checksum-verify error
>
> Function "get_chksum_value_and_verify" in test suite TSO case
> test_tso_tunneling cannot verify checksum error.
>
> This function uses the auto checksum calculation of scapy by reading the pcap
> file, erasing the checksum and writing back to a new pcap file. Duplicated call to
> method "packet.read_pcapfile" at line 149 and line 162 will append extra
> packets to the packet sequence stored in "packet.pktgen.pkts". And erasing the
> checksum at line 153 to line 160 will modify the appended packets.
> This leads to a wrongly organized packet sequence writen to file at line 161,
> causing the checksum verifying wrongly use the raw checksum as the corrected
> checksum. This fails the following checksum verifying.
>
> By removing duplicated method call at line 149 and creating new object for
> temporary use at line 162. This bug is fixed.
>
> Signed-off-by: Ke Xu <ke1.xu@intel.com>
> ---
> tests/TestSuite_tso.py | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> 2.25.1
next parent reply other threads:[~2022-07-27 3:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220721061314.984469-1-ke1.xu@intel.com>
2022-07-27 3:25 ` Fu, Qi [this message]
[not found] ` <20220721061314.984469-2-ke1.xu@intel.com>
2022-07-27 3:26 ` [dts][PATCH V1 2/2] tests/tso: modify get_chksum_value_and_verify to improve the execution efficiency Fu, Qi
2022-08-23 5:59 [dts][PATCH V1 0/2] tests/tso: modify get_chksum_value_and_verify to fix a checksum-verify error and improve the performance Ke Xu
2022-08-23 5:59 ` [dts][PATCH V1 1/2] tests/tso: modify get_chksum_value_and_verify to fix a checksum-verify error Ke Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB4611CEED4970BD4FEB867F29EA979@DM6PR11MB4611.namprd11.prod.outlook.com \
--to=qi.fu@intel.com \
--cc=dts@dpdk.org \
--cc=ke1.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).