From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 670DAA00C4; Wed, 27 Jul 2022 05:25:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6280B40E03; Wed, 27 Jul 2022 05:25:28 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 9A6DB40A89 for ; Wed, 27 Jul 2022 05:25:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658892326; x=1690428326; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=4OWaYAcy1f3Wagklq7Z2HldVq317xc8y5UA8ihKrdWE=; b=OVmqQd1r61ktwe1hlNNkRy9hyLwa/5HR+06G2+eIZSvFWbQpeLbu56FY Wl9XmT4wRZd8j3/aNXdjvCl6/VPvdQsViV44Gpohw45n7sZLaqB+yAhbo aMPbC3zE439laWUU0IJu5WLx4tCFFjvSuGHTfPVB/eJHP7RYC0rCPcSYQ M6pGf4eVsNdyB+I0CtpLGWS2R5ubPOL/m4ytaKDMKaPyjMI6fRsmk+3hh uQNrakdrTv0wn17cb5VFUFuGQkPkq34ph9n/1Vk71PkZMqOB4/Bpkjdpd cxKoMnY3tTUDojnZvyGT5y2Zfv+EGMGoT1pngHarxmzmg6wkXWKMgsuTE A==; X-IronPort-AV: E=McAfee;i="6400,9594,10420"; a="352127775" X-IronPort-AV: E=Sophos;i="5.93,194,1654585200"; d="scan'208";a="352127775" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2022 20:25:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,194,1654585200"; d="scan'208";a="600252102" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP; 26 Jul 2022 20:25:24 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 26 Jul 2022 20:25:16 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Tue, 26 Jul 2022 20:25:16 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.44) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Tue, 26 Jul 2022 20:25:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NyvSreWe1tiASqedoyfJBSdjR6xvUjYKk8nfmnz4TyELzpd9WwreoRaI6smLukOiD1kDgVuA/KoiUoDnmPPDAtR0y4EpOzl3E++vD7yW3Z7N7837R9lyULk4l9bxidQbHAKEfbKBMnV3M7+bxPtaUU6obMgxLDCylQDy12Fnb8XUlsENaaFqNXMcY0oKqG7aHdE0+hTSdjGNy6/0CQKaTV/S40L216leLsr82yPUqLsB961WaHD8gDT23n7+xA5GhZv6rQRwMBZ47gXIhr7O9pYbOt9SwbZmOxytIHWk5NN29hmBfhKD+xyQOqbM7LIOJkjFincdC4DuGWyJJMg2uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lP1HX8B/gMP/C6IymzsWtG2mFBUCc7dOJ68m6+iFUPo=; b=U5ACisCTstcMjj46G0p4n0sDG3q3h9ds6a3N4vO9yUiqQF9WIw4bJR9ohNujbR5UGaIg1rCXEL+1MjkzQQxry8kDUDll5NdVImYciob76LqEKlKBUAWyNNiiRrZY/jLLUp3SDjxVWyzqG+nxpGxZWJ0ezNt+j0dblwnFBbN0/WQlIXsgBqfFhCheMCR31pCRNruNcItRg3yMXGwxI8GnrKHcMYB374GMlqj+dRz5pFU5qVlHZ3NyhXK1mrT+ehWYyjNLQl1EotXl38tLg4ppAt4jEUkLujL8N8pf1mD6QGw8/YvQamJNTwpRSz8XNJJueU1MtloGhRifpa1cEGuLfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4611.namprd11.prod.outlook.com (20.180.253.75) by BYAPR11MB3063.namprd11.prod.outlook.com (20.177.225.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Wed, 27 Jul 2022 03:25:09 +0000 Received: from DM6PR11MB4611.namprd11.prod.outlook.com ([fe80::5da3:d5b7:3d15:9723]) by DM6PR11MB4611.namprd11.prod.outlook.com ([fe80::5da3:d5b7:3d15:9723%5]) with mapi id 15.20.5458.025; Wed, 27 Jul 2022 03:25:08 +0000 From: "Fu, Qi" To: "Xu, Ke1" , "dts@dpdk.org" CC: "Fu, Qi" Subject: RE: [dts][PATCH V1 1/2] tests/tso: modify get_chksum_value_and_verify to fix a checksum-verify error Thread-Topic: [dts][PATCH V1 1/2] tests/tso: modify get_chksum_value_and_verify to fix a checksum-verify error Thread-Index: AQHYnMkEYq/OwgmhFUimtBDSGipF6q2OocXw Date: Wed, 27 Jul 2022 03:25:08 +0000 Message-ID: References: <20220721061314.984469-1-ke1.xu@intel.com> In-Reply-To: <20220721061314.984469-1-ke1.xu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 30dab392-2b7a-45d8-4368-08da6f7f9b7b x-ms-traffictypediagnostic: BYAPR11MB3063:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: J1phNt21ITnON1nOmkb3yugaWGkXhh4VtWKITSlZh6pUnVb5L5Phidb7xhtl8kpyP/A1p8VLv+oENPX4PRiJ2NBGCsO5t2d5dcLB4GvlYdQHLlL2ROyMB3sSEUgsenFmS8YvdTsLKCEz0rAiFWbCSE4H2c3jQ/lWTwzvYGODdms3hym1Z7sIrbBn3+f1SyrTBakWUbVukE3csGSBGxsm2WXOis8s3rJCE2J7j+4fxOpJJmLndV7S4PRHJuscJcX4INhk8Meexau5EpYRgjJY5+mxP4naJNl4SWA7mLGDnIQRHEZttrXusQ4rBLt8iGhCXtnO3lKdKOJ63IP5kEUxFwOpagiYVogeBp3GrQ/NnbhdMOzBNJxOqFH2SHQ36H6TEgldKZf2kNGFTZv3wO+f/uIv6yF++eQhrrkK5Z89DGtOrxq4baMu92OEYwdiMJCki+JB7NGKTyzBuA8qEVBqVlAuJQQyUO4/12RdixZG1NxUjjac/prftb+aSTFRW6QOdsFPreYsluKDugy4wF23K/Q8kzYoqRGQK6XP4goDGB9d1FPO8ZE2/FfGrP8XijPEbj0tjh+9p4ZuuNHd2I3/9C8c6dGCDHdkkvf8GtQxG9QEvDMfiv3ojLjOZJDzrBSdOISq+pDZGmFPWxipOd2KPjbq/x7p9WKyQuaYPHGhSgt02KScuYE2vGaYZgdQYjZaF1ggxFBGoUujRChlVqBFKZXyX0P9jx2X3blCYuXTDST1/tY8F6FTlzcwLQUhdHGEZJHZpBEHAQ2zOf4Gjw9Njh+XroA6yTfVKNbqkRMHXv4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4611.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(376002)(346002)(39860400002)(366004)(396003)(66946007)(64756008)(8676002)(66556008)(76116006)(66476007)(8936002)(52536014)(66446008)(38100700002)(4326008)(55016003)(316002)(33656002)(26005)(9686003)(71200400001)(478600001)(41300700001)(107886003)(7696005)(6506007)(53546011)(110136005)(38070700005)(186003)(86362001)(122000001)(5660300002)(82960400001)(15650500001)(83380400001)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZpMPRxY+KvTe5yLhUgghBIukps37n7L3oeTmNN8vfMhjXxtUO3A/zBN7UrLf?= =?us-ascii?Q?d5DMhb0775VGqr7gxcIHfzUfvletHupElpE9iG/AFArH5GFpHqVu3Zzgqdio?= =?us-ascii?Q?28qH38S3+Od62uK0W9tbLN+M/45NjKkEYkPMIMuzewtQIXDmX972NRRRlESi?= =?us-ascii?Q?MtOkR4xLhmU09phODps4m9bI/TcUMVVFjVHh+5Qxp4Xu6yBEijlJx+7TN3UF?= =?us-ascii?Q?TQiFvAn+wP+HbrtHTFXoflIvrZHHOtu7TqvAiJfDiL/tG2utc6M73K+Xu4Qf?= =?us-ascii?Q?zxFFoLLOrExZCOQ/n68acOmZJqBdZG4fqzy6lhy4kFryNE1an7Ovcg87Yp9O?= =?us-ascii?Q?ThC6ZlfM4sAO1JCZ0o/skr1oPhXFmisU6fKaoYHGqZWKV6KvuwpmWXth/YXU?= =?us-ascii?Q?AaSJGVcUJt7rZPpuLQrgOGG8BRV+JnWfnNKX/Ndgtfi3cyh8zpi5l1PklriO?= =?us-ascii?Q?xGNfUGZJryNQooWJ/w5u9ESy9Cx9RJnUSFFbh+Zs3bF9fkyWsGfEwvPYREIQ?= =?us-ascii?Q?wEbrDkVY+Ls69sYYsX/c5EqZvyvnst+52gPuD8G/+5O7Rl1TcEQYFgOLLbSF?= =?us-ascii?Q?jDDXOG0/YRvBTdvtu/VF1YdmcPYliu8KQk6u3TFXkwLzHaYEALAiVoUxyOqB?= =?us-ascii?Q?Yz6+/hTgrjWaRZtbaLcQsREFrVNu6L2byj6cwcZIUs79o8b3m8BpZk5VCMJS?= =?us-ascii?Q?/dSDlsCl4m9NyqkZw29GR64Og0pDyPcHPjX/MmFeIwQuUx1/CxlXTnYOdeyE?= =?us-ascii?Q?YLrTa4xuq0hfpapuqtsNSmnrN8edS7dpkvtQ7FLOqlcJZxSc5IJiUbQDh7v0?= =?us-ascii?Q?lUSd1ayXDY3ad6ipS3jVPV+8kuhS6bOZngfHpxzYAcx+q98pHiHKoIc1OIff?= =?us-ascii?Q?92yyA/ADb1mLJ/lxNb2xOkULq5wIVKxXQifl4m/TU1Thru4HZrNANIYA9yaL?= =?us-ascii?Q?CDgAQXp6hNEqAJwuVPq8y7MfWw5dJhbpPgsyjC82t3FDddsmHerDNmVNoqAM?= =?us-ascii?Q?cZBnlNu6x4EUVy61DQ8t+uDqilj5FGTzwZ9+gHWUCjtFCt8xCNnUPLGodI/S?= =?us-ascii?Q?MW75PKKwylTBvEflCBWuXhmpDwtWW6aSvnfq2zPj4ABQLfYjRfwdP+fNZCL9?= =?us-ascii?Q?SRxjo8dOiNuHb66kHvkcioSRFaBL6CyX3CXD6oLqeDMkOTc7FU2Cmbzl6lyM?= =?us-ascii?Q?j413HKRLof/3K6JPi977ea5AFoeZw/2HKcUxI7+0nYkbg98x7Chg+9aHCh3+?= =?us-ascii?Q?mOD1XFD00+KiyJ6ftIYUonBKiK8zr3XrvMfrhURCJ5HZiJJMOEXna6ixvAQR?= =?us-ascii?Q?WQwKLzfvHb3xfHBu+J54Wfifzp5P5p+W26pn8ew7sEKpD0xY4FjVhxA7oL6F?= =?us-ascii?Q?HGyRbEtxVeRpVsxo3AgzlvUjJjzAOuSxB/Ha/GsQmu8bRNEOLX8fMiQFFNfM?= =?us-ascii?Q?U5sOyT9RUD4iOb54yy73LKEIVfiArYD+ezU1JctFH8ePeXhVXwbcxN2iWkAM?= =?us-ascii?Q?j0uVKab+CT7JdOasDzvGw7JzDYYhhIw5WF1GFHGwU/yBdRzEwb89HfP3f+5A?= =?us-ascii?Q?nZUCXiZuKEBRGbZ0zq4=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4611.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30dab392-2b7a-45d8-4368-08da6f7f9b7b X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 03:25:08.6110 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yMDbrRWwjB8oB/gt+K1n3UBLRGhvqlvL/amsNTk8237sAWht9cVT8bDnufvh7QKu X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3063 X-OriginatorOrg: intel.com X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Acked-by: Fu, Qi > -----Original Message----- > From: Xu, Ke1 > Sent: Thursday, July 21, 2022 2:13 PM > To: dts@dpdk.org > Cc: Fu, Qi ; Xu, Ke1 > Subject: [dts][PATCH V1 1/2] tests/tso: modify get_chksum_value_and_verif= y to > fix a checksum-verify error >=20 > Function "get_chksum_value_and_verify" in test suite TSO case > test_tso_tunneling cannot verify checksum error. >=20 > This function uses the auto checksum calculation of scapy by reading the = pcap > file, erasing the checksum and writing back to a new pcap file. Duplicate= d call to > method "packet.read_pcapfile" at line 149 and line 162 will append extra > packets to the packet sequence stored in "packet.pktgen.pkts". And erasi= ng the > checksum at line 153 to line 160 will modify the appended packets. > This leads to a wrongly organized packet sequence writen to file at line= 161, > causing the checksum verifying wrongly use the raw checksum as the correc= ted > checksum. This fails the following checksum verifying. >=20 > By removing duplicated method call at line 149 and creating new object fo= r > temporary use at line 162. This bug is fixed. >=20 > Signed-off-by: Ke Xu > --- > tests/TestSuite_tso.py | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > 2.25.1