From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D669DA00C2; Tue, 3 Jan 2023 07:05:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD48340693; Tue, 3 Jan 2023 07:05:53 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 286D240689 for ; Tue, 3 Jan 2023 07:05:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672725953; x=1704261953; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=edPv4WojeGOT4zrI8aanq6gXqJ0932pGOhfw7Gpck+A=; b=UAPR+EJzvkzbDiZvmhMvVtH6lNrFh7FV5rwqsR1Oyq+j++HkcWTAF4Md ccFIZxhkG8Q8E25u5VApbtoasiVqWdVHckfevQnLUkj8HQTQe6nx2kJdA RL3/k4B3JXemv53DqD9jJ1dgyhqIdlUpV6o9YS8bHT/fYzEqySPtAQCzK gNgY+snbJIzvQ2Aq4ifDqK2jzs3az5Pa/2Hiwe48coWuAj3ynEFVVYKui WaA/IrEygExB3qko9e+ekAXnqL1NJfBc3rocFyRfa0vyqoNcRy0/qJtMq EFND6/0AhUpyte5vwpv5oOP5jzIyUZ88rK0ne300jg1IFNsCTU11BxN8k w==; X-IronPort-AV: E=McAfee;i="6500,9779,10578"; a="319296984" X-IronPort-AV: E=Sophos;i="5.96,296,1665471600"; d="scan'208";a="319296984" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2023 22:05:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10578"; a="656653221" X-IronPort-AV: E=Sophos;i="5.96,296,1665471600"; d="scan'208";a="656653221" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP; 02 Jan 2023 22:05:48 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 2 Jan 2023 22:05:48 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 2 Jan 2023 22:05:48 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 2 Jan 2023 22:05:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F0ofTYjYL6UKg8PZ95dz+mGCKcW7gFBXC2VWUSnEXs2tfFtkIHjRN0CoST4a1l5EZpcFJvEyzDcbmeLbNWEeU1NtZ/EzIryKYfPJtWb0MC5GSfopLfHgefgk4qm8oKde7SSVrLjh6WvYsmexUE13R14NtpRD0tnRLYgmRkQDn7xxX2sQol+kF5SXrqQ+69eVz+1Srxd3N/rjynCN4xjqNFkBf5d5rLZOjtlV5t0k2PP38OVgMfbh4qkJ5zsKkqt5RtCVUnx/pSE2H+4JlQnzO9Od6yaJgAdptfgvmE++91k0YmMoD/cRImb48MoUQOBynF9ULLF9JrTMsWnZ0I1a9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x8HxWd1waFW7JcsU7vtUdMbI1T6MQOW5RbFQHvE83+U=; b=hfdwAta89jdm3U8wnoTuvMnvhRz4+9IqTLk/J13Pt7cnRzfyIQP6hLtcEdHlkJv0aofqH8lWF6GGDVwZ5CZ2Om0pIoJCSkydYmoKo8GfdjTXmJaQnrVxW0cVBP7/H11aPuaVJkvS7h1w2ikTP7DgQDicsjrgZ1sD1jhtMIJH3MzbBRpeH5CoYtXlLZv4gv9dsSN1UpjgQmFb/iN1KCrhQ8IFDN9ljuTvLQwvQM37w+IhdxWp+I5ruFw4hxvuXUnOSda+bK3sHpJbsJPn4S2UKB+DfS876ETY2VxHxHFyWGeGB+mFBRr+/w8mC47w3Jt+aHQoYWUlzDz6JcLz3JZ0qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4611.namprd11.prod.outlook.com (2603:10b6:5:2a5::11) by SJ0PR11MB4894.namprd11.prod.outlook.com (2603:10b6:a03:2d4::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Tue, 3 Jan 2023 06:05:46 +0000 Received: from DM6PR11MB4611.namprd11.prod.outlook.com ([fe80::d58a:9928:395d:80ee]) by DM6PR11MB4611.namprd11.prod.outlook.com ([fe80::d58a:9928:395d:80ee%8]) with mapi id 15.20.5944.019; Tue, 3 Jan 2023 06:05:46 +0000 From: "Fu, Qi" To: "Xu, Ke1" , "dts@dpdk.org" CC: "Li, WeiyuanX" , "Tu, Lijuan" Subject: RE: [DTS][PATCH V3 0/5] Improve checksum validate and tso packet counting. Thread-Topic: [DTS][PATCH V3 0/5] Improve checksum validate and tso packet counting. Thread-Index: AQHZGnua18y4wOItsE2ksCYzqqybjq6MPcWQ Date: Tue, 3 Jan 2023 06:05:45 +0000 Message-ID: References: <20221228051503.36747-1-ke1.xu@intel.com> In-Reply-To: <20221228051503.36747-1-ke1.xu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4611:EE_|SJ0PR11MB4894:EE_ x-ms-office365-filtering-correlation-id: 2e579484-bbbe-4cf8-391c-08daed508ddb x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JmBYIUnRcuMDYOKD2or//Jxf0PTUGLbcK/AlsRlSypFeg8T5kP9Reg5VgfVi/5VlO3sIj4Dq7tOoPa6ar3j47bgK59TDVJyABUerjhKavDHVfBM0njAptBfPDbKirg9royJKZybx36Pzs8wXVpFn460E9y5QMffN4U/CBAG46sfu/hSN4Mm2wUbf10rilB8OpBDKA/M+SEFkSTG2Uf1qUi9WVk+lFQOJCDcHFy8OrjGy30OqRCukI1Wc/iIIx4H8QlrdKZLjAA00bT6JKnKLTw6tEzknqjVpTvmIED1XI4UwwPvKHU9jrrzqB2HXrOu/p9ZetugWEZUISf1ssLw7jkPXtyu58qEpem53gZiO3TKatO38j72hklJCQ9jxx7rpsJTZ0W/GAt46FBPQrMNXk1L5MUElcWmNyJDwXOJaplTRlIS8tacjlaVp6W289YlVMDD7MCGjGNJrgYQI4MgU3/GYxsH67cw201zMMmcuYa/7VETygAqAGYginGVkNYW3+alR3s37MQVp/c6l2Fw60mfF2eJ4LXAM6QxHFc/v+h84IsoXdABcJMguPEHL5BPf6+l76UU+DvW4njFiqV1tIcldnz6ygAl1ct6fzc37998KwKBcElEV1ZQbDvC6q5I2xYxRksFegTT02RIk0gHa/2TFAvwzSNRo5pC9nPLdRDINRWH6tElI14C7MG8ScgFOcVVBHccaFAre0QMcB5m1djMNQ25Rw7zoyg81WR90jy0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4611.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(366004)(136003)(396003)(39860400002)(376002)(451199015)(83380400001)(9686003)(26005)(53546011)(7696005)(107886003)(55016003)(6506007)(33656002)(86362001)(38070700005)(38100700002)(82960400001)(122000001)(186003)(478600001)(41300700001)(4326008)(8676002)(2906002)(52536014)(5660300002)(8936002)(15650500001)(71200400001)(66556008)(66946007)(76116006)(66476007)(54906003)(316002)(64756008)(66446008)(110136005)(22166006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0cg2JvaTsiyeT8EhTxWd6cGoYFZzhEgA0ZOw7e7mCsiBcixX/ZgA0Yc6QS7D?= =?us-ascii?Q?5qFNYasstrDXE7ypKfVXO3/OT4z89q0Bw+R8dl7XBh2TL32+4Lb9zdV9Cl4r?= =?us-ascii?Q?5/mrxEMX7e/SeggrJCmpFQdGe6ra8h58NK8cUUmWtcR+JdHWu0ZZk1rp1s7X?= =?us-ascii?Q?pBFeSZVgY48hhJ8Zx942wnDyQlaY8GoJvkewjC5iwtnxl2rsoe0Jt5e3WD1r?= =?us-ascii?Q?JEbGmR9xYbOGb1kT0BXjFQ69iOwk9/LcjyvdHsXVmtbxXwoGTITUGmgyN1/v?= =?us-ascii?Q?LnQ1GRyPKOsBIXJSwr563/qcV09t8stUiLiqoZx6V/WgWK4/ObQW4EJgGtR7?= =?us-ascii?Q?yWaQo+82JCSZyMW7zf/cJ4AGSeAIO16v1GHeQLf/uqMoSzB6h73NG7/L0UGC?= =?us-ascii?Q?0IqOUzO0t7bVkUYyDwf6E/x82mvWSihUjt4omSbn0ld/OPxDZq2uQVLjYrFH?= =?us-ascii?Q?TqW5KM3hhtyOwVW/2WbbZW7iSixG0749vYFi09YXjOFuh5JjXrwJoMO8d70X?= =?us-ascii?Q?L9kBjhQBBoK37w0hqWLhiv+xnGJsABh1DWtxaVKEZZcq43RPy4PKAR+qZJcF?= =?us-ascii?Q?MKTEkKHYL1a6Y0EtEXm0SupTy5ptui1uzF6Qa+8fi1qMtVB+kZ5EvpWuT10L?= =?us-ascii?Q?bnw2JFsZUpOLeR2WYWxCcz/p3YxyPQTzz9XGBO6rovMTCnAJ/p56GYcltx3c?= =?us-ascii?Q?Sd716QwVsX4AyZjElAtwVup3S0W4wgpDjT0YhLXA+8WvqBYAwBRlhGtmC60d?= =?us-ascii?Q?2xI69p5FV8liIToRRpYuC2V+9VuBbMYgdYgLOjMVOQbIWEpvI3zFABQnOb2Q?= =?us-ascii?Q?43xKoiGdwtyqFN9Z513FR79V+pbo99N8By/VXJ6rVsHB0FC3bfldH8L52vdn?= =?us-ascii?Q?ygJB32afTXKDfP8yj9oySZz5HWWL25buq0pPvIwAhC24D8DuETf0fhO5BeYa?= =?us-ascii?Q?cFtih1OK5mqbz4ujqSvcKSC9i0RyhfJSRXd2xH8IcbQj7sdWrmxYbtBzr2Yq?= =?us-ascii?Q?p0HzpSUeddS/ppIZBB/keHOXwcHAiEWRbXQOBIE6j97owC+fbP7UBMeN1Qa5?= =?us-ascii?Q?pt0bt73IJDnFv+ABDnHGV0qUPDiRL4Hk6qS/HOzQQNGLsVL4bPbnJgd6vU6l?= =?us-ascii?Q?t6c1Dftuv1Q0JhArJFgvbai5WGEWW9o9WX9U+LHcIGYvBq0ton56u/ECe8LR?= =?us-ascii?Q?bELq24kzanN/dEdCAmGJehEjM2qothOri4viSHTLPh8Ma7+JtKfjdhxgS5OK?= =?us-ascii?Q?t5MzS8dafe0CNQ+Z4iWSp1QLHoezpJhHkBOuKKvYTG0yPXwpbtqPOeyO8sb0?= =?us-ascii?Q?SsDEHM41GnaXYPsfrhzzBU68HSqjIPlMn2rnRBvCwju/FJgETC/QFOtiNRlY?= =?us-ascii?Q?uK8B2UehArplkf4IWIYB1LytrzckfZDeGRgoZ8zFPJHW8IzePcMxYiNebCU5?= =?us-ascii?Q?WYxua5ZJXus8wQg+nTpZY3a6/6iCpX8PBH8VeQZ2unc1dCRp776LWFz8zgaY?= =?us-ascii?Q?yrdeEaXX6ZkvRfF02U8pNbkpmZGFPvjyh2KgigCrD8OCgwr3Nqu8tqjo7846?= =?us-ascii?Q?sKm444nVUSdeVTt9MSM=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4611.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e579484-bbbe-4cf8-391c-08daed508ddb X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2023 06:05:45.8705 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VE2kaByZaLW4BkWpo7fl0ChmCbxS6AWsdBcf1vyEzPIgNPAZbVsKAEi3fs3Z6Wq/ X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4894 X-OriginatorOrg: intel.com X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Acked-by: Fu, Qi > -----Original Message----- > From: Xu, Ke1 > Sent: Wednesday, December 28, 2022 1:15 PM > To: dts@dpdk.org > Cc: Fu, Qi ; Li, WeiyuanX ; Tu, > Lijuan ; Xu, Ke1 > Subject: [DTS][PATCH V3 0/5] Improve checksum validate and tso packet > counting. >=20 > This patch updates checksum_validate method and remove the tunnel one. >=20 > Use packet.show(dump) methods and packet reading to validate the > packets in a faster, more common and more stable way. This allows > packets other than the plain packets can be verified by method > checksum_validate. This updated method replaces > checksum_validate_tunnel in checksum offload cases. >=20 > This patch also updates TSO packet checking. Replace the tcpdump > implementation to a packet reading implementation. >=20 > Packet reading implementation is more common to use when to verify the > received packet count and payload size. The tcpdump method is not able > to recognize some of the tunnel packets, leading to a wrong output faili= ng > the validation. Newly added tcpdump_analyse_sniff method is > implemented by sniff packet reading and analysing and can replace the > lagacy methods number_of_packets and number_of_bytes. >=20 > This patch also removes a redundant variable. >=20 > Ke Xu (5): > tests/vf_offload: Improve checksum_validate method. > tests/vf_offload: Remove redundant variable used. > tests/vf_offload: Use modified checksum_validate to replace > checksum_validate_tunnel. > tests/vf_offload: Improve tcpdump_analyse_sniff method > tests/vf_offload: Replace the tcpdump implementation to a packet > reading implementation. >=20 > tests/TestSuite_vf_offload.py | 247 +++++++++------------------------- > 1 file changed, 66 insertions(+), 181 deletions(-) >=20 > -- > 2.25.1