test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V3] tests/dynamic_queue: unbind the unused ports
@ 2018-12-14  6:30 Wenjie Li
  2018-12-18  5:50 ` Zhu, WenhuiX
  2018-12-22  1:52 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Wenjie Li @ 2018-12-14  6:30 UTC (permalink / raw)
  To: dts; +Cc: Wenjie Li

Instead of reduce the queue number for fvl_40G, unbind the unused ports
for all nics during test, and bind them after this test suite is done.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_dynamic_queue.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_dynamic_queue.py b/tests/TestSuite_dynamic_queue.py
index f155686..e145f53 100644
--- a/tests/TestSuite_dynamic_queue.py
+++ b/tests/TestSuite_dynamic_queue.py
@@ -25,6 +25,11 @@ class TestDynamicQueue(TestCase):
         tester_port = self.tester.get_local_port(self.used_dut_port)
         self.tester_intf = self.tester.get_interface(tester_port)
         self.dut_testpmd = PmdOutput(self.dut)
+        unbind_nics = []
+        if len(self.dut_ports) >= 2:
+            for i in range (1, len(self.dut_ports)):
+                unbind_nics.append(self.dut_ports[1])
+        self.dut.unbind_interfaces_linux(unbind_nics)
 
     def set_up(self):
         self.dut_testpmd.start_testpmd(
@@ -194,4 +199,4 @@ class TestDynamicQueue(TestCase):
         self.dut_testpmd.quit()
 
     def tear_down_all(self):
-        pass
+        self.dut.bind_interfaces_linux(driver=self.drivername)
-- 
2.17.2

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V3] tests/dynamic_queue: unbind the unused ports
  2018-12-14  6:30 [dts] [PATCH V3] tests/dynamic_queue: unbind the unused ports Wenjie Li
@ 2018-12-18  5:50 ` Zhu, WenhuiX
  2018-12-22  1:52 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Zhu, WenhuiX @ 2018-12-18  5:50 UTC (permalink / raw)
  To: Li, WenjieX A, dts; +Cc: Li, WenjieX A, Zhu, WenhuiX

Tested-by: Zhu, WenhuiX <wenhuix.zhu@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
Sent: Friday, December 14, 2018 2:31 PM
To: dts@dpdk.org
Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
Subject: [dts] [PATCH V3] tests/dynamic_queue: unbind the unused ports

Instead of reduce the queue number for fvl_40G, unbind the unused ports for all nics during test, and bind them after this test suite is done.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_dynamic_queue.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_dynamic_queue.py b/tests/TestSuite_dynamic_queue.py
index f155686..e145f53 100644
--- a/tests/TestSuite_dynamic_queue.py
+++ b/tests/TestSuite_dynamic_queue.py
@@ -25,6 +25,11 @@ class TestDynamicQueue(TestCase):
         tester_port = self.tester.get_local_port(self.used_dut_port)
         self.tester_intf = self.tester.get_interface(tester_port)
         self.dut_testpmd = PmdOutput(self.dut)
+        unbind_nics = []
+        if len(self.dut_ports) >= 2:
+            for i in range (1, len(self.dut_ports)):
+                unbind_nics.append(self.dut_ports[1])
+        self.dut.unbind_interfaces_linux(unbind_nics)
 
     def set_up(self):
         self.dut_testpmd.start_testpmd( @@ -194,4 +199,4 @@ class TestDynamicQueue(TestCase):
         self.dut_testpmd.quit()
 
     def tear_down_all(self):
-        pass
+        self.dut.bind_interfaces_linux(driver=self.drivername)
--
2.17.2

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V3] tests/dynamic_queue: unbind the unused ports
  2018-12-14  6:30 [dts] [PATCH V3] tests/dynamic_queue: unbind the unused ports Wenjie Li
  2018-12-18  5:50 ` Zhu, WenhuiX
@ 2018-12-22  1:52 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2018-12-22  1:52 UTC (permalink / raw)
  To: Li, WenjieX A, dts; +Cc: Li, WenjieX A

Could you clarify why it' s necessary to reduce the ports to only one?
BTW, though you'd like to use only one port, unbind/bind ports is not a good option, prefer to add testpmd parameter "-w self.dut.get_port_pci(self.dut_ports[0])".

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
> Sent: Friday, December 14, 2018 2:31 PM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V3] tests/dynamic_queue: unbind the unused ports
> 
> Instead of reduce the queue number for fvl_40G, unbind the unused ports for
> all nics during test, and bind them after this test suite is done.
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
>  tests/TestSuite_dynamic_queue.py | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_dynamic_queue.py
> b/tests/TestSuite_dynamic_queue.py
> index f155686..e145f53 100644
> --- a/tests/TestSuite_dynamic_queue.py
> +++ b/tests/TestSuite_dynamic_queue.py
> @@ -25,6 +25,11 @@ class TestDynamicQueue(TestCase):
>          tester_port = self.tester.get_local_port(self.used_dut_port)
>          self.tester_intf = self.tester.get_interface(tester_port)
>          self.dut_testpmd = PmdOutput(self.dut)
> +        unbind_nics = []
> +        if len(self.dut_ports) >= 2:
> +            for i in range (1, len(self.dut_ports)):
> +                unbind_nics.append(self.dut_ports[1])
> +        self.dut.unbind_interfaces_linux(unbind_nics)
> 
>      def set_up(self):
>          self.dut_testpmd.start_testpmd( @@ -194,4 +199,4 @@ class
> TestDynamicQueue(TestCase):
>          self.dut_testpmd.quit()
> 
>      def tear_down_all(self):
> -        pass
> +        self.dut.bind_interfaces_linux(driver=self.drivername)
> --
> 2.17.2

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-12-22  1:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-14  6:30 [dts] [PATCH V3] tests/dynamic_queue: unbind the unused ports Wenjie Li
2018-12-18  5:50 ` Zhu, WenhuiX
2018-12-22  1:52 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).