test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Zhu, WenhuiX" <wenhuix.zhu@intel.com>
To: "Zhang, YanX A" <yanx.a.zhang@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Zhang, YanX A" <yanx.a.zhang@intel.com>
Subject: Re: [dts] [PATCH V1] tests/TestSuite_ddp_mpls:Improve the way drivers	bind
Date: Thu, 27 Jun 2019 08:26:10 +0000	[thread overview]
Message-ID: <E08767FB2CE10642B6780736EAC070F60497C249@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1561623057-83510-1-git-send-email-yanx.a.zhang@intel.com>


Tested-by: Zhu, WenhuiX <wenhuix.zhu@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhang,yan
Sent: Thursday, June 27, 2019 4:11 PM
To: dts@dpdk.org
Cc: Zhang, YanX A <yanx.a.zhang@intel.com>
Subject: [dts] [PATCH V1] tests/TestSuite_ddp_mpls:Improve the way drivers bind

Instead of the original single binding driver,

Signed-off-by: zhang,yan <yanx.a.zhang@intel.com>
---
 tests/TestSuite_ddp_mpls.py | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_ddp_mpls.py b/tests/TestSuite_ddp_mpls.py index b002788..599e5cd 100644
--- a/tests/TestSuite_ddp_mpls.py
+++ b/tests/TestSuite_ddp_mpls.py
@@ -16,6 +16,7 @@ PF_MAX_QUEUE = 64
 VF_MAX_QUEUE = 4
 
 class Testddp_mpls(TestCase):
+    supported_vf_driver = ['pci-stub', 'vfio-pci']
 
     def set_up_all(self):
         self.verify('fortville' in self.nic, @@ -28,6 +29,15 @@ class Testddp_mpls(TestCase):
         profile_dst = "/tmp/"
         self.dut.session.copy_file_to(profile_file, profile_dst)
 
+        self.vf_driver = self.get_suite_cfg()['vf_driver']
+        if self.vf_driver is None:
+            self.vf_driver = 'pci-stub'
+        self.verify(self.vf_driver in self.supported_vf_driver, "Unspported vf driver")
+        if self.vf_driver == 'pci-stub':
+            self.vf_assign_method = 'pci-assign'
+        else:
+            self.vf_assign_method = 'vfio-pci'
+            self.dut.send_expect('modprobe vfio-pci', '#')
 
     def set_up(self):
         self.setup_vm_env()
@@ -50,7 +60,7 @@ class Testddp_mpls(TestCase):
                     netdev.bind_driver(driver=driver)
 
 
-    def setup_vm_env(self, driver='igb_uio'):
+    def setup_vm_env(self, driver='default'):
         """
         Create testing environment with VF generated from 1PF
         """
@@ -65,7 +75,7 @@ class Testddp_mpls(TestCase):
             self.sriov_vfs_port = self.dut.ports_info[
                 self.used_dut_port]['vfs_port']
             for port in self.sriov_vfs_port:
-                    port.bind_driver('pci-stub')
+                port.bind_driver(self.vf_driver)
             time.sleep(1)
             self.dut_testpmd = PmdOutput(self.dut)
             time.sleep(1)
@@ -73,7 +83,7 @@ class Testddp_mpls(TestCase):
         
             # set up VM0 ENV
             self.vm0 = QEMUKvm(self.dut, 'vm0', 'ddp_mpls')
-            self.vm0.set_vm_device(driver='pci-assign', **vf0_prop)
+            self.vm0.set_vm_device(driver=self.vf_assign_method, 
+ **vf0_prop)
             try:
                 self.vm0_dut = self.vm0.start()
                 if self.vm0_dut is None:
--
2.17.2


  reply	other threads:[~2019-06-27  8:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27  8:10 zhang,yan
2019-06-27  8:26 ` Zhu, WenhuiX [this message]
2019-07-03  6:13 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E08767FB2CE10642B6780736EAC070F60497C249@shsmsx102.ccr.corp.intel.com \
    --to=wenhuix.zhu@intel.com \
    --cc=dts@dpdk.org \
    --cc=yanx.a.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).